Cannot have two passmarks on same line

Issue #975 closed
basha17 created an issue

When having two passmarks on same line I get error message :Cannot calculate a notch for point 'A29' in piece 'Top_Back'. Unable to fix a notch position.

Comments (5)

  1. Roman Telezhynskyi repo owner

    To help you i need to see your pattern. This seems like issue with seam allowance.

  2. Douglas Caskey

    Seems more like an issue with moving notch functionality to their own class… everything is mucked up! Do you ever test anything BEFORE commiting changes? <sigh>

    I did a test and opened in the latest test build (0.7.0.467a) and not only are the notches showing up on the wrong point(s), the direction is wrong and who knows what else.

    No way to attach file but here' s the val xml…

    <?xml version="1.0" encoding="UTF-8"?> <pattern labelPrefix="en"> <!--Pattern created with Valentina v0.7.0.341a (https://valentinaproject.bitbucket.io/).--> <version>0.8.5</version> <unit>inch</unit> <description/> <notes/> <measurements/> <increments/> <previewCalculations/> <draw name="Pattern piece 1"> <calculation> <point id="1" mx="0.0520833" my="0.104167" name="A" showLabel="true" type="single" x="0.3125" y="0.416667"/> <point angle="130.137" basePoint="1" id="2" length="6.7322" lineColor="black" mx="0.0520833" my="0.104167" name="A1" showLabel="true" type="endLine" typeLine="hair"/> <point angle="49.377" basePoint="1" id="3" length="6.75587" lineColor="black" mx="0.0520833" my="0.104167" name="A2" showLabel="true" type="endLine" typeLine="hair"/> <line firstPoint="2" id="4" lineColor="black" secondPoint="3" typeLine="hair"/> <point firstPoint="1" id="5" length="2" lineColor="black" mx="0.0520833" my="0.104167" name="A3" secondPoint="3" showLabel="true" type="alongLine" typeLine="none"/> <point firstPoint="1" id="6" length="4" lineColor="black" mx="0.0520833" my="0.104167" name="A4" secondPoint="3" showLabel="true" type="alongLine" typeLine="none"/> </calculation> <modeling> <point id="7" idObject="1" inUse="true" mx="0.0520833" my="0.104167" showLabel="true" type="modeling"/> <point id="8" idObject="2" inUse="true" mx="0.0520833" my="0.104167" showLabel="true" type="modeling"/> <point id="9" idObject="3" inUse="true" mx="0.0520833" my="0.104167" showLabel="true" type="modeling"/> <point id="11" idObject="5" inUse="true" mx="0.0520833" my="0.104167" showLabel="true" type="modeling"/> <point id="12" idObject="6" inUse="true" mx="0.0520833" my="0.104167" showLabel="true" type="modeling"/> </modeling> <details> <detail forbidFlipping="true" forceFlipping="false" hideMainPath="false" id="10" mx="0" my="0" name="Detail" seamAllowance="true" version="2" width="0.5"> <data annotation="" foldPosition="" fontSize="0" height="1" letter="" mx="0" my="0" onFold="false" orientation="" quantity="1" rotation="0" rotationWay="" tilt="" visible="false" width="1"/> <patternInfo fontSize="0" height="1" mx="0" my="0" rotation="0" visible="false" width="1"/> <grainline arrows="0" length="1" mx="0" my="0" rotation="90" visible="false"/> <nodes> <node idObject="7" type="NodePoint"/> <node idObject="8" type="NodePoint"/> <node idObject="9" type="NodePoint"/> <node idObject="11" manualPassmarkLength="true" passmark="true" passmarkAngle="straightforward" passmarkLength="0.393701" passmarkLine="two" type="NodePoint"/> <node idObject="12" passmark="true" passmarkAngle="straightforward" passmarkLine="one" type="NodePoint"/> </nodes> </detail> </details> </draw> </pattern>

  3. Roman Telezhynskyi repo owner

    Seems more like an issue with moving notch functionality to their own class… everything is mucked up! Do you ever test anything BEFORE commiting changes? <sigh>

    I have two things to say:

    • “Those who can, do; those who can't, teach”
    • “Talk is cheap. Show me the code.” Linus Torvalds

    No way to attach file but here' s the val xml…

    Open your eyes and find the Attach files menu option.

  4. Roman Telezhynskyi repo owner

    I did a test and opened in the latest test build (0.7.0.467a) and not only are the notches showing up on the wrong point(s), the direction is wrong and who knows what else.

    Do you ever test anything BEFORE commiting changes? <sigh>

    @Douglas Caskey Well, your file just wrong. Your piece has wrong nodes order. When you will fix it everything will be fine.

  5. Log in to comment