tortoisehg / stable (http://tortoisehg.bitbucket.org/)

TortoiseHg repository. Main line of development in "default" branch. Releases, bugfixes, and documentation improvements in "stable" branch.

Clone this repository (size: 76.0 MB): HTTPS / SSH
$ hg clone http://bitbucket.org/tortoisehg/stable/
← Back to results
follow

#888 Traceback in quickop - add

Reported by Anonymous, created 2 months ago, last edited unknown. 

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12

** Please report this bug to http://bitbucket.org/tortoisehg/stable/issues or tortoisehg-discuss@lists.sourceforge.net
** Mercurial version (1.4.2).  TortoiseHg version (0.9.2)
** Command: --nofork add --listfile C:\DOCUME~1\VANACK~1\LOCALS~1\Temp\THG5.tmp
** CWD: D:\riskLib
** Extensions loaded: extdiff
Recoverable runtime error (stderr):
C:\Program Files\TortoiseHg\library.zip\tortoisehg\hgtk\hgtk.py:275: PangoWarning: couldn't load font "MS UI Gothic Not-Rotated 9", falling back to "Sans Not-Rotated 9", expect ugly output.
Traceback (most recent call last):
  File "tortoisehg\hgtk\quickop.pyo", line 193, in dialog_response
  File "tortoisehg\hgtk\quickop.pyo", line 269, in operation
  File "tortoisehg\hgtk\quickop.pyo", line 217, in switch_to
AttributeError: 'QuickOpDialog' object has no attribute 'abortbtn'
Followers: 0
Status: resolved Responsible: Yuki KODAMA / kuy Type: bug
Milestone: none Component: quickop Version: 0.9.2

Attachments

No attachments added for this issue yet.

Comments and changes

#1

Steve Borho / sborho
written 2 months ago, last edited unknown.

→ Changed version from 0.9 to 0.9.2.

→ Changed component from nothing to quickop.

→ Changed responsible from nobody to tortoisehg.

→ Changed status from new to open.

#2

Steve Borho / sborho
written 2 months ago, last edited unknown.

→ Changed title from Python bug ? to Traceback in quickop - add.

#3

Steve Borho / sborho
written 8 weeks ago, last edited unknown.

Yuki: it's straight-forward to add 'hasattr' checks in the 'switch_to' function, but I'm curious why the creation of the abort button is done in an idle-callback and then hidden. Any reason not to create and hide the button at startup?


#4

Yuki KODAMA / kuy
written 8 weeks ago, last edited 8 weeks ago.

Steve: Yes, here is the reason: since abort button shouldn't be shown at starup, I didn't want to add it at startup. Of couse I could add and hide the button, but it causes somewhat flickers.

But now we can resolve the problem of flicker with set_no_show_all() function; it can be used to let the widget ignore show_all() function callings. Unfortunately, when I designed GDialog framework (not GWindow), I didn't know the existence of set_no_show_all().

P.S. probably we can remove most of after_init() callings from TortoiseHg with set_no_show_all().


#5

Steve Borho / sborho
written 8 weeks ago, last edited unknown.

I see. Is that already on your TODO list?


#6

Yuki KODAMA / kuy
written 8 weeks ago, last edited 8 weeks ago.

Yeah, but now I'm adding icons to context menus for each TortoiseHg window/dialog (and it needs to some refactoring: introduces gtklib.MenuBuilder based on gtklib.MenuItems), so will do later :)


#7

Yuki KODAMA / kuy
written 8 weeks ago, last edited unknown.

→ Changed responsible from tortoisehg to kuy.

#8

Yuki KODAMA / kuy
written 8 weeks ago, last edited unknown.

→ Changed status from open to resolved.

quickop: prevent AttributeError caused by 'self.abortbtn'

Finally, I figured out that 'set_no_show_all()' can not be used to prevent adding bottom buttons by 'add_button()'. So I had to defer it and add it in 'after_init()'.

Fixes #888

→ r5668:d0cbd66e993e


#9

Yuki KODAMA / kuy
written 8 weeks ago, last edited unknown.

gdialog: prevent AttributeError caused by 'self.abortbtn'

This changeset brings same fix as <d0cbd66e993e> on stable.

Refs #888

→ r5670:5e6e5acccfb1


Add comment / attachment

Show/hide preview

Verification: Please write the text from the image in the box (letters only)

captcha

Is that you, Humanoid? Is this me?