1. Aram Hăvărneanu
  2. go-sunos

Branches

release-branch.go1

View source
port-sunos
change destination
release-branch.go1
Author Commit Message Date Builds
250+ commits behind port-sunos.
Andrew Gerrand
[release-branch.go1] doc: clarify that the displayed tar file name is an example ««« CL 6573065 / 49b27543b08b doc: clarify that the displayed tar file name is an example R=golang-dev, dave, r CC=golang-dev http://codereview.appspot.com/6573065 »»» R=golang-dev CC=golang-dev http://codereview.appspot.com/6571068
Andrew Gerrand
[release-branch.go1] doc: fix OS X download links ««« CL 6566064 / f58eb9ea0d1d doc: fix OS X download links R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6566064 »»» R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6566065
Andrew Gerrand
[release-branch.go1] syscall: use exported StringToUTF16 in windows test R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6551056
Alex Brainman
net/http: disable TestServeFileFromCWD test on windows This is an attempt to fix windows build. Will restore once we know what the problem is. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6461046
Andrew Gerrand
[release-branch.go1] update VERSION to go1.0.3
Andrew Gerrand
[release-branch.go1] remove src/pkg/exp
Andrew Gerrand
[release-branch.go1] net/http: add missing hasToken function
Andrew Gerrand
[release-branch.go1] doc: document go1.0.3 ««« backport 671c5b05dc40 doc: document go1.0.3 R=rsc, r CC=gobot, golang-dev http://codereview.appspot.com/6532049 »»»
Andrew Gerrand
[release-branch.go1] doc/talks: remove talks, refer to talks.golang.org instead ««« backport e3b986984e53 doc/talks: remove talks, refer to talks.golang.org instead These talks have been moved to the go.talks sub-repository: https://code.google.com/p/go.talks R=rsc, r CC=gobot, golang-dev http://codereview.appspot.com/6529052 »»»
Adam Langley
[release-branch.go1] A+C: Add Andrew Harding (Individual CLA) ««« backport f041c9b94d6a A+C: Add Andrew Harding (Individual CLA) R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6544044 »»»
Robert Griesemer
[release-branch.go1] encoding/gob: fix comment ««« backport ee8276dbea49 encoding/gob: fix comment Fixes issue 4100. R=adg, r, dave CC=golang-dev http://codereview.appspot.com/6535055 »»»
minux
[release-branch.go1] src/all.bat: fix banner ««« backport 2f7827571b44 src/all.bat: fix banner we need to restore %PATH% before calling "dist banner", so that it could suggest the user to add %GOROOT%/bin to %PATH% if necessary. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6525049 »»»
Anthony Eufemio
[release-branch.go1] builtin: Changed documentation for rune type. ««« backport 6cfab3a0935e builtin: Changed documentation for rune type. Fixes issue 4093. R=golang-dev, bradfitz, r CC=golang-dev http://codereview.appspot.com/6536047 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Brad Fitzpatrick
[release-branch.go1] A+C: Add Anthony Eufemio (Individual CLA) ««« backport 773a05fbc002 A+C: Add Anthony Eufemio (Individual CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6524045 »»»
Oling Cat
[release-branch.go1] doc/effective_go: Closed some tags; removed extra spaces. ««« backport 04608c28273f doc/effective_go: Closed some tags; removed extra spaces. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6488122 Committer: Andrew Gerrand <adg@golang.org> »»»
Nigel Tao
[release-branch.go1] image/jpeg: ignore an incorrect but harmless trailing restart marker. ««« backport 7af3dbecf445 image/jpeg: ignore an incorrect but harmless trailing restart marker. Fixes issue 4084. R=r CC=golang-dev http://codereview.appspot.com/6526043 »»»
Andrew Gerrand
[release-branch.go1] doc: document OS X tarballs ««« backport 195e4fc09b2d doc: document OS X tarballs R=golang-dev CC=golang-dev http://codereview.appspot.com/6506129 »»»
Eric Roshan-Eisner
[release-branch.go1] A+C: update Eric Roshan-Eisner ««« backport b7ce1e467a60 A+C: update Eric Roshan-Eisner R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6492135 Committer: David Symonds <dsymonds@golang.org> »»»
minux
[release-branch.go1] run.bash: fix a typo (fix build) ««« backport 11cdfc399090 run.bash: fix a typo (fix build) R=golang-dev CC=golang-dev http://codereview.appspot.com/6506121 »»»
minux
[release-branch.go1] run.bash: set appropriate ulimits ««« backport a97b81d2600f run.bash: set appropriate ulimits mainly for NetBSD/OpenBSD. R=bradfitz, r, rsc CC=golang-dev http://codereview.appspot.com/6453154 »»»
minux
[release-branch.go1] runtime: fix SI_USER for FreeBSD ««« backport 283f6087807b runtime: fix SI_USER for FreeBSD Ref: http://svnweb.freebsd.org/base/head/sys/sys/signal.h?revision=HEAD&view=markup R=golang-dev, devon.odell, r CC=golang-dev http://codereview.appspot.com/6490118 »»»
Brad Fitzpatrick
[release-branch.go1] os/exec: don't crash when out of fds ««« backport 00e1feaa9218 os/exec: don't crash when out of fds Command.Start could crash before if no fds were available because a nil *os.File of /dev/null was added to the cleanup list, which crashed before returning the proper error. R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6514043 »»»
Andrew Gerrand
[release-branch.go1] A+C: add Xing Xing (individual CLA) ««« backport 449c9a4af2f1 A+C: add Xing Xing (individual CLA) R=golang-dev, nigeltao CC=golang-dev http://codereview.appspot.com/6493121 »»»
Rob Pike
[release-branch.go1] effective_go: use html/template instead of text/template ««« backport e3fce06291ec effective_go: use html/template instead of text/template Should have done this a long time ago. Fixes issue 3811. R=golang-dev, adg, rsc CC=golang-dev http://codereview.appspot.com/6488120 »»»
Brad Fitzpatrick
[release-branch.go1] build: print go banner before restoring windows PATH ««« backport 452fc24c7ed3 build: print go banner before restoring windows PATH R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6492117 »»»
Russ Cox
[release-branch.go1] html/template: fix URL doc ««« backport fead9e11a489 html/template: fix URL doc This is the easy part of issue 3528. (What to do about "noescape" is the hard part, left open.) Update issue 3528. R=mikesamuel, r, dsymonds CC=golang-dev http://codereview.appspot.com/6493113 »»»
Russ Cox
[release-branch.go1] net/rpc/jsonrpc: fix test error message ««« backport cbce1b576493 net/rpc/jsonrpc: fix test error message Fixes issue 4041. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6495121 »»»
Russ Cox
[release-branch.go1] cmd/dist: emit \r in env -w output ««« backport 108165c03c70 cmd/dist: emit \r in env -w output go tool dist env -w is supposed to print a Windows batch file. Normally Windows will execute batch files without \r before \n, but issue 3060 reports that if the file ends up containing paths written in Chinese, Windows 7 cannot execute it without the \r. So add the \r. Fixes issue 3060. R=golang-dev, bradfitz CC=golang-dev http://cod…
Ian Lance Taylor
[release-branch.go1] C: Add Andreas Jellinghaus (Google CLA) ««« backport 993e67dd76c4 C: Add Andreas Jellinghaus (Google CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6494121 »»»
Andrew Gerrand
[release-branch.go1] C: add Francesc Campoy (Google CLA) ««« backport 3796fdf0d0b8 C: add Francesc Campoy (Google CLA) R=golang-dev, dsymonds, campoy CC=golang-dev http://codereview.appspot.com/6490102 »»»
Andrew Gerrand
[release-branch.go1] C: spell Brian's name correctly ««« backport 50457a54c26c C: spell Brian's name correctly R=iant, nigeltao CC=golang-dev http://codereview.appspot.com/6492102 »»»
Andrew Gerrand
[release-branch.go1] C: add Brian Slesinsky (Google CLA) ««« backport bfa71d733e8f C: add Brian Slesinsky (Google CLA) R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6496103 »»»
dsymonds
[release-branch.go1] doc: Don't imply incorrect guarantees about data races. ««« backport dbcfb4459ab8 doc: Don't imply incorrect guarantees about data races. A race between a = "hello, world" and print(a) is not guaranteed to print either "hello, world" or "". Its behaviour is undefined. Fixes issue 4039. R=rsc CC=dvyukov, gobot, golang-dev, r http://codereview.appspot.com/6489075 »»»
Adam Langley
[release-branch.go1] crypto/rand: typo fix from a69e30463bf4 ««« backport 7047e253f1cd crypto/rand: typo fix from a69e30463bf4 R=golang-dev CC=golang-dev http://codereview.appspot.com/6497106 »»»
Adam Langley
[release-branch.go1] crypto/rand: zero length reads shouldn't crash on Windows. ««« backport a69e30463bf4 crypto/rand: zero length reads shouldn't crash on Windows. R=golang-dev, dave CC=golang-dev http://codereview.appspot.com/6496099 »»»
Rob Pike
[release-branch.go1] faq: go does not have duck typing ««« backport d3d3e0825dd2 faq: go does not have duck typing R=golang-dev, 0xjnml, iant, adonovan, aram CC=golang-dev http://codereview.appspot.com/6500092 »»»
Rob Pike
[release-branch.go1] faq: mercurial vs. git ««« backport 4a9c3b3e39c6 faq: mercurial vs. git Fixes issue 4052. R=golang-dev, bradfitz, iant, rsc CC=golang-dev http://codereview.appspot.com/6490092 »»»
Lucio De Re
[release-branch.go1] net,mime: Minor corrections to documentation comments. ««« backport 3da1d25fd216 net,mime: Minor corrections to documentation comments. R=r CC=dsymonds, gobot, golang-dev http://codereview.appspot.com/6495085 Committer: Rob Pike <r@golang.org> »»»
Rob Pike
[release-branch.go1] faq: another way to solve the closure/variable/range complaint ««« backport 3bca7b333e00 faq: another way to solve the closure/variable/range complaint It's easier just to declare a new variable. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6501103 »»»
Andrew Gerrand
[release-branch.go1] C: add Manu Garg (Google CLA) ««« backport f06edb3fcffe C: add Manu Garg (Google CLA) R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6493087 »»»
Nigel Tao
[release-branch.go1] image/jpeg: fix quantization tables to be in zig-zag order, not natural ««« backport 292816148e44 image/jpeg: fix quantization tables to be in zig-zag order, not natural order. JPEG images generated prior to this CL are still valid JPEGs, as the quantization tables used are encoded in the wire format. Such JPEGs just don't use the recommended quantization tables. R=r, dsymonds, raph, adg CC=golang-dev, tuom.larsen http://codereview.appspot.com/6497083 »»»
Oling Cat
[release-branch.go1] doc/go_spec: fix a typo ««« backport 5bf4d4da76e9 doc/go_spec: fix a typo R=nigeltao CC=golang-dev http://codereview.appspot.com/6499075 Committer: Nigel Tao <nigeltao@golang.org> »»»
Nigel Tao
[release-branch.go1] A+C: Oling Cat (individual CLA) ««« backport 4c0b47f8b8f7 A+C: Oling Cat (individual CLA) R=dsymonds CC=golang-dev http://codereview.appspot.com/6503070 »»»
Sébastien Paolacci
[release-branch.go1] net: fix {FileConn, FileListener, FilePacketConn} fd leak to child process. ««« backport d694b1866058 net: fix {FileConn, FileListener, FilePacketConn} fd leak to child process. All of them call `newFileFD' which must properly restore close-on-exec on duplicated fds. R=golang-dev, bradfitz, mikioh.mikioh CC=golang-dev http://codereview.appspot.com/6445081 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Alan Donovan
[release-branch.go1] runtime/pprof: emit end-of-log marker at end of CPU profile. ««« backport 92e962e13197 runtime/pprof: emit end-of-log marker at end of CPU profile. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6489065 »»»
Andrew Gerrand
[release-branch.go1] doc: fix typo in Concurrency Patterns article ««« backport 29990fa0951c doc: fix typo in Concurrency Patterns article Fixes issue 3178. R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6506064 »»»
Andrew Gerrand
[release-branch.go1] doc: link to references from docs page ««« backport bbf84838fd24 doc: link to references from docs page Fixes issue 3667. R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6492078 »»»
Patrick Crosby
[release-branch.go1] net/http/pprof: updated documentation (run an http server) ««« backport 4965beed4492 net/http/pprof: updated documentation (run an http server) Added instructions for starting an http server to the godoc header for this package. With the old instructions, the example "go tool pprof..." commands wouldn't work unless you happen to be running an http server on port 6060 in your application. R=golang-dev, minux.ma, adg, giacomo.tartari CC=golang-dev http:/…
Andrew Gerrand
[release-branch.go1] runtime: increase stack frame during cgo call on windows/amd64
Russ Cox
[release-branch.go1] cmd/gc: fix PkgPath of byte, rune types ««« backport 272e1dd72156 cmd/gc: fix PkgPath of byte, rune types Fixes issue 3853. R=ken2 CC=golang-dev http://codereview.appspot.com/6492071 »»»
Russ Cox
[release-branch.go1] A+C: add Uriel Mangado (individual CLA) ««« backport 42966db90999 A+C: add Uriel Mangado (individual CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6492070 »»»
minux
[release-branch.go1] cmd/ld: support zero-filled section for Mach-O files ««« backport b4b475a9a3c8 cmd/ld: support zero-filled section for Mach-O files R=golang-dev, r, dave, rsc CC=golang-dev http://codereview.appspot.com/6492069 »»»
Daniel Morsing
[release-branch.go1] cmd/gc: Suggest *T in error for x.(T) if it would work. ««« backport 33a62d86ca2f cmd/gc: Suggest *T in error for x.(T) if it would work. Accomplished by synchronizing the formatting of conversion errors between typecheck.c and subr.c Fixes issue 3984. R=golang-dev, remyoudompheng, rsc CC=golang-dev http://codereview.appspot.com/6500064 Committer: Russ Cox <rsc@golang.org> »»»
Russ Cox
[release-branch.go1] cmd/go: be clear that import loops are bad ««« backport f697709b5082 cmd/go: be clear that import loops are bad There was mail on golang-nuts a few weeks ago from someone who understood the message perfectly and knew he had a cyclic dependency but assumed that Go, like Python or Java, was supposed to handle it. R=golang-dev, bradfitz, dave CC=golang-dev http://codereview.appspot.com/6488069 »»»
Russ Cox
[release-branch.go1] A+C: 0/2 on spelling email addresses correctly ««« backport 30d7ee9da51d A+C: 0/2 on spelling email addresses correctly TBR=r CC=golang-dev http://codereview.appspot.com/6497067 »»»
Russ Cox
[release-branch.go1] A+C: Patrick Higgins, Shawn Smith (individual CLA) ««« backport f8b14fa18a7f A+C: Patrick Higgins, Shawn Smith (individual CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6492067 »»»
Ivan Krasin
[release-branch.go1] runtime: add vdso support for linux/amd64. Fixes issue 1933. ««« backport 56ea40aac72b runtime: add vdso support for linux/amd64. Fixes issue 1933. R=iant, imkrasin, krasin, iant, minux.ma, rsc, nigeltao, r, fullung CC=golang-dev http://codereview.appspot.com/6454046 Committer: Russ Cox <rsc@golang.org> »»»
Andrew Gerrand
[release-branch.go1] cmd/gc: fix escape analysis bug with variable capture in loops.
Russ Cox
[release-branch.go1] runtime/pprof: restore articles in type doc comments ««« backport b57b5be5a32c runtime/pprof: restore articles in type doc comments Reverts part of CL 6460082. If a doc comment describes a type by explaining the meaning of one instance of the type, a leading article is fine and makes the text less awkward. Compare: // A dog is a kind of animal. // Dog is a kind of animal. R=golang-dev, dsymonds, dvyukov, r CC=golang-dev http://codereview.appspot…
Robert Griesemer
[release-branch.go1] A+C: added Alan Donovan (Google corporate license) ««« backport e6da0262840c A+C: added Alan Donovan (Google corporate license) R=adg, bradfitz CC=golang-dev http://codereview.appspot.com/6490063 »»»
Robert Griesemer
[release-branch.go1] go/scanner: don't print garbage if there's no error ««« backport 9415be2ba652 go/scanner: don't print garbage if there's no error R=r CC=golang-dev http://codereview.appspot.com/6489059 »»»
Rob Pike
[release-branch.go1] path: improve documentation for Dir ««« backport 735963d94dad path: improve documentation for Dir R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6495059 »»»
Dmitriy Vyukov
[release-branch.go1] net/rpc: protect serviceMap with RWMutex ««« backport fa3b2ef0129d net/rpc: protect serviceMap with RWMutex R=r, r CC=golang-dev http://codereview.appspot.com/6494044 »»»
Rob Pike
[release-branch.go1] go_spec.html: clarify rune and string literals ««« backport 8afe25accb81 go_spec.html: clarify rune and string literals No changes to the meaning, just clearer language and more examples, including illegal rune and string literals. In particular, "character literal" and "character constant" are now called "rune literal" and "rune constant" and the word "character" always refers to the source text, not program values. R=golang-dev, gri CC=gola…
Andrew Balholm
[release-branch.go1] cmd/yacc/units.txt: fix exchange rates ««« backport 008d345d81e0 cmd/yacc/units.txt: fix exchange rates In the example "units" program for goyacc, the exchange rates were reciprocals of the correct amounts. Turn them right-side-up and update them to current figures. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6495053 Committer: Rob Pike <r@golang.org> »»»
Andrew Gerrand
[release-branch.go1] cmd/ld: handle a special case of scattered relocation 2/1 on Darwin/386
Andrew Gerrand
[release-branch.go1] A+C: add Patrick Crosby (individual contributor) ««« backport 3181682928c9 A+C: add Patrick Crosby (individual contributor) R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6489049 »»»
Dave Cheney
[release-branch.go1] net/http/httputil: fix race in DumpRequestOut ««« backport 3b78b41a4b50 net/http/httputil: fix race in DumpRequestOut Fixes issue 3892. Swapping the order of the writers inside the MultiWriter ensures the request will be written to buf before http.ReadRequest completes. The fencedBuffer is not required to make the test pass on any machine that I have access too, but as the buf is shared across goroutines, I think it is necessary for correc…
Mikio Hara
[release-branch.go1] net: delete unused socket-level option helpers ««« backport 66bdff5b0b29 net: delete unused socket-level option helpers R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6499043 »»»
Tobias Columbus
[release-branch.go1] misc/vim: fix for autocompletion ««« backport 7fb0e868dc39 misc/vim: fix for autocompletion Vim autocompletion respects the $GOPATH variable and does not ignore dashes ('-'), dots ('.') and underscores ('_') like found in many remote packages. Environment variable $GOROOT is determined by calling 'go env GOROOT' instead of relying on the user's environment variables. Fixes issue 3876 Fixes issue …
minux
[release-branch.go1] C: add Tobias Columbus's email used in Rietveld ««« backport a95c69098e45 C: add Tobias Columbus's email used in Rietveld R=golang-dev, tobias.columbus, bradfitz CC=golang-dev http://codereview.appspot.com/6483058 »»»
Andrew Gerrand
[release-branch.go1] net/http: send an explicit zero Content-Length when Handler never Writes
Julien Schmidt
[release-branch.go1] database/sql: stop reuse of bad connections ««« backport b397807815a6 database/sql: stop reuse of bad connections The second parameter for sql.putConn() (err) is always nil. As a result bad connections are reused, even if the driver returns an driver.ErrBadConn. Unsing a pointer to err instead achievs the desired behavior. See http://code.google.com/p/go/issues/detail?id=3777 for more details. Fixes issue 3777. R=golang-dev, dave, bradfit…
Brad Fitzpatrick
[release-branch.go1] A+C: Add Julien Schmidt (Individual CLA) ««« backport d80f2c4b0445 A+C: Add Julien Schmidt (Individual CLA) R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6459050 »»»
dsymonds
[release-branch.go1] A+C: Tobias Columbus (individual CLA) ««« backport 29671078c8aa A+C: Tobias Columbus (individual CLA) R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6480058 »»»
Adam Langley
[release-branch.go1] crypto/tls: return better error message in the case of an SSLv2 handshake. ««« backport 8048fe8f6f4b crypto/tls: return better error message in the case of an SSLv2 handshake. Update issue 3930 Return a better error message in this situation. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6474055 »»»
minux
[release-branch.go1] cmd/6g: fix float32/64->uint64 conversion ««« backport 5972fe3f4418 cmd/6g: fix float32/64->uint64 conversion CVTSS2SQ's rounding mode is controlled by the RC field of MXCSR; as we specifically need truncate semantic, we should use CVTTSS2SQ. Fixes issue 3804. R=rsc, r CC=golang-dev http://codereview.appspot.com/6352079 »»»
minux
[release-branch.go1] cmd/ld: set ELF header flags for our Linux/ARM binary ««« backport 1f9e023245d4 cmd/ld: set ELF header flags for our Linux/ARM binary To make it more compliant. This won't affect the behavior of running on OABI-only kernels. R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6475044 »»»
Rob Pike
[release-branch.go1] C+A: add Carlos Castillo cookieo9@gmail.com (individual CLA) ««« backport 341a5be3052f C+A: add Carlos Castillo cookieo9@gmail.com (individual CLA) R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6479045 »»»
Rob Pike
[release-branch.go1] time: avoid data race in abs ««« backport b2855a1654b6 time: avoid data race in abs Fixes issue 3967. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6460115 »»»
Dave Borowitz
[release-branch.go1] net/http: Set TLSClientConfig.ServerName on every HTTP request. ««« backport 8d39afcd18b1 net/http: Set TLSClientConfig.ServerName on every HTTP request. This makes SNI "just work" for callers using the standard http.Client. Since we now have a test that depends on the httptest.Server cert, change the cert to be a CA (keeping all other fields the same). R=bradfitz CC=agl, dsymonds, gobot, golang-dev http://codereview.appspot.com/6448154 Committer: Brad Fit…
Brad Fitzpatrick
[release-branch.go1] CONTRIBUTORS: Add Dave Borowitz (Google CLA) ««« backport 52a0395d0e81 CONTRIBUTORS: Add Dave Borowitz (Google CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6484046 »»»
Andrew Gerrand
[release-branch.go1] A+C: add Joakim Sernbrant ««« backport dd0a97869e4d A+C: add Joakim Sernbrant R=golang-dev, nigeltao CC=golang-dev http://codereview.appspot.com/6476043 »»»
Dave Cheney
[release-branch.go1] net/http: fix misplaced defer and example ««« backport 989f373141cc net/http: fix misplaced defer and example Moves the defer (again). Also, correct the example documentation to match. R=r, robert.hencke, iant, dsymonds, bradfitz CC=golang-dev http://codereview.appspot.com/6458158 »»»
Dave Cheney
[release-branch.go1] os: fix data race on Process.done ««« backport 4fc1c61c3c2c os: fix data race on Process.done Fixes issue 3969. R=dvyukov, r, alex.brainman, minux.ma CC=golang-dev http://codereview.appspot.com/6462081 »»»
minux
[release-branch.go1] doc/install: we only need command line tools for Xcode on OS X ««« backport 975bfb6bbac4 doc/install: we only need command line tools for Xcode on OS X Fixes issue 3973. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6464078 »»»
Volker Dobler
[release-branch.go1] strconv: consistent parameter names for ParseUint ««« backport 52813bdd69bb strconv: consistent parameter names for ParseUint If ParseUint is like ParseInt it should have the same parameter names, thus rename b to to base as in ParseInt's documentation. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6453152 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Dmitriy Vyukov
[release-branch.go1] net/http: reduce mutex contention ««« backport 43568ec5cf55 net/http: reduce mutex contention benchmark old ns/op new ns/op delta BenchmarkClientServerParallel 155909 154454 -0.93% BenchmarkClientServerParallel-2 86012 82986 -3.52% BenchmarkClientServerParallel-4 70211 55168 -21.43% BenchmarkClientServerParallel-8 80755 47862 -40.73% …
Alex Brainman
[release-branch.go1] pprof: make it work on windows again ««« backport 7c5f4dad8fae pprof: make it work on windows again - pprof is a perl script, so go command should invoke perl instead of trying to run pprof directly; - pprof should use "go tool nm" unconditionally on windows, no one else can extract symbols from Go program; - pprof should use "go tool nm" instead of "6nm". Fixes issue 3879. R=golang-dev, r CC=golang-dev http://codereview.appsp…
Rob Pike
[release-branch.go1] all: move defers to after error check to avoid nil indirection ««« backport 8f0c8f604ee0 all: move defers to after error check to avoid nil indirection Only affects some tests and none seem likely to be problematic, but let's fix them. Fixes issue 3971. R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6463060 »»»
Robert Griesemer
[release-branch.go1] go_spec: unary + and - are also defined for complex types ««« backport 1546a1ef0102 go_spec: unary + and - are also defined for complex types R=r, rsc, iant, ken, iant CC=golang-dev http://codereview.appspot.com/6450150 »»»
Alex Brainman
[release-branch.go1] test: change run.go to ignore \r in compiler output (fixes windows build) ««« backport b86e4ec1dd66 test: change run.go to ignore \r in compiler output (fixes windows build) R=golang-dev, dave, minux.ma, remyoudompheng CC=golang-dev http://codereview.appspot.com/6460093 »»»
Daniel Morsing
[release-branch.go1] cmd/gc: Don't claim type assertion would help when it wont. ««« backport b76339cc168a cmd/gc: Don't claim type assertion would help when it wont. Fixes issue 3465. R=golang-dev, rsc, remyoudompheng, iant CC=golang-dev http://codereview.appspot.com/6448097 Committer: Ian Lance Taylor <iant@golang.org> »»»
Ian Lance Taylor
[release-branch.go1] A+C: Andrew Lutomirski (individual CLA) ««« backport 8714f560df67 A+C: Andrew Lutomirski (individual CLA) Wrote code that was the basis for http://codereview.appspot.com/6454046/ R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6450142 »»»
Dmitriy Vyukov
[release-branch.go1] runtime/pprof: fix comments ««« backport e7e49c318134 runtime/pprof: fix comments R=golang-dev, iant CC=golang-dev http://codereview.appspot.com/6460082 »»»
Andrew Gerrand
[release-branch.go1] text/template/parse: fix bug handling /*/
minux
[release-branch.go1] runtime: use sched_getaffinity for runtime.NumCPU() on Linux ««« backport 3532ab6bf5be runtime: use sched_getaffinity for runtime.NumCPU() on Linux Fixes issue 3921. R=iant CC=golang-dev http://codereview.appspot.com/6448132 »»»
Rémy Oudompheng
[release-branch.go1] go/build: correct shouldBuild bug reading whole contents of file. ««« backport 307fafbc2d6f go/build: correct shouldBuild bug reading whole contents of file. It was caused by bytes.TrimSpace being able to return a nil slice. Fixes issue 3914. R=golang-dev, r CC=golang-dev, remy http://codereview.appspot.com/6458091 »»»
Robert Griesemer
[release-branch.go1] spec: clarify evaluation order ««« backport 6beada1bf6c2 spec: clarify evaluation order Fixes issue 3852. R=r, rsc, iant, ken CC=golang-dev http://codereview.appspot.com/6441102 »»»
Charles L. Dorian
[release-branch.go1] math: update definition of NaN in assembly language files ««« backport f26c1758e269 math: update definition of NaN in assembly language files R=rsc, minux.ma, golang-dev, nigeltao CC=golang-dev http://codereview.appspot.com/6461047 Committer: Nigel Tao <nigeltao@golang.org> »»»
Andrew Gerrand
[release-branch.go1] doc: add 'Get Started with Go' video, remove some older videos ««« backport 77b1cdceb2b2 doc: add 'Get Started with Go' video, remove some older videos (I also updated the wiki's GoTalks page with all the latest videos.) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6441113 »»»
Andrew Gerrand
[release-branch.go1] io: amend ReaderFrom doc as per r's comment ««« backport 5d3aaf0b717e io: amend ReaderFrom doc as per r's comment R=r CC=golang-dev http://codereview.appspot.com/6458097 »»»
Yves Junqueira
[release-branch.go1] crypto/rand: Example for Read. ««« backport 4738fd47e7a9 crypto/rand: Example for Read. R=adg, remyoudompheng, rsc, r CC=golang-dev http://codereview.appspot.com/6457085 Committer: Andrew Gerrand <adg@golang.org> »»»
Robert Griesemer
[release-branch.go1] godoc: make id attributes unique ««« backport b5dd89dce002 godoc: make id attributes unique Some browsers (e.g. IE9) ignore the case of 'id' attributes which can lead to conflicts. Prefix non-generated 'id's with "pkg-" to make them different from any generated attribute. Also: Added missing entry for "Other packages" to top-level index. Fixes issue 3851. R=adg, dsymonds CC=golang-dev http://codereview.appspot.com/6449105 »…
Nigel Tao
[release-branch.go1] image/jpeg: send a correct Start Of Scan (SOS) header. ««« backport 4a67b1f1e771 image/jpeg: send a correct Start Of Scan (SOS) header. Section B.2.3 of http://www.w3.org/Graphics/JPEG/itu-t81.pdf discusses the End of spectral selection (Se) byte. Apparently many JPEG decoders ignore the Se byte (or let it through with a warning), but some configurations reject them. For example, http://download.blender.org/source/chest/blender_2.03_tree/jpeg/jcmast…
Brad Fitzpatrick
[release-branch.go1] io: document ReaderFrom and WriterTo ««« backport 4e3a1967af09 io: document ReaderFrom and WriterTo Fixes issue 3711 R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6445083 »»»
Yves Junqueira
[release-branch.go1] text/template: fix range example. ««« backport c37d3a28f6b0 text/template: fix range example. R=r CC=adg, gobot, golang-dev http://codereview.appspot.com/6449096 Committer: Rob Pike <r@golang.org> »»»
minux
[release-branch.go1] doc: fix some HTML syntax errors ««« backport 4adee56240ac doc: fix some HTML syntax errors R=adg CC=golang-dev http://codereview.appspot.com/6458043 »»»
minux
[release-branch.go1] cmd/go: remove $WORK paths in generated binaries ««« backport c1ce95068533 cmd/go: remove $WORK paths in generated binaries Fixes issue 3748. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6357064 »»»
minux
[release-branch.go1] math, runtime: use a NaN that matches gcc's ««« backport 1f62df249175 math, runtime: use a NaN that matches gcc's our old choice is not working properly at least on VFPv2 in ARM1136JF-S (it's not preserved across float64->float32 conversions). Fixes issue 3745. R=dave, rsc CC=golang-dev http://codereview.appspot.com/6344078 »»»
minux
[release-branch.go1] runtime: remove unnecessary ROUND in alg.c ««« backport 4bd268b3c88a runtime: remove unnecessary ROUND in alg.c Introduced in CL 6452046. R=golang-dev, nigeltao, dave CC=golang-dev http://codereview.appspot.com/6459051 »»»
Andrew Gerrand
[release-branch.go1] syscall: fix plan9 build broken by CL 6458050
Brad Fitzpatrick
[release-branch.go1] net: fix TCPListener file leak to child processes ««« backport 75a21418ac8f net: fix TCPListener file leak to child processes Hold ForkLock during dup of fd + cloexec in the net pkg, per the locking policy documented in syscall/exec_unix.go. R=golang-dev, dsymonds, adg CC=golang-dev http://codereview.appspot.com/6457080 »»»
Andrew Gerrand
[release-branch.go1] syscall: return EINVAL when string arguments have NUL characters
Benny Siegert
[release-branch.go1] syscall: add some new syscall numbers from NetBSD-current ««« backport 98c1ecd82cb5 syscall: add some new syscall numbers from NetBSD-current R=golang-dev CC=golang-dev http://codereview.appspot.com/6454100 Committer: Russ Cox <rsc@golang.org> »»»
Russ Cox
[release-branch.go1] bufio: discourage use of ReadLine ««« backport 9e2011d9ed4b bufio: discourage use of ReadLine Too many people use it without reading what it does. Those people want ReadBytes or ReadString. Fixes issue 3906. R=golang-dev, iant, r CC=golang-dev http://codereview.appspot.com/6442087 »»»
Rémy Oudompheng
[release-branch.go1] cmd/8g: fix miscompilation due to BADWIDTH. ««« backport f6a6fe780649 cmd/8g: fix miscompilation due to BADWIDTH. Fixes issue 3899. R=rsc CC=golang-dev, remy http://codereview.appspot.com/6453084 »»»
Rémy Oudompheng
[release-branch.go1] cmd/gc: accept switches on comparable arrays. ««« backport d68605d10a6b cmd/gc: accept switches on comparable arrays. The compiler is incorrectly rejecting switches on arrays of comparable types. It also doesn't catch incomparable structs when typechecking the switch, leading to unreadable errors during typechecking of the generated code. Fixes issue 3894. R=rsc CC=gobot, golang-dev, r, remy http://codereview.appspot.com/6442074 »»»
Robert Griesemer
[release-branch.go1] go/build: tiny cleanup ««« backport 30dfc01b473c go/build: tiny cleanup R=rsc CC=golang-dev http://codereview.appspot.com/6453083 »»»
Alex Brainman
[release-branch.go1] os: test that IsExist and IsNotExist handle PathError and LinkError ««« backport 32eb6dac3ff4 os: test that IsExist and IsNotExist handle PathError and LinkError R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6442080 »»»
Robert Griesemer
[release-branch.go1] go/scanner: fix minor typo ««« backport c74762fb2e1d go/scanner: fix minor typo R=r CC=golang-dev http://codereview.appspot.com/6442076 »»»
Robert Griesemer
[release-branch.go1] go/ast: ast.Print must not crash with unexported fields ««« backport d134e30c4d29 go/ast: ast.Print must not crash with unexported fields Don't print unexported struct fields; their values are not accessible via reflection. Fixes issue 3898. Also: - added support for arrays - print empty maps, arrays, slices, structs on one line for a denser output - added respective test cases R=r CC=golang-dev http://codereview.appspot.com/6454089 »»»
minux
[release-branch.go1] runtime: round return value address in runtime.equal ««« backport a7752d169d2e runtime: round return value address in runtime.equal Fixes issue 3866. R=rsc, r, nigeltao CC=golang-dev http://codereview.appspot.com/6452046 »»»
Alex Brainman
[release-branch.go1] os: Rename error to fit IsExist ««« backport 104eb57df01b os: Rename error to fit IsExist Fixes issue 3828. R=golang-dev, iant, rsc CC=golang-dev http://codereview.appspot.com/6420056 »»»
Rémy Oudompheng
[release-branch.go1] cmd/gc: fix inlining bug with receive operator. ««« backport d872ed20fccb cmd/gc: fix inlining bug with receive operator. The receive operator was given incorrect precedence resulting in incorrect deletion of parentheses. Fixes issue 3843. R=rsc CC=golang-dev, remy http://codereview.appspot.com/6442049 »»»
minux
[release-branch.go1] cmd/cgo: use 1 as last entry for __cgodebug_data ««« backport aeaab9df5600 cmd/cgo: use 1 as last entry for __cgodebug_data LLVM-based gcc will place all-zero data in a zero-filled section, but our debug/macho can't handle that. Fixes issue 3821. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6444049 »»»
Rob Pike
[release-branch.go1] regexp: fix glitch in doc for FindReaderIndex ««« backport 6f790a92b3d2 regexp: fix glitch in doc for FindReaderIndex Fixes issue 3878. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6457054 »»»
Andrew Gerrand
[release-branch.go1] doc: remove mention of weekly tag from source install doc ««« backport 8c4b1b7ce761 doc: remove mention of weekly tag from source install doc R=golang-dev, dsymonds, bradfitz CC=golang-dev http://codereview.appspot.com/6442062 »»»
Russ Cox
[release-branch.go1] cmd/go: show $GOPATH in 'go env' output ««« backport d6d7de5aa8ed cmd/go: show $GOPATH in 'go env' output Also, sort output. R=golang-dev, patrick, dave, iant CC=golang-dev, patrick http://codereview.appspot.com/6446064 »»»
Brad Fitzpatrick
[release-branch.go1] net/http: don't allow zero byte in FileServer paths ««« backport 2307a931664e net/http: don't allow zero byte in FileServer paths Should probably be fixed in the syscall package, either additional or instead of this CL. Fixes issue 3842 R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6442061 »»»
Daniel Morsing
[release-branch.go1] cmd/gc: point "no new variables" error at right line number. ««« backport 98788e8973f2 cmd/gc: point "no new variables" error at right line number. Fixes issue 3856. R=dsymonds, rsc CC=golang-dev http://codereview.appspot.com/6455056 Committer: Russ Cox <rsc@golang.org> »»»
Russ Cox
[release-branch.go1] syscall: apply comment from Mikioh ««« backport d191515c80fb syscall: apply comment from Mikioh This comment was suggested in CL 6456045 but never got applied. R=mikioh, mikioh.mikioh CC=golang-dev http://codereview.appspot.com/6447056 »»»
Alexey Borzenkov
[release-branch.go1] syscall: workaround accept() bug on Darwin ««« backport 0eae95b0307a syscall: workaround accept() bug on Darwin Darwin kernels have a bug in accept() where error result from an internal call is not checked and socket is accepted instead of ECONNABORTED error. However, such sockets have no sockaddr, which results in EAFNOSUPPORT error from anyToSockaddr, making Go http servers running on Mac OS X easily susceptible to denial of service fro…
Benny Siegert
[release-branch.go1] runtime/cgo: fix netbsd build ««« backport 601878acd597 runtime/cgo: fix netbsd build Copy over freebsd.c to netbsd.c. Fixes issue 3823. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6398045 Committer: Russ Cox <rsc@golang.org> »»»
dsymonds
[release-branch.go1] misc/vim: fix :Import insertion heuristic. ««« backport 9bf2225c38eb misc/vim: fix :Import insertion heuristic. If a factored import group has a blank line, assume it is dividing separate groups of imports (e.g. standard library vs. site-specific). import ( "bytes" "io" "mycorp/package" ) The most common case is inserting new standard library imports, which are usually (sty…
Rob Pike
[release-branch.go1] flag: fix bug in handling of booleans on error ««« backport a36c0344826a flag: fix bug in handling of booleans on error Fixes issue 3869. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6448072 »»»
minux
[release-branch.go1] log/syslog: don't append \n if there is one ««« backport 6556a8d85dd6 log/syslog: don't append \n if there is one pkg log already appends a linefeed to the log message, so log/syslog doesn't need to append another. R=golang-dev, bradfitz, r CC=golang-dev http://codereview.appspot.com/6441048 »»»
Alex Brainman
[release-branch.go1] os: move epipecheck from file_posix.go and into file_unix.go to fix windows build ««« backport d127749038e8 os: move epipecheck from file_posix.go and into file_unix.go to fix windows build R=golang-dev CC=golang-dev http://codereview.appspot.com/6450058 »»»
Dmitriy Vyukov
[release-branch.go1] os: fix data race in epipecheck() ««« backport 8b3bf65c620c os: fix data race in epipecheck() Fixes issue 3860. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6443051 »»»
Ian Lance Taylor
[release-branch.go1] runtime: ignore signal 33 == SIGSETXID on GNU/Linux ««« backport bfa4e1f1027f runtime: ignore signal 33 == SIGSETXID on GNU/Linux When a cgo program calls setuid, setgid, etc., the GNU/Linux pthread library sends signal SIGSETXID to each thread to tell it to update its UID info. If Go is permitted to intercept the default SIGSETXID signal handler, the program will hang. This patch tells the runtime package to not try to intercept SIGSETXID on GN…
Robert Griesemer
[release-branch.go1] go/printer: don't crash if ast.FuncType.Params is nil ««« backport 7f6a0510d3c9 go/printer: don't crash if ast.FuncType.Params is nil The go/ast comment for FuncType.Params says that the field may be nil. Make sure the printer accepts such a value. The go/parser always sets the field (to provide parenthesis position information), but a program creating a Go AST from scatch may not. Added corresponding test case. Fixes issue 3870. R=golang-dev, r …
Robert Griesemer
[release-branch.go1] A+C: added Andrew Wilkins (individual contributor) ««« backport b22edea8aed4 A+C: added Andrew Wilkins (individual contributor) R=rsc, minux.ma, iant CC=golang-dev http://codereview.appspot.com/6447050 »»»
Ian Lance Taylor
[release-branch.go1] cgo: fix declarations in _cgo_export.c ««« backport 6751a0e1a6a4 cgo: fix declarations in _cgo_export.c Declare crosscall2. Declare the functions passed to it as returning void, rather than relying on implicit return type. R=golang-dev, minux.ma CC=golang-dev http://codereview.appspot.com/6432060 »»»
Brad Fitzpatrick
[release-branch.go1] testing: allow concurrent use of T and B ««« backport 7a67d277c7e8 testing: allow concurrent use of T and B Notably, allow concurrent logging and failing. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6453045 »»»
Mikio Hara
[release-branch.go1] net: fix comment ««« backport 5a0aafb7fd8d net: fix comment RemoteAddr returns not only UDPAddr but IPAddr. R=golang-dev, dave CC=golang-dev http://codereview.appspot.com/6401054 »»»
Rob Pike
[release-branch.go1] text/template: fix bug in map indexing ««« backport 0748cd92ed76 text/template: fix bug in map indexing If the key is not present, return value of the type of the element not the type of the key. Also fix a test that should have caught this case. Fixes issue 3850. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6405078 »»»
Rob Pike
[release-branch.go1] encoding/gob: revert 6348067, which broke compatibility ««« backport 3357d8d34ab8 encoding/gob: revert 6348067, which broke compatibility Add commentary to explain better what's going on, but the code change is a simple one-line reversal to the previous form. R=rsc CC=golang-dev http://codereview.appspot.com/6428072 »»»
Andrew Gerrand
[release-branch.go1] doc: add two I/O talks to "Talks" section ««« backport ddaabb722563 doc: add two I/O talks to "Talks" section R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6422056 »»»
Patrick Mylund Nielsen
[release-branch.go1] encoding/binary: fix typo: ReadVarint returns an int64, not a uint64. ««« backport 2f39e6389d55 encoding/binary: fix typo: ReadVarint returns an int64, not a uint64. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6432062 Committer: David Symonds <dsymonds@golang.org> »»»
Mikio Hara
[release-branch.go1] net: fix file descriptor leak on FileListener, FileConn and FilePacketConn ««« backport aee5a494a65c net: fix file descriptor leak on FileListener, FileConn and FilePacketConn R=golang-dev, dave, r CC=golang-dev http://codereview.appspot.com/6430062 »»»
Ian Lance Taylor
[release-branch.go1] cgo: add -gccgopkgpath option to match gccgo -fgo-pkgpath ««« backport 06e3a4c30dfb cgo: add -gccgopkgpath option to match gccgo -fgo-pkgpath R=golang-dev, r, iant CC=golang-dev http://codereview.appspot.com/6416056 »»»
Mikio Hara
[release-branch.go1] net: fix typo ««« backport 3019a3e15027 net: fix typo R=golang-dev, bsiegert, r CC=golang-dev http://codereview.appspot.com/6428050 »»»
Rob Pike
[release-branch.go1] sync: mention that WaitGroup.Add panics ««« backport 05f9fa32500a sync: mention that WaitGroup.Add panics Fixes issue 3839. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6428053 »»»
Rémy Oudompheng
[release-branch.go1] testing: fix memory blowup when formatting many lines. ««« backport 5e7fd762f356 testing: fix memory blowup when formatting many lines. Fixes issue 3830. R=golang-dev, r CC=golang-dev, remy http://codereview.appspot.com/6373047 »»»
Rob Pike
[release-branch.go1] faq: add status section ««« backport 2819b5a4f07d faq: add status section Fixes issue 3822. R=golang-dev, r, dsymonds, minux.ma, adg CC=golang-dev http://codereview.appspot.com/6395043 »»»
Adam Langley
[release-branch.go1] A+C: Peter Armitage (individual CLA) ««« backport 0423072b54f2 A+C: Peter Armitage (individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6392065 »»»
Nigel Tao
[release-branch.go1] compress/flate: fix panic when nlit is out of bounds. ««« backport ecd688de20fb compress/flate: fix panic when nlit is out of bounds. Fixes issue 3815. R=r CC=golang-dev http://codereview.appspot.com/6352109 »»»
Benny Siegert
[release-branch.go1] os: add missing full stop in comment ««« backport c61c67c7b924 os: add missing full stop in comment R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6399047 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Rémy Oudompheng
[release-branch.go1] cmd/gc: reject use of ... with multiple-valued expressions. ««« backport 6d5faedd95bc cmd/gc: reject use of ... with multiple-valued expressions. Fixes issue 3334. R=golang-dev, r CC=golang-dev, remy http://codereview.appspot.com/6350103 »»»
Rémy Oudompheng
[release-branch.go1] cmd/gc: avoid an internal error on invalid type switch. ««« backport 254232c99b3e cmd/gc: avoid an internal error on invalid type switch. The error was caused by a call to implements() even when the type switch variable was not an interface. Fixes issue 3786. R=golang-dev, r CC=golang-dev, remy http://codereview.appspot.com/6354102 »»»
Rémy Oudompheng
[release-branch.go1] cmd/gc: fix error message for type errors involving conversions. ««« backport a281d4bd1ba6 cmd/gc: fix error message for type errors involving conversions. Fixes issue 3818. R=golang-dev, rsc, r CC=golang-dev, remy http://codereview.appspot.com/6352106 »»»
Andrew Gerrand
[release-branch.go1] encoding/gob: fix check for short input in slice decode
Rémy Oudompheng
[release-branch.go1] spec: correct typo in string conversion examples. ««« backport 65de4b905541 spec: correct typo in string conversion examples. R=golang-dev, dave, r CC=golang-dev, remy http://codereview.appspot.com/6378046 »»»
Adam Langley
[release-branch.go1] crypto/rsa: left-pad PKCS#1 v1.5 outputs. ««« backport 46ca86e70e96 crypto/rsa: left-pad PKCS#1 v1.5 outputs. OpenSSL requires that RSA signatures be exactly the same byte-length as the modulus. Currently it'll reject ~1/256 of our signatures: those that end up a byte shorter. Fixes issue 3796. R=golang-dev, edsrzf, r CC=golang-dev http://codereview.appspot.com/6352093 »»»
Dave Cheney
[release-branch.go1] website: various html fixes ««« backport 744f0397f41a website: various html fixes Fixes issue 3424. R=fullung, adg CC=golang-dev http://codereview.appspot.com/6343088 Committer: Andrew Gerrand <adg@golang.org> »»»
Adam Langley
[release-branch.go1] crypto/x509: exempt broken Entrust certificate from checks. ««« backport 8241ffc8686e crypto/x509: exempt broken Entrust certificate from checks. Entrust have issued a root certificate that's not marked as valid for signing certificates. This results in Go programs failing to validate certificates that chain up to this root (i.e. gateway.push.apple.com:2195). Although this is clearly a mistake on Entrust's part, it seems that we will have to bodge aroun…
David G. Andersen
[release-branch.go1] pkg: Removing duplicated words ("of of", etc.), mostly from comments. ««« backport ce3a981ad1ef pkg: Removing duplicated words ("of of", etc.), mostly from comments. Ran 'double.pl' on the pkg tree to identify doubled words. One change to an error string return in x509; the rest are in comments. Thanks to Matt Jibson for the idea. R=golang-dev, bsiegert CC=golang-dev http://codereview.appspot.com/6344089 Committer: Nigel Tao <nigeltao@golang.org> »»»
Matt Jibson
[release-branch.go1] A+C: correct Matt Jibson ««« backport 63dae3ba6a6d A+C: correct Matt Jibson R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6344088 Committer: David Symonds <dsymonds@golang.org> »»»
Matt Jibson
[release-branch.go1] doc: various "the the" and other typos ««« backport 74c5c02910de doc: various "the the" and other typos R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6355076 Committer: David Symonds <dsymonds@golang.org> »»»
dsymonds
[release-branch.go1] A+C: Matthew Jibson (individual CLA). ««« backport 9349fc3302f5 A+C: Matthew Jibson (individual CLA). R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/6349082 »»»
minux
[release-branch.go1] misc/chrome/gophertool: fix manifest ««« backport 100ddb84c85d misc/chrome/gophertool: fix manifest according to http://code.google.com/chrome/extensions/browserAction.html, it should use "default_popup" instead of "popup". R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6349077 »»»
Robert Griesemer
[release-branch.go1] reflect: reflect.Zero results are neither addressable nor settable ««« backport 21130d62eeb0 reflect: reflect.Zero results are neither addressable nor settable This could be deduced from "The Laws of Reflection" but it seems worthwhile highlighting it. R=r CC=golang-dev http://codereview.appspot.com/6350073 »»»
Rob Pike
[release-branch.go1] encoding/gob: fix bug in Register ««« backport c89f17a9ff4f encoding/gob: fix bug in Register The old code added a star but did not indirect the reflect.Type. R=bradfitz CC=golang-dev http://codereview.appspot.com/6348067 »»»
minux
[release-branch.go1] doc/debugging_with_gdb: mention how to disable gc optimization ««« backport be7e338a8960 doc/debugging_with_gdb: mention how to disable gc optimization R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6353055 »»»
David G. Andersen
[release-branch.go1] math/big: Remove unnecessary test from nat.go multiplication ««« backport c533f48701cb math/big: Remove unnecessary test from nat.go multiplication The switch at the beginning of the function already ensures n > 1, so testing for n < 2 is redundant. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/6350051 Committer: Robert Griesemer <gri@golang.org> »»»
minux
[release-branch.go1] image: fix doc typo ««« backport 042bac4d6b6e image: fix doc typo Fixes issue 3789. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6357058 »»»
minux
[release-branch.go1] cmd/gc: add missing case for OCOM in defaultlit() ««« backport b5c4f411a852 cmd/gc: add missing case for OCOM in defaultlit() Fixes issue 3765. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6349064 »»»
Amir Mohammad Saeid
[release-branch.go1] cmd/go: httpGet function does not use global variable httpClient ««« backport 650544a058e9 cmd/go: httpGet function does not use global variable httpClient No change, just for consistency. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6346048 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Brad Fitzpatrick
[release-branch.go1] net/http: ignore malicious or dumb Range requests ««« backport d32138d8d05f net/http: ignore malicious or dumb Range requests R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6356050 »»»
Pieter Droogendijk
[release-branch.go1] cmd/dist: Make windows.c's fatal() print to stderr ««« backport 3f7501fdb220 cmd/dist: Make windows.c's fatal() print to stderr Generating env.bat using dist env -wp > env.bat failed silently if case of an error, because the message was redirected to env.bat. Verbose messages still go to stdout, causing problems, but that's a seperate change. Made errprintf() identical to xprintf(), except for the output handle. Yes, it's duplicate code, but most…
Jean-Marc Eurin
[release-branch.go1] misc/emacs: Fix the gofmt patching when the TMPDIR is not the default. ««« backport c5f564efc620 misc/emacs: Fix the gofmt patching when the TMPDIR is not the default. The previous code assumed the gofmt output referred to /tmp but that's not true if TMPDIR points somewhere else (like on Macs). Fixes issue 3782. R=sameer CC=golang-dev http://codereview.appspot.com/6346050 Committer: Sameer Ajmani <sameer@golang.org> »»»
Brad Fitzpatrick
[release-branch.go1] net/http: support multiple byte ranges in ServeContent ««« backport 070604630d24 net/http: support multiple byte ranges in ServeContent Fixes issue 3784 R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6351052 »»»
Andrey Mirtchovski
[release-branch.go1] net/http: Fix a verb-tense mismatch and a typo in documentation. ««« backport f8a77e2b7d0b net/http: Fix a verb-tense mismatch and a typo in documentation. R=bradfitz CC=golang-dev http://codereview.appspot.com/6357049 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Robert Griesemer
[release-branch.go1] go spec: clean up section on selectors ««« backport eb24cee7f21b go spec: clean up section on selectors - point out difference between selectors and qualified identifiers - differentiate between illegal selectors and run-time panics - use "indirect" as opposed to "dereference" consistently - add extra links Fixes issue 3779. R=r, rsc, iant, ken CC=golang-dev http://codereview.appspot.com/6326059 »»»
Joseph Poirier
[release-branch.go1] syscall: add missing argument type ««« backport 3909e0071e70 syscall: add missing argument type And update implementation location comment. R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/6352046 »»»
Robert Griesemer
[release-branch.go1] go spec: clean up use of QualifiedIdent production. ««« backport d8bd45866999 go spec: clean up use of QualifiedIdent production. Fixes issue 3763. R=r, rsc, iant, ken CC=golang-dev http://codereview.appspot.com/6333066 »»»
Russ Cox
[release-branch.go1] A+C: L Campbell (individual CLA) ««« backport c88692a626e9 A+C: L Campbell (individual CLA) Guess I was wrong about being done for the day. R=golang-dev, r CC=golang-dev, unpantsu http://codereview.appspot.com/6325060 »»»
Rob Pike
[release-branch.go1] fmt: set p.field before nil check ««« backport 5f13e0662e38 fmt: set p.field before nil check Fixes issue 3752. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6331062 »»»
Andrew Gerrand
[release-branch.go1] doc: drop video title from homepage ««« backport 9da3902443ca doc: drop video title from homepage It's just stutter. R=golang-dev, dsymonds, r CC=golang-dev http://codereview.appspot.com/6334053 »»»
Russ Cox
[release-branch.go1] A+C: Jonathan Gold (individual CLA) ««« backport ee62927ec779 A+C: Jonathan Gold (individual CLA) This is my last one for today, I hope! R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6339052 »»»
Russ Cox
[release-branch.go1] A+C: add Michael Stapelberg (individual CLA) ««« backport 04f61caa80cd A+C: add Michael Stapelberg (individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6325058 »»»
Pieter Droogendijk
[release-branch.go1] go/build: fix doc typo ««« backport e12419d09635 go/build: fix doc typo go/build section "Build Constraints", first paragraph said: "... they must be appear near the top of the file ..." fixed to: "... they must appear near the top of the file ..." R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6329060 Committer: Russ Cox <rsc@golang.org> »»»
Amir Mohammad Saeid
[release-branch.go1] misc/chrome/gophertool: Support for manifest version 1 is being phased out. ««« backport 0f017230e6b4 misc/chrome/gophertool: Support for manifest version 1 is being phased out. Manifest version 1 was deprecated in Chrome 18, and support will be phased out according to the schedule available at: http://code.google.com/chrome/extensions/manifestVersion.html R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6332053 Committer: Russ Cox <rsc@golang.org> »»»
Russ Cox
[release-branch.go1] A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA) ««« backport 565770878659 A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6330059 »»»
Robert Griesemer
[release-branch.go1] spec: clarify receive operator ««« backport c72ac7873261 spec: clarify receive operator - receiving from a closed channel returns immediately - in the ,ok form, the 2nd result is of type bool, not just boolean (gc and ggcgo agree). Per dsymonds' suggestion. R=r, rsc, ken, iant, dsymonds CC=golang-dev http://codereview.appspot.com/6333057 »»»
Russ Cox
[release-branch.go1] runtime: detect hash map collision problems ««« backport f99b9475b914 runtime: detect hash map collision problems This can only happen if the hash function we're using is getting far more than it's fair share of collisions, but that has happened to us repeatedly as we've expanded the allowed use cases for hash tables (issue 1544, issue 2609, issue 2630, issue 2883, issue 3695). Maybe this will help the next time we try something new. R=go…
Han-Wen Nienhuys
[release-branch.go1] os: make POSIX StartProcess work with chroot again. ««« backport 2aaa88600d48 os: make POSIX StartProcess work with chroot again. Skip directory check in startProcess in the presence of SysProcAttr. Fixes issue 3649. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6297083 Committer: Russ Cox <rsc@golang.org> »»»
Russ Cox
[release-branch.go1] CONTRIBUTORS: add Han-Wen Nienhuys (Google CLA) ««« backport d4b91c10aa5e CONTRIBUTORS: add Han-Wen Nienhuys (Google CLA) R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6327054 »»»
Dave Cheney
[release-branch.go1] runtime: avoid r9/r10 during memmove ««« backport 5ca8acc84025 runtime: avoid r9/r10 during memmove Fixes issue 3718. Requires CL 6300043. R=rsc, minux.ma, extraterrestrial.neighbour CC=golang-dev http://codereview.appspot.com/6305100 »»»
Dave Cheney
[release-branch.go1] runtime: avoid r9/r10 during memset ««« backport 572efb136b1a runtime: avoid r9/r10 during memset Partially fixes issue 3718. R=golang-dev, rsc, minux.ma CC=golang-dev http://codereview.appspot.com/6300043 »»»
dsymonds
[release-branch.go1] flag: fix indexing doc. ««« backport 6ca4825bc867 flag: fix indexing doc. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6341046 »»»
Brad Fitzpatrick
[release-branch.go1] net/http: fix doc inaccuracy and typo; tighten test ««« backport 60041e23de38 net/http: fix doc inaccuracy and typo; tighten test Note url.Error wrapping, and s/issue/issuing/. Fixes issue 3724 R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6294093 »»»
minux
[release-branch.go1] runtime: fix struct Sigaction for Linux/386 ««« backport 645947213cac runtime: fix struct Sigaction for Linux/386 We need to use kernel headers to generate defs_linux_$GOARCH.h R=golang-dev, dave, alex.brainman, iant CC=golang-dev http://codereview.appspot.com/6296091 »»»
David G. Andersen
[release-branch.go1] net/rpc: fix typo in documentation, clarify semantics of error return ««« backport ef713d7587f2 net/rpc: fix typo in documentation, clarify semantics of error return Several of my students were confused by trying to use both the error return and a reply return, so I figured it was worth explicitly clarifying that returning an error overrides the reply. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6327051 Committer: Rob Pike <r@golang.org> »»»
David G. Andersen
[release-branch.go1] encoding/json: fix minor typo in documentation for Marshal ««« backport 093dcfc4d307 encoding/json: fix minor typo in documentation for Marshal R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6325053 Committer: Rob Pike <r@golang.org> »»»
Andrew Gerrand
[release-branch.go1] doc: put A Tour of Go video on the front page ««« backport a95bedca6dae doc: put A Tour of Go video on the front page R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6337047 »»»
Mats Lidell
[release-branch.go1] misc/emacs: Replace replace-{string|regexp} for XEmacs compatible code ««« backport d730d2e4733d misc/emacs: Replace replace-{string|regexp} for XEmacs compatible code Use code to be used in lisp programs as suggested in the doc strings for replace-{string|regexp}. Bonus: This code works for XEmacs. R=golang-dev, sameer, jmeurin CC=golang-dev http://codereview.appspot.com/6296073 Committer: Sameer Ajmani <sameer@golang.org> »»»
minux
[release-branch.go1] doc/articles/slices_usage_and_internals: fix typo ««« backport 5b56c2c0597f doc/articles/slices_usage_and_internals: fix typo Fixes issue 3753. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6304097 »»»
minux
[release-branch.go1] runtime: fix struct Sigaction for Linux/ARM ««« backport 6eefce99091e runtime: fix struct Sigaction for Linux/ARM if we were to use sizeof(sa.sa_mask) instead of 8 as the last argument to rt_sigaction, we would have already fixed this bug, so also updated Linux/386 and Linux/amd64 files to use that; also test the return value of rt_sigaction. R=dave, rsc CC=golang-dev http://codereview.appspot.com/6297087 …
Brad Fitzpatrick
[release-branch.go1] net/http: clarify client return values in docs ««« backport f7839a55036e net/http: clarify client return values in docs Also, fixes one violation found during testing where both response and error could be non-nil when a CheckRedirect test failed. This is arguably a minor API (behavior, not signature) change, but it wasn't documented either way and was inconsistent & non-Go like. Any code depending on the old behavior was wrong anyway. R=a…
Robert Griesemer
[release-branch.go1] go/ast: multiple "blank" imports are permitted ««« backport 2033e1b11a20 go/ast: multiple "blank" imports are permitted R=rsc, dsymonds CC=golang-dev http://codereview.appspot.com/6303099 »»»
Marcel van Lohuizen
[release-branch.go1] bytes: fixed typo. ««« backport a3c2d3c41c45 bytes: fixed typo. R=r CC=golang-dev http://codereview.appspot.com/6301096 »»»
Adam Langley
[release-branch.go1] A+C: Christine Hansmann (individual CLA) ««« backport 4086a221c497 A+C: Christine Hansmann (individual CLA) R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6312045 »»»
Robert Griesemer
[release-branch.go1] go/ast: Walk: do not walk comment list ««« backport 5e3661048f2e go/ast: Walk: do not walk comment list A comment to that effect was introduced with rev d332f4b9cef5 but the respective code wasn't deleted. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6304086 »»»
minux
[release-branch.go1] doc: delete Mercurial Queues doc ««« backport 47e7c99fbe87 doc: delete Mercurial Queues doc Fixes issue 3716. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6310044 »»»
minux
[release-branch.go1] crypto/elliptic: fix doc typo ««« backport 9f9c0363f0ed crypto/elliptic: fix doc typo Fixes issue 3735. R=golang-dev, agl CC=golang-dev http://codereview.appspot.com/6301083 »»»
Brad Fitzpatrick
[release-branch.go1] net/http: use index.html modtime (not directory) for If-Modified-Since ««« backport c536f328c34b net/http: use index.html modtime (not directory) for If-Modified-Since Thanks to Håvid Falch for finding the problem. Fixes issue 3414 R=r, rsc CC=golang-dev http://codereview.appspot.com/6300081 »»»
Russ Cox
[release-branch.go1] runtime: replace runtime·rnd function with ROUND macro ««« backport 722bb90ae3ee runtime: replace runtime·rnd function with ROUND macro It's sad to introduce a new macro, but rnd shows up consistently in profiles, and the function call overwhelms the two arithmetic instructions it performs. R=r CC=golang-dev http://codereview.appspot.com/6260051 »»»
Brad Fitzpatrick
[release-branch.go1] net/http: fix response Connection: close, close client connections ««« backport 4c333000f50b net/http: fix response Connection: close, close client connections Fixes issue 3663 Updates issue 3540 (fixes it more) Updates issue 1967 (fixes it more, re-enables a test) R=golang-dev, n13m3y3r CC=golang-dev http://codereview.appspot.com/6213064 »»»
Brad Fitzpatrick
[release-branch.go1] net/http: fix regression and mute known test failure for now ««« backport c3cbd6798cc7 net/http: fix regression and mute known test failure for now Two tests added in 820ffde8c are expected to fail until the fix for Issue 3540 goes back in (pending Windows net fixes), so make those tests just Logf for now, with a TODO to re-enable. Add a new client test. Rearrange the transport code to be more readable, and fix the bug from 820ffde8c where the persistCon…
james4k
[release-branch.go1] net/http: non-keepalive connections close successfully ««« backport 820ffde8c396 net/http: non-keepalive connections close successfully Connections did not close if Request.Close or Response.Close was true. This meant that if the user wanted the connection to close, or if the server requested it via "Connection: close", the connection would not be closed. Fixes issue 1967. R=golang-dev, rsc, bradfitz CC=golang-dev http://codereview.appspot.com/6201…
Brad Fitzpatrick
[release-branch.go1] net/http: ignore paths on CONNECT requests in ServeMux ««« backport 8eae6e390d20 net/http: ignore paths on CONNECT requests in ServeMux Fixes issue 3538 R=golang-dev, adg, rsc CC=golang-dev http://codereview.appspot.com/6117058 »»»
Anthony Martin
[release-branch.go1] os: avoid panic when testing errors on Plan 9 ««« backport 99b8351bfb9e os: avoid panic when testing errors on Plan 9 R=golang-dev, bradfitz, akumar CC=golang-dev http://codereview.appspot.com/6017043 »»»
minux
[release-branch.go1] 5c, 6c, 8c: take GOROOT_FINAL into consideration ««« backport 016c4fefed77 5c, 6c, 8c: take GOROOT_FINAL into consideration R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5936050 »»»
minux
[release-branch.go1] 5a, 6a, 8a: take GOROOT_FINAL into consideration ««« backport a608a03df703 5a, 6a, 8a: take GOROOT_FINAL into consideration R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5940052 »»»
Andrew Gerrand
[release-branch.go1] syscall: fix windows build ««« CL 6303061 / 17432a753e50 syscall: fix windows build TBR=bradfitz CC=golang-dev http://codereview.appspot.com/6303061 »»» R=golang-dev CC=golang-dev http://codereview.appspot.com/6295080
Russ Cox
[release-branch.go1] syscall: fix GetCurrentProcessId symbol name on Windows
Andrew Gerrand
[release-branch.go1] doc: document go1.0.2 ««« CL 6298079 / a19665fe6f33 doc: document go1.0.2 R=golang-dev, dave, rsc CC=golang-dev http://codereview.appspot.com/6298079 »»» R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6302076
Russ Cox
[release-branch.go1] update VERSION to go1.0.2
Russ Cox
[release-branch.go1] syscall: unexport GetCurrentProcessId on Windows
atom-symbol
[release-branch.go1] runtime: improved continuity in hash computation ««« backport c8d163b7930e runtime: improved continuity in hash computation Fixes issue 3695. R=r, dave, rsc CC=golang-dev http://codereview.appspot.com/6304062 Committer: Russ Cox <rsc@golang.org> »»»
Jean-Marc Eurin
[release-branch.go1] misc/emacs: Fix a failure when /tmp/<file>.go exists. ««« backport 903a3cdd92cf misc/emacs: Fix a failure when /tmp/<file>.go exists. R=sameer CC=golang-dev http://codereview.appspot.com/6296060 Committer: Sameer Ajmani <sameer@golang.org> »»»
Jean-Marc Eurin
[release-branch.go1] misc/emacs: Fix the automatic gofmt when creating a new file. ««« backport 5b4920fe3605 misc/emacs: Fix the automatic gofmt when creating a new file. Patching the buffer with the output from gofmt -d only works if the file already exists. If it doesn't, replace the content with the output of gofmt. R=sameer CC=golang-dev http://codereview.appspot.com/6302063 Committer: Sameer Ajmani <sameer@golang.org> »»»
Brad Fitzpatrick
[release-branch.go1] encoding/gob: fix doc typo ««« backport d34766b79c5e encoding/gob: fix doc typo R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6300078 »»»
Russ Cox
[release-branch.go1] syscall: revert API changes in Windows Win32finddata fix. ««« backport 7a7a91c3da32 syscall: revert API changes in Windows Win32finddata fix. Preserve old API by using correct struct in system call and then copying the results, as we did for SetsockoptLinger. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6307065 »»»
Russ Cox
[release-branch.go1] cmd/api: handle empty API file, ignore -next in release ««« backport 8e7ad2db0833 cmd/api: handle empty API file, ignore -next in release R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6298063 »»»
Russ Cox
[release-branch.go1] regexp/syntax: unexport ErrUnexpectedParen ««« backport b4cdcec897fb regexp/syntax: unexport ErrUnexpectedParen This new error is the only API change in the current draft of Go 1.0.2 CLs. I'd like to include the CL that introduced it, because it replaces a mysterious 'internal error' with a useful error message, but I don't want any API changes, so unexport the error constant for now. It can be re-exported for Go 1.1. R=golang-dev, r CC=…
Dave Cheney
[release-branch.go1] cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin ««« backport 432f2b7f5458 cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin Fixes issue 3708. The fix to allow 5{c,g,l} to compile under clang 3.1 broke cross compilation on darwin using the Apple default compiler on 10.7.3. This failure was introduced in 9b455eb64690. This has been tested by cross compiling on darwin/amd64 to linux/arm using * gcc version 4.2.1 (Based on Apple …
Russ Cox
[release-branch.go1] cmd/cgo: make Go code order deterministic ««« backport 319a9f3330d0 cmd/cgo: make Go code order deterministic The type declarations were being generated using a range over a map, which meant that successive runs produced different orders. This will make sure successive runs produce the same files. Fixes issue 3707. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6300062 »»»
Russ Cox
[release-branch.go1] cmd/gc: limit data disassembly to -SS ««« backport 14ce24bcd818 cmd/gc: limit data disassembly to -SS This makes -S useful again. R=ken2 CC=golang-dev http://codereview.appspot.com/6302054 »»»
Russ Cox
[release-branch.go1] cmd/gc: fix LEAQ $0, SI bug ««« backport c4a344d25b87 cmd/gc: fix LEAQ $0, SI bug Cannot take effective address of constant. Fixes issue 3670. R=ken2 CC=golang-dev http://codereview.appspot.com/6299055 »»»
Russ Cox
[release-branch.go1] cmd/gc: fix type checking loop ««« backport e69400ace361 cmd/gc: fix type checking loop CL 4313064 fixed its test case but did not address a general enough problem: type T1 struct { F *T2 } type T2 T1 type T3 T2 could still end up copying the definition of T1 for T2 before T1 was done being evaluated, or T3 before T2 was done. In order to propagate the updates correctly, record a copy of an incomplete type for re-execution …
Russ Cox
[release-branch.go1] cmd/gc: delete dead code ««« backport 721d528a4e91 cmd/gc: delete dead code R=ken2 CC=golang-dev http://codereview.appspot.com/6307050 »»»
Russ Cox
[release-branch.go1] cmd/gc: do not crash on struct with _ field ««« backport af07f1cd12dc cmd/gc: do not crash on struct with _ field Fixes issue 3607. R=ken2 CC=golang-dev http://codereview.appspot.com/6296052 »»»
Russ Cox
[release-branch.go1] cmd/gc: preserve side effects during inlining of function with _ argument ««« backport 0ba8e27c7b87 cmd/gc: preserve side effects during inlining of function with _ argument Fixes issue 3593. R=ken2 CC=golang-dev, lvd http://codereview.appspot.com/6305061 »»»
Russ Cox
[release-branch.go1] encoding/json: fix panic unmarshaling into non-nil interface value ««« backport bee83c1509a3 encoding/json: fix panic unmarshaling into non-nil interface value Fixes issue 3614. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6306051 »»»
Russ Cox
[release-branch.go1] cmd/gc: mark output of typename as type-checked ««« backport d39a44280dd3 cmd/gc: mark output of typename as type-checked R=ken2 CC=golang-dev http://codereview.appspot.com/6302051 »»»
Daniel Morsing
[release-branch.go1] fmt: fix doc typo ««« backport 76f136192aac fmt: fix doc typo R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6308046 Committer: Russ Cox <rsc@golang.org> »»»
Russ Cox
[release-branch.go1] A+C: Daniel Morsing (individual CLA) ««« backport a47632179cb7 A+C: Daniel Morsing (individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6307048 »»»
Russ Cox
[release-branch.go1] A+C: Markus Sonderegger (individual CLA) ««« backport a6e2b17a16d7 A+C: Markus Sonderegger (individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6303047 »»»
156 commits not shown.