v5/v6 Examine Without Place to Examine

Enthalpy reporter

After thinking about it, I decided it would be a good idea to have the "go to the default automatically if the image can't be loaded" behavior be standard, and not just good for the special case if having no place selected in an investigation examine conversation. Making this a general feature makes the code easier to maintain, will make missing images easier to ignore when they don't block progress, and makes the problems just as obvious when the missing image breaks the game. I see no downsides to this.

As such, this commit will have two main parts. One will implement the behavior outline above, and the other will create a new action to head back to the main dialogue and regulate its use in examine conversations. These parts are non-separable, as the first part alone changes the bug's behavior without remedying it, and the second part alone is useless. If you have an alternative suggestion or problems with my proposal, please let me know quickly, as I hope to have a pull request up for this over the weekend.

2016-10-13T15:14:22+00:00

Comments (3)

Enthalpy reporter
- assigned issue to
  
  Enthalpy
- 2016-09-25T18:15:35+00:00
Enthalpy reporter
After thinking about it, I decided it would be a good idea to have the "go to the default automatically if the image can't be loaded" behavior be standard, and not just good for the special case if having no place selected in an investigation examine conversation. Making this a general feature makes the code easier to maintain, will make missing images easier to ignore when they don't block progress, and makes the problems just as obvious when the missing image breaks the game. I see no downsides to this.

As such, this commit will have two main parts. One will implement the behavior outline above, and the other will create a new action to head back to the main dialogue and regulate its use in examine conversations. These parts are non-separable, as the first part alone changes the bug's behavior without remedying it, and the second part alone is useless. If you have an alternative suggestion or problems with my proposal, please let me know quickly, as I hope to have a pull request up for this over the weekend.
- 2016-10-13T15:14:22+00:00
Enthalpy reporter
- changed status to invalid
After further attempts, I can't reproduce my report of "hanging" the editor. What you get instead is examining a black screen. While I can imagine improvements, they're rather complicated, and after discussion with Unas and Pasch, too complicated to be worthwhile.
- 2019-09-01T17:32:01+00:00
Log in to comment