Michael Manfre avatar Michael Manfre committed bf647d1

Fix Bug 64: BigForeignKey to allow having a foreign key to a model using BigAutoField.

Comments (0)

Files changed (2)

source/sqlserver_ado/fields.py

 """This module provides SQL Server specific fields for Django models."""
-from django.db.models import IntegerField, AutoField
+from django.db.models import AutoField, ForeignKey, IntegerField
+
+class BigAutoField(AutoField):
+    """A bigint IDENTITY field"""
+    def get_internal_type(self):
+        return "BigAutoField"
+
+    def to_python(self, value):
+        if value is None:
+            return value
+        try:
+            return long(value)
+        except (TypeError, ValueError):
+            raise exceptions.ValidationError(
+                _("This value must be an long."))
+
+    def get_db_prep_value(self, value):
+        if value is None:
+            return None
+        return long(value)
+
+class BigForeignKey(ForeignKey):
+    """A ForeignKey field that points to a BigAutoField or BigIntegerField"""
+    def db_type(self):
+        return BigIntegerField().db_type()
 
 class BigIntegerField(IntegerField):
     """A BigInteger field, until Django ticket #399 lands (if ever.)"""
         if value is None:
             return None
         return long(value)
-
-class BigAutoField(AutoField):
-    """A bigint IDENTITY field"""
-    def get_internal_type(self):
-        return "BigAutoField"
-
-    def to_python(self, value):
-        if value is None:
-            return value
-        try:
-            return long(value)
-        except (TypeError, ValueError):
-            raise exceptions.ValidationError(
-                _("This value must be an long."))
-
-    def get_db_prep_value(self, value):
-        if value is None:
-            return None
-        return long(value)

tests/test_main/regressiontests/models.py

 from django.db import models, IntegrityError
 from django.test import TestCase
 from django.core.paginator import Paginator
-from sqlserver_ado.fields import BigAutoField, BigIntegerField
+from sqlserver_ado.fields import BigAutoField, BigIntegerField, BigForeignKey
 
 class Bug19Table(models.Model):
     """ A simple model for testing string comparisons.
     """
     id = BigAutoField(primary_key=True)
     number = BigIntegerField()
+
+class Bug64Table(models.Model):
+    """
+    Test that a BigForeignKey works as intended.
+    
+    >>> a = Bug63Table(number=2147483648L)
+    >>> a.save()
+    >>> b = Bug64Table(key=a)
+    >>> b.save()
+    >>> a == b.key
+    True
+    >>> b.key.number == 2147483648L
+    True
+    """
+    
+    key = BigForeignKey(Bug63Table)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.