Commits

Anonymous committed c4fbb68

Quickfix: moved removeItem ahead of all return points to avoid eternal loop

Comments (0)

Files changed (1)

src/scxml/ScXMLEventTarget.cpp

 void
 ScXMLEventTarget::unregisterEventTarget(ScXMLEventTarget * target, const char * sessionid)
 {
+  // FIXME This was done at the end of the function, but we have multiple exit points so target was sometimes
+  // not removed causing an endless loop.
+  ScXMLEventTarget::PImpl::targets.removeItem(target);
+
   const SbName targettypename(target->getEventTargetType());
   const SbName targetnamename(target->getEventTargetName());
   SbName targetsessionid(SbName::empty());
     ScXMLP::unlock();
     return;
   }
-
-  ScXMLEventTarget::PImpl::targets.removeItem(target);
   ScXMLP::unlock();
 }
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.