misspelled test flag in configure

Create issue
Issue #47 resolved
Johnathan Conley created an issue

in configure: 25284: CPPFLAGS="$CPPFLAGS -fno-for-scoping" should be CPPFLAGS="$CPPFLAGS -fno-for-scope"

this flag is unsupported on osx maverics with clang, however the test does not detect this b/c of the misspelling.

This is also the cause for an initial workaround mentioned as part of issue #45 (but not the core issue there)

Comments (12)

  1. Roy Walmsley

    Hi Johnathan,

    I think I agree with you on this, having looked at gcc options but I am unable to test this at the moment. If you and someone else can confirm this then I will make the change.


  2. Thomas Moeller

    I don't use gcc either but tried changing "-fno-for-scoping" to "-fno-for-scope" in configure to make sure the script doesn't break for OS X. The configure script recognizes correctly (also after making the change) that clang doesn't support either option. Because the gcc documentation clearly states the flag is spelled -fno-for-scope and no side effects could be observed for other platforms I support renaming the option in the configure script.

  3. Roy Walmsley

    I now believe that the correct solution should be to remove this flag completely, forcing all code to conform to the C++ standard. I would appreciate your comments.

    Note I have also raised this as a discussion point on in the Google group coin-discuss.

    For everyone's information, the build failure is caused by code written to conform to C++ standards having multiple definitions of the same variable in 'for' statements. Without the flag the code compiles. With the modified flag the code fails because the first definition does not go out of scope at the end of the 'for' loop.

  4. Thomas Moeller

    I agree. I was under the assumption that this option is required for compiling with GCC. But it should be removed now as Coin3D does now support the updated C++ standard.

  5. Roy Walmsley

    I have now removed the references to -fno-for-scope. I still can't test it myself but I will see what Christian's system does in a little while.


  6. Johnathan Conley reporter

    @walroy head compiles on osx 10.9, 10.8 and 10.7 sidenote: 10.9 and 10.8 testsuite only runs 3 tests (no failures), while 10.7 runs 171 tests (1 failure) - msg me directly if you want to open another issue on this - also 3.1.3 release tests fail to compile on all

  7. Volker Enderlein

    This issue has been fixed long time ago in commit 0c4af3e . I am closing this issue now, but you are free to reopen it if your problems have not been addressed properly.

  8. Log in to comment