TbHeroUnit issue when heading is null

Anonymous avatarAnonymous created an issue

TbHeroUnit generates an empty H1 tag when heading is null because of CHtml::encode before isset($this->heading). CHtml::encode converts NULL to an empty string, so then isset returns TRUE (because an empty string is not a null). So, the code should be fixed as follows:

    echo CHtml::openTag('div', $this->htmlOptions);

    if (isset($this->heading)) {
        if ($this->encodeHeading) {
        $this->heading = CHtml::encode($this->heading);
        }
        echo CHtml::tag('h1', $this->headingOptions, $this->heading);
    }

Comments (0)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.