1. Moritz Heidkamp
  2. channel
  3. Pull requests

Pull requests

#2 Merged
Repository
adellica
Branch
master
Repository
DerGuteMoritz
Branch
master

bugfix in set-fold

Author
  1. Kristian Lein-Mathisen
Reviewers
Description

before this mr: set-fold tests fail with sometimes set-fold returning 1, and sometimes 4. never 7.

after this mr: set-fold tests pass

Comments (4)

  1. Kristian Lein-Mathisen author

    a, we had a big discussion on #chicken about testing internal vs external apis. not sure I understand the implementation well enough to get this tested through the external api. I take it you don't like the (include "../set.scm")?

  2. Moritz Heidkamp repo owner

    Oh I don't mind testing the internal set API at all as it is pretty much a separate module anyway. I just didn't consider it worthy enough to make a separate egg for it. My idea was rather to have a regression test for the external API. It's a bit tricky to trigger, though. I think you'd need to have more than one receiver on a channel, both of which raise an error, or something :-) Maybe not worth bothering, though, it's a pretty rare edge case. I'll merge it as is. Thank you very much!