Patcher sometimes fails to export all masters

[ogerboss]

In the past I had a few reports from users complaining about a freeze when they tried to load the SkyProc patch for Requiem. Now I finally managed to cause this issue myself and it seems to be an issue with the masterlist generation. As you can see in the attachments, the difference between the two patches is that the borken variant is missing LAL and Requiem as masters.

All modified records are present in both mods, but in one case the modified NPCs etc are not properly overwriting their origin mods, but instead cloned into the patch. Really problematic this becomes when e.g. keywords from Requiem are referenced, as shown in difference.png.

I have saved both patch plugins, so if you need any extra information, just ask. :)

p.s. despite showing a time difference of more than a day, I did not change anything about the patcher in the meantime, it was weekend. ;)

If it may make a difference: both plugins were generated with a Java8 interpreter.

EDIT: What I also find curious is the file-size, the broken has 11MB, while the working one is 21MB...

[David Tynan]

Did you do something differently when making them? And were they made with SkyProc's normal masters process or with the AllModsAsMasters option, either from the command line or set by your patcher?

[ogerboss]

All I changed between the two patches was a small edit to my Requiem.esp. The edit was a simple magnitude change on a spell. The SPELL GRUP is not imported by my patcher.

In neither case I used the AllModsAsMasters option.

p.s. I did not update my repo in the last days, but as far as I can see from the commit log, the last few commits should not have any impact on this?

[David Tynan]

I haven't made any changes that should have an impact on how the master list is created unless AllModsAsMasters is set. I'm rather confused about this since the way skyproc determines masters is pretty straight forward. It checks every record in the patch and then gets every formID used in each record and adds the mod that form came from as a master.

Did you get anything unusual in the debug log or asynchronous log? Are you able to reproduce this or was it a one off?

[ogerboss]

Unfortunately I overwrote the logfile of the broken patch, I was too keen on finally having something to diff with Tes5Edit... :(

I tried patching a dozen times now again, but was unable to create another broken patch. Given the fact that it happened exactly once in all those months (I patch the dev version like a dozen times per week) and only to a handful individuals of my fairly large userbase, I doubt it will happen soon again. :/ I just posted this, hoping that you would find something obvious in the screenshots or know this issue.

Since this seems to be not the case, I suggest to put this issue on hold until I manage to reproduce it again and save a log file.