About adding the tint to the color effect

[Alessandro Padovani]

As for commit b17fe32, it may make sense to add the reflectance tint to the color effect since for diffuse the tint only exists if there’s an effect. But also consider that the color effect is used everywhere also outside of translucency/diffuse. So in all the other cases the tint will be not used and it’s an extra input that’s only used for the diffuse color effect.

That is, for color effect as a general node, the tint input makes little sense. But it doesn’t harm if it is ignored (set to white) when not used.

@Thomas let me know what you think so I’ll close this one.

[Thomas Larsson]

OK, now there are two versions of the color effect group. The tinted version is used for diffuse and the old group is used everywhere else.

[Alessandro Padovani]

Two groups making the same thing is not so elegant. I'm not sure why to multiply the tint inside the color effect is necessary, but I trust you that it is.

Marking as resolved.

[Thomas Larsson]

Well, it was mainly because it worked better with the material editor. This still doesn’t wprk with textures combined with color effects, but perhaps that is becoming too obscure. I don’t think I will ever use it myself, and I doubt that anyone else ever will, so I think I will leave it as it is.