better handling of limits ?

[Alessandro Padovani]

daz studio 4.21.0.5, blender 3.4.1, diffeomorphic 1.7.0.1436

In the actual implementation the limits are always imported, even if the daz figure has limits disabled. The only difference is for limits on/off in the posing panel to enable/disable the constraints.

Now this approach has the following issues.

1. There’s no way to avoid importing the constaints. For example most daz poses disable limits so there’s no point importing the constraints in the first place, they add complexity and can also cause issues with FK snapping if IK goes outside the FK limits.
2. The checkboxes in the posing panel don’t work in animation, because we can keyframe the constraint influence but not the enable/disable of the constraint.

So I’d propose the following modifications:

1. Don’t import the constraints if the global option is not checked. This allows to simplify the setup if one is not interested in importing limits.
2. For the posing panel set the influence instead of enable/disable of the constraint. This allows to animate the limits that’s what the posing panel should be for.
3. Check “affect transform“ so the limits will affect the transform tools as well. Specifically this means that the values will not go outside the limits when using transform tools. Otherwise they do. This is visible in the transform panel.

https://docs.blender.org/manual/en/latest/animation/constraints/transform/limit_rotation.html

Thomas let me know what you think. I can close as “wontfix“ if you’re not interested, or if this is not practical to implement for any reason.

‌

[Thomas Larsson]

Fixed in last commit.

[Alessandro Padovani]

As for commit f7cfd26, the posing panel doesn’t set the influence keyframe, even if autokeying is on.

Other than that works great.

‌

[Thomas Larsson]

Now influence keyframes are set when auto keying is on. However, this doesn’t work very well, because keyframes are only changed when we drag the slider. If we insert a keyframe manually or remove a key in the timeline, the influence keys are unchanged. Something to be aware of.

[Alessandro Padovani]

Commit 1c0c38f works fine. Thank you for the nice improvement.

As you noted we need to pay some attention when we want to insert a influence keyframe. But I think this is good since usually we don't want to keyframe the influence for all the figure keyframes. Also the control allows to keyframe all the influences at once that comes handy.