eliminiate empties error with custom shapes

[Luke Graybill]

The “Eliminate Empties” function (using latest commit at this time, 387a707) generates an error dialog.

It seems like the function is not set to ignore the custom shapes that are parented to an empty, and also part of a hidden collection (hence the error, I assume). Maybe this is as simple as adding a clause to ignore empties with that specific name?

‌

‌

The empty is actually eliminated despite the error though, so it seems like it’s working properly otherwise.

[Thomas Larsson]

The latest commit catches that runtime error, so it should work now.

[Luke Graybill]

@Thomas Larsson that latest commit doesn’t show the error anymore, but it seems like it is still eliminating that 'Custom Shapes' empty. Is that desired behavior? Now we end up with all the CS_* objects directly parented to the rig too…

‌

‌

[Thomas Larsson]

No, that was not supposed to happen. In the latest commit, only visible empties are eliminated. Since the custom shapes empty is normally hidden, it survives.

[Luke Graybill]

This works great now, thanks Thomas! There are perhaps a couple more cases where that empty gets unintentionally removed:

‌

‌

After eliminating empties in this situation, the Custom Shapes empty was removed, even though it was hidden in the viewport by virtue of being within the Hidden collection. This seems unintuitive (to me, anyhow.)

‌

Similarly, if the Hidden collection is disabled or excluded, the empty within it is still removed:

‌

‌

‌

[Thomas Larsson]

Have been tweaking the behaviour and I think it works quite well know.

[Luke Graybill]

Seems very improved, but it looks like the Custom Shapes empties are still removed in these two situations:

‌

‌

‌

[Thomas Larsson]

Yes, empties only survive if they are hidden themselves, not if they belong to a hidden collection. Since yesterday all custom shapes and their empty are hidden, both with the eye and the terminal icons, so this problem should not arise unless you manually unhide them.