stop showing light settings warning for lights not in scene?

Issue #269 resolved
Luke Graybill created an issue

I would to have a discussion about whether it makes sense to continue showing the warning about lights when the lights in question are not in the current scene. Granted, this is a trivial UX matter, but I still think it’s nice to talk about from a perspective of polish.

In this case, the light being referred to is orphaned data with no users, as a result of opening a new blend file and deleting the default cube and light.

I’ve also tested the circumstance where adding a new empty scene (leaving the default cube and light in the other scene) still generates a warning about the light which is not in the same scene as the imported character.

I suppose there are two questions here: should the plugin continue to warn about lights in these situations:

  1. Light not in the current scene, but still present in another scene in the same blend file.
  2. Light with no users, awaiting garbage collection as part of orphaned data.

I thought about maybe this makes sense if the user were to instance the light back into the scene with the character, but I’m not sure that’s a good enough reason to show a modal warning for some future that might not even happen. Additionally, there is no warning if the user adds a new light to the scene after the import process, so it is still up to the user to know what impact future changes to the scene might have on the render.

Comments (8)

  1. engetudouiti

    I agree it.. but there are options to hide them in gloval setting. The small problem is the letter is shrink and squashed, so actually I could not find the setting long time ^^; (it seems UI problem of panell )

  2. Luke Graybill reporter

    Yeah, that’s a very useful option, I agree. I guess what I’m proposing is not about turning the warnings off all the time because they are very helpful, but rather about making them only show according to what settings and object will affect the scene that a character is being imported into.

  3. engetudouiti

    Hm,,,I could understand . as for me, if I request, I may hope to get property name and values when plug in auto-adjust or up-date. but not expect much about auto-mate adjusting for those setting values. (and usually not hope it)

    so at current on and off is sufficient for me.

  4. Luke Graybill reporter

    I’ve submitted pull request #2 to help address this, but since I don’t really know how Bitbucket works, it didn’t link here automatically. Hopefully this’ll do the trick!

    Edit: ugh, figuring Bitbucket out.. had to remove the first pull request and create a second one so it linked to the correct branch on my side, sorry for the pull request noise, Thomas!

  5. Thomas Larsson repo owner

    Sorry that I missed this report before. Now only lights in the current scene are updated.

  6. Log in to comment