body morphs don't work

Issue #418 resolved
Alessandro Padovani created an issue

commit 1cf9f0f

I tried to import some body morphs and I see that some work and some not. Below an example with breasts and legs morphs for G8F. With 1.5.1 they tend to work better but not completely fine either. So may be a 1.5.1 fix could also be committed.

Also I see there’s not an option to import body morphs in easy import. Please note that body morphs are needed to import some daz poses, other than being useful to shape the figure as the breasts example below. So adding body morphs to easy import may be good in my opinion.

steps:

  1. import G8F
  2. import body morphs

Comments (5)

  1. Thomas Larsson repo owner

    The breast morphs work if you load all of them. However, the connection between the breast morphs and the pectoral rotation is defined in the lBreast and rBreast files, and if these are not loaded the bones don’t move. In 1.5.1 files were opened and parse if a reference to them was found, but 1.6 works differently: In the first pass all selected files are scanned and a dependency graph is built, and in the second pass the actual drivers are created. This makes the code much cleaner but thing may be missed if not all files are loaded.

    One could solve this with an extra pass inbetween, where all referenced files are opened and added to the dependency graph. This will not fix all problems, but most common cases, I think.

  2. Alessandro Padovani reporter

    Thank you Thomas if I import all the breasts morphs then it works fine.

    There’s one issue though in 1.6.0. There are some morphs that don’t work if I select “custom drivers” and “combine drivers” in global settings. For example “breastsin-out” with 1 -1 range only affect the left or right side, instead of both. Then everything works fine if I deselect the above options in global settings.

    1.5.1 works fine.

  3. Thomas Larsson repo owner

    The extra pass is implemented in the last commit, so now the left and right morphs are loaded too, even if you only select the both side morphs. It probably only works on windows though, since all file paths are put in lowercase to compare with the loaded morphs.

    engetudouiti also pointed out that the custom drivers have been broken in some cases. However, custom drivers are deprecated and will be removed once the sum drivers load reasonably fast.

  4. Log in to comment