Add extra bone error on last commit

Issue #772 resolved
bouich jules created an issue

hello,

this error show on the last commit only

when you try add extra facebones.

also will be good if we can move “ add extra facebones” to finishing because it’s a pretty important feature actually.

thank you

Comments (3)

  1. Suttisak Denduangchai

    Thomas, It looks like there is a breaking change in Blender 3.0

    Replaced PoseBone.custom_shape_scale scalar with a PoseBone.custom_shape_scale_xyz vector; in addition, custom_shape_translation and custom_shape_rotation_euler were added. 
    Reference/Release Notes/3.0/Python API - Blender Developer Wiki

    So, copyPoseBone Method at line 647 of figure.py should checking the existence of this attribute first.

            def copyPoseBone(db, pb):
                pb.rotation_mode = db.rotation_mode
                pb.lock_location = db.lock_location
                pb.lock_rotation = db.lock_rotation
                pb.lock_scale = db.lock_scale
                pb.custom_shape = db.custom_shape
                if hasattr(pb, "custom_shape_scale"):
                    pb.custom_shape_scale = db.custom_shape_scale
                else:
                    pb.custom_shape_scale_xyz = db.custom_shape_scale_xyz
                pb.DazRotLocks = db.DazRotLocks
                pb.DazLocLocks = db.DazLocLocks
    

  2. Thomas Larsson repo owner

    Fixed in last commit. I had actually encountered this api change before (in setCustomShapeScale in figure.py) but forgot about it, and didn’t test the commit in Blender 3.0.

    Add Extra Face Bones was moved to a less visible location because it is deprecated. The preferred tool is Make All Bones Poseable, which adds extra bones exactly to those bones that need it (i.e. if some channel is driven), irrespective of the bone is located in the face or not. That there is a special tool for face bones is only for the historical reason that the problem was encountered for face bones first.

    However, Make All Bones Poseable cannot be used with mhx or rigify, because it would mess up the drivers that those rigs use internally. But it is better to make the bones poseable before converting to mhx or rigify. You cannot load any new morphs afterwards anyway.

  3. Log in to comment