#48 Declined
Repository
Pol_M
Branch
default
Repository
Doomseeker
Branch
default
Author
  1. Pol Marcet
Reviewers
Description

I've set a quick-and-dirty example usage of the library at the beginning of the program (It will return immediately after it). This example will list all standard maps, as documented in: https://doomwiki.org/wiki/Lump#Map_lumps. (It’s simply to demonstrate that it works, must be removed before merging.)
Since we are not gonna build a map editor in doomseeker, this library is enough. I've modified it to compile correctly since time had rotten it. Also, I have not included the readme, install instructions, etc.

Comments (14)

  1. Zalewa

    Tested this briefly and have some remarks:

    1. This is awesome. I never knew how useful it’d be until I saw it. Excellent implementation.
    2. It may be useful to be able to select a range of maps on the list and then check or uncheck them in bulk (from a context menu, maybe), but then again you can just add them all to the list and then remove those that you don’t want from there.
    3. It doesn’t handle pk3s that aggregate WADs with custom map lumps, such as Temple of the Lizardmen 4
    4. Perhaps the custom map names should be placed at the top of the list and the MAP##, ExMy should be always at the bottom? That’s probably irrelevant, tho.
    1. Pol Marcet author

      (Writing this for the 3d time, sorry for my brevity, but Bitbucket keeps crashing when I untab)

      This is awesome. I never knew how useful it’d be until I saw it. Excellent implementation.

      I’m really flattered! thank you Zalewa! :D

      It may be useful to be able to select a range of maps on the list and then check or uncheck them in bulk (from a context menu, maybe), but then again you can just add them all to the list and then remove those that you don’t want from there.

      Hum, I’ll look into it. As said, it’s really easy to be circumvented in most cases, but commodity is always a plus

      It doesn’t handle pk3s that aggregate WADs with custom map lumps, such as Temple of the Lizardmen 4

      That has a little bit to do with what originally Blzut said:

      My recommendation would be to only support listing the maps in the maps/ directory in order to give more incentive for authors to do the right thing, but maybe that's just me.

      But I personally don’t care, since adding the functionality is “easy“. Either way is okay for me 🙂

      Perhaps the custom map names should be placed at the top of the list and the MAP##, ExMy should be always at the bottom? That’s probably irrelevant, tho.

      Hum, I’m not quite convinced about the idea of treating the original maps specially, since those can be overwritten by other mods. I can sort the entries in alphabetical order, though 😌

      1. Zalewa

        Hum, I’m not quite convinced about the idea of treating the original maps specially, since those can be overwritten by other mods.

        This highlights another issue: the IWAD already has 32 maps. So, if someone tries to host a classic deathmatch WAD with 10 maps then the map suggestor won’t help that person in knowing how many maps are in the WAD. Maybe we could use a gray color for map names that exist only in the IWAD and are not overwritten by any of the PWADs?

        I can sort the entries in alphabetical order, though

        As long as it’s not asciibetical order 🙂

        E1M1
        E1M10
        E1M2
        

        This may be a good idea considering that map lumps don’t need to exist in the WAD in any given order and right now the suggestor will present them how they sit in the WAD.

        1. Pol Marcet author

          Maybe we could use a gray color for map names that exist only in the IWAD and are not overwritten by any of the PWADs?

          Great idea, I like it! I’ll proceed to do it :)

          As long as it’s not asciibetical order 🙂

          not on my watch😎

  2. Zalewa

    One last thing: since it now scans topfolder of .pk3 files looking for WADs there, it should also do the same for .zip files. Games are capable of loading .zip and .7z files directly.

    1. Pol Marcet author

      Oh, that’s right. That should be quick👍
      I’d say that 7z should also be included then.

      1. Zalewa

        I’d say that 7z should also be included then.

        If that won’t be too much hassle then yes, please.

  3. Zalewa

    A lot of work has been put into this over some period of time so I think I’ll just merge it without squashing & rebasing this time, if that’s okay with you, Pol.

    1. Pol Marcet author

      I don't opose it, of course :)

      Maybe just squashing the three hotfix commits? Two of them are labeled as such and the third is me jokingly saying that 1:30 may not be the best hour to push.

      1. Zalewa

        Fair point. I’ll do some other clean-ups then - I don’t think we need the doomwad lib in the main history, for starters. I’ll try to get it merged before the end of the week.