Add god names in dungeon chronicles

[Katov Mike]

I want to add god names in dungeon chronicles near heroes list at the left block (see screenshot).

How can I push my changes?

(Is it normal to write in russian next time? Я бы предпочел в дальнейшем общаться по-русски)

[Cordarion the Grey]

Looks good, thanks for your work!

• Please, make sure it works also with dungeon bosses, raid bosses (“Ископаемый босс”), and monster groups (“Отряд”), both in Godville and in the Chronicle Archive. Personal bosses (“Босс”) are different beasts.
• I doubt that making them italic is a good idea, since italics are used to indicate guildmates and we don’t have that information on a chronicle page.

How you can share your changes:

1. Fork this repository if you haven’t done it yet.
2. Commit your changes to testing branch (or to a branch based on it).
3. Push them to your fork.
4. Open a pull request against testing.

We’ll also need to make player blacklisting work with them. That code currently lives in superhero/improver.js(improvePlayers) and should perhaps be moved somewhere to common. I can take care of that in about a week unless someone implements it earlier.

Regarding the language being used, the decision is, of course, up to Kreon, but I’d prefer to keep public discussion in English, the most international language nowadays, because the repository is read (and will be read in the future) by those who don’t speak Russian.

[Cordarion the Grey]

Oh, I’ve got a different idea. Have you tried suggesting this improvement to the Godville devs via the Ideabox? It will be better if it’s implemented for everyone, not just eGUI+ users. And it’s trivial, as far as I can guess.

[Katov Mike]

Thank you for the advice, I wrote them and now I’m waiting for a responce.

[Katov Mike]

So, godville developers added god names in logs. Now all logs (old and new) in godville looks ok*. New logs in erinome base contain god names but css styles of them are without changes. Old logs in erinome base are still without god names.

*They broke arena and training logs with this changes, but it is not a mistake of my code they used. (https://ibb.co/k4xYQFc)

[Katov Mike]

I changed my solution a bit, now it adds god names if they are not added, so it works on erinome logs (old and new with god names) and it does not add them twice. Styles are also fixed for dunges and all bosses. This styles fix does not break arena and training logs in erinome base like godville developers did (I think they will fix it soon).

I opened a pull request.

[Cordarion the Grey]

A link to the PR, just for reference.