1. Etienne Perot
  2. gitolite-monkeysphere-integration


Etienne Perot  committed 7e29180

Various fixes to handle corner cases in key changes

  • Participants
  • Parent commits 4cc93d8
  • Branches master

Comments (0)

Files changed (1)

File src/gitolite-monkeysphere-update

View file
  • Ignore whitespace
 		echo 'exec '"`printf '"%q"' "$FULLPGRM"`"' '"`printf '"%q"' "$gitoliteInstallationDirectory"`" | su_gitolite_user tee -a "$integrationDirectoryHook" >/dev/null
 		chmod +x "$integrationDirectoryHook"
-	escapedIntegrationDirectoryHook="`printf "'%q'" "$integrationDirectoryHook"`"
-	if ! grep "$escapedIntegrationDirectoryHook" "$gitoliteConfig" >/dev/null; then
+	if ! grep "$updateHook" "$gitoliteConfig" >/dev/null; then
 		if sed -r ":a;N;\$!ba;s%(POST_COMPILE\\s*=>\\s*\\[)(\\s*)'%\1\2'post-compile/$updateHook',\2'%" "$gitoliteConfig" > "$gitoliteConfig.new"; then
 			chown --reference="$gitoliteConfig" "$gitoliteConfig.new"
 			chmod --reference="$gitoliteConfig" "$gitoliteConfig.new"
 		echo "A rule is being added to allow the git user ($GITOLITE_USER) to run the update script." >&2
 		echo "Make sure you are comfortable with this." >&2
 		echo "If you are not, comment the line by adding '#' in front of it." >&2
-		echo "Do not delete the line, or it will be readded next time this script is run." >&2
+		echo "Do not delete the line, otherwise it will be readded next time this script is run." >&2
 		echo '' >> "$SUDOERSFILE" # Blank line
 		echo "$GITOLITE_USER ALL = NOPASSWD: $FULLPGRM # Required for gitolite-monkeysphere-integration git hook" >> "$SUDOERSFILE"
 		rm -f "$integrationDirectoryMonkeys"
+	if [ -d "$integrationDirectoryRepository/$integrationDirectoryRepositorySSHDir" ]; then
+		while IFS= read -d $'\0' -r monkeyOldKey; do
+			monkey="`basename "$monkeyOldKey" | sed 's/\.pub$//'`"
+			skip=
+			for oldMonkey in "${previousMonkeys[@]}"; do
+				if [ "$oldMonkey" == "$monkey" ]; then
+					skip=1
+					break
+				fi
+			done
+			if [ -z "$skip" ]; then
+				previousMonkeys+=("$monkey")
+			fi
+		done < <(find "$integrationDirectoryRepository/$integrationDirectoryRepositorySSHDir" -type f -name '*.pub' -print0)
+	fi
 	if [ -d "$integrationDirectoryRepository/monkeydir" ]; then
 		while IFS= read -d $'\0' -r monkeyFile; do
 			monkey="`basename "$monkeyFile" | sed 's%\.[^.]*$%%'`"
 	for newMonkey in "${newMonkeys[@]}"; do
 		echo "$newMonkey" >> "$integrationDirectoryMonkeys"
-	if [ -n "$(git status --porcelain)" ]; then
+	if [ -n "$(su_gitolite_user git status --porcelain)" ]; then
 		# Changes to commit
 		log verbose "Committing changes to gitolite-admin repository."
 		su_gitolite_user git commit -m "Gitolite-Monkeysphere integration: Keys updated on `date`."