Commits

Etienne Perot committed 11385c6

Add rspec tests for ini_setting/ruby

Comments (0)

Files changed (2)

lib/puppet/type/ini_setting.rb

     return [] if self[:source].empty?
     content = nil
     self[:source].each do |source|
-      if tmp = Puppet::FileServing::Content.indirection.find(source, :environment => self.catalog.environment)
+      if tmp = indirection_get_ini_file(source)
         content = tmp.content
         break
       end
     children
   end
 
+  # Having it as its own method makes testing easier
+  def indirection_get_ini_file(source)
+    Puppet::FileServing::Content.indirection.find(source, :environment => self.catalog.environment)
+  end
+
 end

spec/unit/puppet/provider/ini_setting/ruby_spec.rb

 describe provider_class do
   include PuppetlabsSpec::Files
 
-  let(:tmpfile) { tmpfilename("ini_setting_test") }
-  let(:emptyfile) { tmpfilename("ini_setting_test_empty") }
+  context "when working with an ini file as source parameter" do
+    context "when given a list of sources" do
+      let(:resource) { Puppet::Type::Ini_setting.new({
+        :title => 'ini_setting_multi_source_iterate_test',
+        :source => ['puppet:///modules/test/file1.ini', 'puppet:///modules/test/file2.ini', 'puppet:///modules/test/file3.ini', 'puppet:///modules/test/file4.ini']
+      })}
+
+      it "should iterate over each source and stop at the first non-empty one" do
+        dummy = Object.new
+        def dummy.content
+          <<-EOS
+# This is a comment
+[section1]
+; This is also a comment
+foo=foovalue
 
-  let(:common_params) { {
-      :title    => 'ini_setting_ensure_present_test',
-      :path     => tmpfile,
-      :section  => 'section2',
-  } }
+bar = barvalue
+master = true
+[section2]
 
-  def validate_file(expected_content,tmpfile = tmpfile)
-    File.read(tmpfile).should == expected_content
+foo= foovalue2
+baz=bazvalue
+url = http://192.168.1.1:8080
+[section:sub]
+subby=bar
+    #another comment
+ ; yet another comment
+          EOS
+        end
+        resource.stub(:indirection_get_ini_file).and_return(nil, nil, dummy)
+        resource.should_receive(:indirection_get_ini_file).exactly(3).times
+        resource.eval_generate
+      end
+    end
+
+    context "when given a single source" do
+      let(:resource) { Puppet::Type::Ini_setting.new({
+        :title => 'ini_setting_single_source',
+        :source => 'puppet:///modules/test/file1.ini'
+      })}
+      before :each do
+        dummy = Object.new
+        def dummy.content
+          <<-EOS
+# This is a comment
+[section1]
+; This is also a comment
+foo=foovalue
+
+bar = barvalue
+master = true
+[section2]
+
+foo= foovalue2
+baz=bazvalue
+url = http://192.168.1.1:8080
+[section:sub]
+subby=bar
+    #another comment
+ ; yet another comment
+          EOS
+        end
+        resource.stub(:indirection_get_ini_file).and_return(dummy)
+      end
+
+      it "should generate as many children ini_setting rules as there are ini options" do
+        resource.eval_generate.size.should == 7
+      end
+
+      it "should generate a matching ini_setting rule" do
+        resource.eval_generate.size.should > 0
+        resource.eval_generate[0][:section].should == 'section1'
+        resource.eval_generate[0][:setting].should == 'foo'
+        # Generated sections should not have a source parameter
+        resource.eval_generate[0][:source].size.should == 0
+      end
+    end
   end
 
+  context "when working with a single ini rule" do
+    let(:tmpfile) { tmpfilename("ini_setting_test") }
+    let(:emptyfile) { tmpfilename("ini_setting_test_empty") }
 
-  before :each do
-    File.open(tmpfile, 'w') do |fh|
-      fh.write(orig_content)
+    let(:common_params) { {
+        :title    => 'ini_setting_ensure_present_test',
+        :path     => tmpfile,
+        :section  => 'section2',
+    } }
+
+    def validate_file(expected_content,tmpfile = tmpfile)
+      File.read(tmpfile).should == expected_content
     end
-    File.open(emptyfile, 'w') do |fh|
-      fh.write("")
+
+
+    before :each do
+      File.open(tmpfile, 'w') do |fh|
+        fh.write(orig_content)
+      end
+      File.open(emptyfile, 'w') do |fh|
+        fh.write("")
+      end
     end
-  end
 
-  context "when ensuring that a setting is present" do
-    let(:orig_content) {
-      <<-EOS
+    context "when ensuring that a setting is present" do
+      let(:orig_content) {
+        <<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
 subby=bar
     #another comment
  ; yet another comment
-      EOS
-    }
-
-    it "should add a missing setting to the correct section" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :setting => 'yahoo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+      }
+
+      it "should add a missing setting to the correct section" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :setting => 'yahoo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
 subby=bar
     #another comment
  ; yet another comment
-      EOS
-)
-    end
-
-    it "should add a missing setting to the correct section with colon" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => 'section:sub', :setting => 'yahoo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should add a missing setting to the correct section with colon" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => 'section:sub', :setting => 'yahoo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
     #another comment
  ; yet another comment
 yahoo = yippee
-      EOS
-)
-    end
-
-    it "should modify an existing setting with a different value" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-           :setting => 'baz', :value => 'bazvalue2'))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'bazvalue'
-      provider.value=('bazvalue2')
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should modify an existing setting with a different value" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :setting => 'baz', :value => 'bazvalue2'))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'bazvalue'
+        provider.value=('bazvalue2')
+        validate_file(<<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
 subby=bar
     #another comment
  ; yet another comment
-      EOS
-      )
-    end
-
-    it "should modify an existing setting with a different value - with colon in section" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-           :section => 'section:sub', :setting => 'subby', :value => 'foo'))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'bar'
-      provider.value.should == 'bar'
-      provider.value=('foo')
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should modify an existing setting with a different value - with colon in section" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => 'section:sub', :setting => 'subby', :value => 'foo'))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'bar'
+        provider.value.should == 'bar'
+        provider.value=('foo')
+        validate_file(<<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
 subby=foo
     #another comment
  ; yet another comment
-      EOS
-      )
-    end
-
-    it "should be able to handle settings with non alphanumbering settings " do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-           :setting => 'url', :value => 'http://192.168.0.1:8080'))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'http://192.168.1.1:8080'
-      provider.value.should == 'http://192.168.1.1:8080'
-      provider.value=('http://192.168.0.1:8080')
-
-      validate_file( <<-EOS
+        EOS
+        )
+      end
+
+      it "should be able to handle settings with non alphanumbering settings " do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :setting => 'url', :value => 'http://192.168.0.1:8080'))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'http://192.168.1.1:8080'
+        provider.value.should == 'http://192.168.1.1:8080'
+        provider.value=('http://192.168.0.1:8080')
+
+        validate_file( <<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
 subby=bar
     #another comment
  ; yet another comment
-    EOS
-      )
-    end
-
-    it "should recognize an existing setting with the specified value" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-           :setting => 'baz', :value => 'bazvalue'))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'bazvalue'
-    end
-
-    it "should add a new section if the section does not exist" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => "section3", :setting => 'huzzah', :value => 'shazaam'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should recognize an existing setting with the specified value" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :setting => 'baz', :value => 'bazvalue'))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'bazvalue'
+      end
+
+      it "should add a new section if the section does not exist" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => "section3", :setting => 'huzzah', :value => 'shazaam'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
 
 [section3]
 huzzah = shazaam
-      EOS
-      )
-    end
-
-    it "should add a new section if the section does not exist - with colon" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => "section:subsection", :setting => 'huzzah', :value => 'shazaam'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should add a new section if the section does not exist - with colon" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => "section:subsection", :setting => 'huzzah', :value => 'shazaam'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
 [section1]
 ; This is also a comment
 
 [section:subsection]
 huzzah = shazaam
-      EOS
-      )
-    end
-
-    it "should add a new section if no sections exists" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => "section1", :setting => 'setting1', :value => 'hellowworld', :path => emptyfile))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file("
+        EOS
+        )
+      end
+
+      it "should add a new section if no sections exists" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => "section1", :setting => 'setting1', :value => 'hellowworld', :path => emptyfile))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file("
 [section1]
 setting1 = hellowworld
 ", emptyfile)
-    end
-
-    it "should add a new section with colon if no sections exists" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => "section:subsection", :setting => 'setting1', :value => 'hellowworld', :path => emptyfile))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file("
+      end
+
+      it "should add a new section with colon if no sections exists" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => "section:subsection", :setting => 'setting1', :value => 'hellowworld', :path => emptyfile))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file("
 [section:subsection]
 setting1 = hellowworld
 ", emptyfile)
-    end
+      end
 
-    it "should be able to handle variables of any type" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => "section1", :setting => 'master', :value => true))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'true'
-      provider.value.should == 'true'
-    end
+      it "should be able to handle variables of any type" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => "section1", :setting => 'master', :value => true))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'true'
+        provider.value.should == 'true'
+      end
 
-  end
+    end
 
-  context "when dealing with a global section" do
-    let(:orig_content) {
-      <<-EOS
+    context "when dealing with a global section" do
+      let(:orig_content) {
+        <<-EOS
 # This is a comment
 foo=blah
 [section2]
 foo = http://192.168.1.1:8080
  ; yet another comment
-      EOS
-    }
+        EOS
+      }
 
 
-    it "should add a missing setting if it doesn't exist" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => '', :setting => 'bar', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+      it "should add a missing setting if it doesn't exist" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => '', :setting => 'bar', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
 foo=blah
 bar = yippee
 [section2]
 foo = http://192.168.1.1:8080
  ; yet another comment
-      EOS
-      )
-    end
-
-    it "should modify an existing setting with a different value" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-           :section => '', :setting => 'foo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'blah'
-      provider.value.should == 'blah'
-      provider.value=('yippee')
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should modify an existing setting with a different value" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => '', :setting => 'foo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'blah'
+        provider.value.should == 'blah'
+        provider.value=('yippee')
+        validate_file(<<-EOS
 # This is a comment
 foo=yippee
 [section2]
 foo = http://192.168.1.1:8080
  ; yet another comment
-      EOS
-      )
-    end
+        EOS
+        )
+      end
 
-    it "should recognize an existing setting with the specified value" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-           :section => '', :setting => 'foo', :value => 'blah'))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'blah'
+      it "should recognize an existing setting with the specified value" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => '', :setting => 'foo', :value => 'blah'))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'blah'
+      end
     end
-  end
 
-  context "when the first line of the file is a section" do
-    let(:orig_content) {
-      <<-EOS
+    context "when the first line of the file is a section" do
+      let(:orig_content) {
+        <<-EOS
 [section2]
 foo = http://192.168.1.1:8080
-      EOS
-    }
-
-    it "should be able to add a global setting" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-           :section => '', :setting => 'foo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+      }
+
+      it "should be able to add a global setting" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => '', :setting => 'foo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 foo = yippee
 
 [section2]
 foo = http://192.168.1.1:8080
-      EOS
-      )
-    end
-
-    it "should modify an existing setting" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => 'section2', :setting => 'foo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'http://192.168.1.1:8080'
-      provider.value.should == 'http://192.168.1.1:8080'
-      provider.value=('yippee')
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should modify an existing setting" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => 'section2', :setting => 'foo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'http://192.168.1.1:8080'
+        provider.value.should == 'http://192.168.1.1:8080'
+        provider.value=('yippee')
+        validate_file(<<-EOS
 [section2]
 foo = yippee
-      EOS
-      )
-    end
-
-    it "should add a new setting" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-          :section => 'section2', :setting => 'bar', :value => 'baz'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should add a new setting" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+            :section => 'section2', :setting => 'bar', :value => 'baz'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 [section2]
 foo = http://192.168.1.1:8080
 bar = baz
-      EOS
-      )
+        EOS
+        )
+      end
     end
-  end
 
-  context "when overriding the separator" do
-    let(:orig_content) {
-      <<-EOS
+    context "when overriding the separator" do
+      let(:orig_content) {
+        <<-EOS
 [section2]
 foo=bar
-      EOS
-    }
-
-    it "should fail if the separator doesn't include an equals sign" do
-      expect {
-        Puppet::Type::Ini_setting.new(common_params.merge(
-                                         :section           => 'section2',
-                                         :setting           => 'foo',
-                                         :value             => 'yippee',
-                                         :key_val_separator => '+'))
-      }.to raise_error Puppet::Error, /must contain exactly one/
-    end
-
-    it "should fail if the separator includes more than one equals sign" do
-      expect {
-        Puppet::Type::Ini_setting.new(common_params.merge(
-                                         :section           => 'section2',
-                                         :setting           => 'foo',
-                                         :value             => 'yippee',
-                                         :key_val_separator => ' = foo = '))
-      }.to raise_error Puppet::Error, /must contain exactly one/
-    end
-
-    it "should modify an existing setting" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-                                                   :section           => 'section2',
-                                                   :setting           => 'foo',
-                                                   :value             => 'yippee',
-                                                   :key_val_separator => '='))
-      provider = described_class.new(resource)
-      provider.exists?.should == 'bar'
-      provider.value.should == 'bar'
-      provider.value=('yippee')
-      validate_file(<<-EOS
+        EOS
+      }
+
+      it "should fail if the separator doesn't include an equals sign" do
+        expect {
+          Puppet::Type::Ini_setting.new(common_params.merge(
+                                          :section           => 'section2',
+                                          :setting           => 'foo',
+                                          :value             => 'yippee',
+                                          :key_val_separator => '+'))
+        }.to raise_error Puppet::Error, /must contain exactly one/
+      end
+
+      it "should fail if the separator includes more than one equals sign" do
+        expect {
+          Puppet::Type::Ini_setting.new(common_params.merge(
+                                          :section           => 'section2',
+                                          :setting           => 'foo',
+                                          :value             => 'yippee',
+                                          :key_val_separator => ' = foo = '))
+        }.to raise_error Puppet::Error, /must contain exactly one/
+      end
+
+      it "should modify an existing setting" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+                                                    :section           => 'section2',
+                                                    :setting           => 'foo',
+                                                    :value             => 'yippee',
+                                                    :key_val_separator => '='))
+        provider = described_class.new(resource)
+        provider.exists?.should == 'bar'
+        provider.value.should == 'bar'
+        provider.value=('yippee')
+        validate_file(<<-EOS
 [section2]
 foo=yippee
-      EOS
-      )
-    end
-
-    it "should add a new setting" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-                                                   :section           => 'section2',
-                                                   :setting           => 'bar',
-                                                   :value             => 'baz',
-                                                   :key_val_separator => '='))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should add a new setting" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+                                                    :section           => 'section2',
+                                                    :setting           => 'bar',
+                                                    :value             => 'baz',
+                                                    :key_val_separator => '='))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 [section2]
 foo=bar
 bar=baz
-      EOS
-      )
-    end
+        EOS
+        )
+      end
 
-  end
+    end
 
-  context "when ensuring that a setting is absent" do
-    let(:orig_content) {
-      <<-EOS
+    context "when ensuring that a setting is absent" do
+      let(:orig_content) {
+        <<-EOS
 [section1]
 ; This is also a comment
 foo=foovalue
 subby=bar
     #another comment
  ; yet another comment
-EOS
-    }
-
-    it "should remove a setting that exists" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-      :section => 'section1', :setting => 'foo', :ensure => 'absent'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_true
-      provider.destroy
-      validate_file(<<-EOS
+        EOS
+      }
+
+      it "should remove a setting that exists" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+        :section => 'section1', :setting => 'foo', :ensure => 'absent'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_true
+        provider.destroy
+        validate_file(<<-EOS
 [section1]
 ; This is also a comment
 
 subby=bar
     #another comment
  ; yet another comment
-EOS
-    )
-    end
-
-    it "should do nothing for a setting that does not exist" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-                                                   :section => 'section:sub', :setting => 'foo', :ensure => 'absent'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.destroy
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should do nothing for a setting that does not exist" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+                                                    :section => 'section:sub', :setting => 'foo', :ensure => 'absent'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.destroy
+        validate_file(<<-EOS
 [section1]
 ; This is also a comment
 foo=foovalue
 subby=bar
     #another comment
  ; yet another comment
-      EOS
-      )
+        EOS
+        )
+      end
     end
-  end
 
 
-  context "when dealing with indentation in sections" do
-    let(:orig_content) {
-      <<-EOS
+    context "when dealing with indentation in sections" do
+      let(:orig_content) {
+        <<-EOS
 # This is a comment
      [section1]
      ; This is also a comment
     #another comment
   fleezy = flam
  ; yet another comment
-      EOS
-    }
-
-    it "should add a missing setting at the correct indentation when the header is aligned" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-                    :section => 'section1', :setting => 'yahoo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+      }
+
+      it "should add a missing setting at the correct indentation when the header is aligned" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+                      :section => 'section1', :setting => 'yahoo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
      [section1]
      ; This is also a comment
     #another comment
   fleezy = flam
  ; yet another comment
-      EOS
-      )
-    end
-
-    it "should update an existing setting at the correct indentation when the header is aligned" do
-      resource = Puppet::Type::Ini_setting.new(
-          common_params.merge(:section => 'section1', :setting => 'bar', :value => 'barvalue2'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_true
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should update an existing setting at the correct indentation when the header is aligned" do
+        resource = Puppet::Type::Ini_setting.new(
+            common_params.merge(:section => 'section1', :setting => 'bar', :value => 'barvalue2'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_true
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
      [section1]
      ; This is also a comment
     #another comment
   fleezy = flam
  ; yet another comment
-      EOS
-      )
-    end
-
-    it "should add a missing setting at the correct indentation when the header is not aligned" do
-      resource = Puppet::Type::Ini_setting.new(common_params.merge(
-                                                   :section => 'section2', :setting => 'yahoo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should add a missing setting at the correct indentation when the header is not aligned" do
+        resource = Puppet::Type::Ini_setting.new(common_params.merge(
+                                                    :section => 'section2', :setting => 'yahoo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
      [section1]
      ; This is also a comment
     #another comment
   fleezy = flam
  ; yet another comment
-      EOS
-      )
-    end
-
-    it "should update an existing setting at the correct indentation when the header is not aligned" do
-      resource = Puppet::Type::Ini_setting.new(
-          common_params.merge(:section => 'section2', :setting => 'baz', :value => 'bazvalue2'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_true
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should update an existing setting at the correct indentation when the header is not aligned" do
+        resource = Puppet::Type::Ini_setting.new(
+            common_params.merge(:section => 'section2', :setting => 'baz', :value => 'bazvalue2'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_true
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
      [section1]
      ; This is also a comment
     #another comment
   fleezy = flam
  ; yet another comment
-      EOS
-      )
-    end
-
-    it "should add a missing setting at the min indentation when the section is not aligned" do
-      resource = Puppet::Type::Ini_setting.new(
-          common_params.merge(:section => 'section:sub', :setting => 'yahoo', :value => 'yippee'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_nil
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should add a missing setting at the min indentation when the section is not aligned" do
+        resource = Puppet::Type::Ini_setting.new(
+            common_params.merge(:section => 'section:sub', :setting => 'yahoo', :value => 'yippee'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_nil
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
      [section1]
      ; This is also a comment
   fleezy = flam
  ; yet another comment
  yahoo = yippee
-      EOS
-      )
-    end
-
-    it "should update an existing setting at the previous indentation when the section is not aligned" do
-      resource = Puppet::Type::Ini_setting.new(
-          common_params.merge(:section => 'section:sub', :setting => 'fleezy', :value => 'flam2'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_true
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should update an existing setting at the previous indentation when the section is not aligned" do
+        resource = Puppet::Type::Ini_setting.new(
+            common_params.merge(:section => 'section:sub', :setting => 'fleezy', :value => 'flam2'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_true
+        provider.create
+        validate_file(<<-EOS
 # This is a comment
      [section1]
      ; This is also a comment
     #another comment
   fleezy = flam2
  ; yet another comment
-      EOS
-      )
-    end
+        EOS
+        )
+      end
 
-  end
+    end
 
 
-  context "when dealing settings that have a commented version present" do
-    let(:orig_content) {
-      <<-EOS
+    context "when dealing settings that have a commented version present" do
+      let(:orig_content) {
+        <<-EOS
      [section1]
      # foo=foovalue
      bar=barvalue
 # foo = foovalue
 ;bar=barvalue
 blah = blah
-      EOS
-    }
-
-    it "should add a new setting below a commented version of that setting" do
-      resource = Puppet::Type::Ini_setting.new(
-          common_params.merge(:section => 'section2', :setting => 'foo', :value => 'foo3'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_false
-      provider.create
-      validate_file(<<-EOS
+        EOS
+      }
+
+      it "should add a new setting below a commented version of that setting" do
+        resource = Puppet::Type::Ini_setting.new(
+            common_params.merge(:section => 'section2', :setting => 'foo', :value => 'foo3'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_false
+        provider.create
+        validate_file(<<-EOS
      [section1]
      # foo=foovalue
      bar=barvalue
 foo = foo3
 ;bar=barvalue
 blah = blah
-      EOS
-      )
-    end
-
-    it "should update an existing setting in place, even if there is a commented version of that setting" do
-      resource = Puppet::Type::Ini_setting.new(
-          common_params.merge(:section => 'section1', :setting => 'foo', :value => 'foo3'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_true
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should update an existing setting in place, even if there is a commented version of that setting" do
+        resource = Puppet::Type::Ini_setting.new(
+            common_params.merge(:section => 'section1', :setting => 'foo', :value => 'foo3'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_true
+        provider.create
+        validate_file(<<-EOS
      [section1]
      # foo=foovalue
      bar=barvalue
 # foo = foovalue
 ;bar=barvalue
 blah = blah
-      EOS
-      )
-    end
-
-    it "should add a new setting below a commented version of that setting, respecting semicolons as comments" do
-      resource = Puppet::Type::Ini_setting.new(
-          common_params.merge(:section => 'section2', :setting => 'bar', :value => 'bar3'))
-      provider = described_class.new(resource)
-      provider.exists?.should be_false
-      provider.create
-      validate_file(<<-EOS
+        EOS
+        )
+      end
+
+      it "should add a new setting below a commented version of that setting, respecting semicolons as comments" do
+        resource = Puppet::Type::Ini_setting.new(
+            common_params.merge(:section => 'section2', :setting => 'bar', :value => 'bar3'))
+        provider = described_class.new(resource)
+        provider.exists?.should be_false
+        provider.create
+        validate_file(<<-EOS
      [section1]
      # foo=foovalue
      bar=barvalue
 ;bar=barvalue
 bar=bar3
 blah = blah
-      EOS
-      )
-    end
+        EOS
+        )
+      end
 
+    end
   end
 
 end