Death Saving Throws ignore filters and apply all bonuses in active effects

[Ben Freeland]

OS	Browser	Foundry Version	DnD5e Version	Obsidian Version
Windows 10	Foundry App	0.7.9	1.3.0	4.4.3

Test Prerequisites

• Obsidian module enabled
• Default Sheet for Features set to Obsidian Item Sheet
• Default Sheet for Player Character set to Obsidian Actor Sheet

Steps to Reproduce

1. Create Actor
2. Under Features & Traits tab click Add Custom
3. Create a top level effect for the feature
4. Click Add Filter in the effect list
5. Set Filter to anything which should not affect Death Saving Throws (eg. Roll->Hit Dice)
6. Click Add Bonus in the effect list
7. Set the bonus to a constant (eg. 0d4 + 4)
8. Close Feature editor menu
9. Click Effects tab
10. Confirm that effect states that it is adding the constant to hit die rolls
11. Roll a Death Saving Throw

Expected:

Death Saving Throw rolls 1d20.

Observed:

The Death Saving Throw rolls 1d20 + [Constant set in step 7]

Patch:

I’ve attached a patch which fixes the issue for me. It looks like a mode wasn’t being supplied to Filters.appliesTo.deathSaves before it was passed to actor.data.obsidian.filters.bonuses.

[Kim Mantas]

Good catch, and thank you very much for the patch. This should now be fixed in 4.4.4.