- changed status to resolved
Death Saving Throws ignore filters and apply all bonuses in active effects
Issue #237
resolved
OS | Browser | Foundry Version | DnD5e Version | Obsidian Version |
---|---|---|---|---|
Windows 10 | Foundry App | 0.7.9 | 1.3.0 | 4.4.3 |
Test Prerequisites
- Obsidian module enabled
- Default Sheet for Features set to Obsidian Item Sheet
- Default Sheet for Player Character set to Obsidian Actor Sheet
Steps to Reproduce
- Create Actor
- Under Features & Traits tab click Add Custom
- Create a top level effect for the feature
- Click Add Filter in the effect list
- Set Filter to anything which should not affect Death Saving Throws (eg. Roll->Hit Dice)
- Click Add Bonus in the effect list
- Set the bonus to a constant (eg. 0d4 + 4)
- Close Feature editor menu
- Click Effects tab
- Confirm that effect states that it is adding the constant to hit die rolls
- Roll a Death Saving Throw
Expected:
Death Saving Throw rolls 1d20.
Observed:
The Death Saving Throw rolls 1d20 + [Constant set in step 7]
Patch:
I’ve attached a patch which fixes the issue for me. It looks like a mode wasn’t being supplied to Filters.appliesTo.deathSaves before it was passed to actor.data.obsidian.filters.bonuses.
Comments (1)
-
repo owner - Log in to comment
Good catch, and thank you very much for the patch. This should now be fixed in 4.4.4.