Unable to open some actor sheets (null actor.obsidian)

Issue #245 new
Former user created an issue

Some actors, such as ones imported with plutonium before activating obsidian sheets, cannot be opened due to unsafe access to actor.obsidian[.tempEffects].

Interestingly, the matching tokens open up properly.

TypeError: An error occurred while rendering ObsidianNPC 45: Cannot convert undefined or null to object
    at Function.values (<anonymous>)
    at ObsidianNPC.getData (npc.js:112)
    at ObsidianNPC._render (foundry.js:4509)
    at ObsidianNPC._render (foundry.js:5157)
    at ObsidianNPC._render (foundry.js:16788)
    at ObsidianNPC.render (foundry.js:4479)
    at ObsidianNPC.render (foundry.js:5621)
    at ObsidianNPC.render (npc.js:169)
    at ActorDirectory._onClickEntityName (foundry.js:16269)
    at ActorDirectory._onClickEntityName (foundry.js:25487)

Comments (2)

  1. Kim Mantas repo owner

    I’d imagine this is related to issue #244 and the actors that fail to prepare properly will also fail to open (I could be wrong though). If that is the case then this is again not a bug and is a module incompatibility. It would be useful to know what version of obsidian you’re using though as I can’t see a call to Function.values on line 112 of npc.js.

  2. Scodde

    Apologie, I had a few debug logs added, line is actually 108 as of 4.4.10

    More specifically this was failing

    data.actor.obsidian.tempEffects = [];
    

    Mostly for the record, as the updates to #244 indeed strongly point to [this being] an invalid issue.

  3. Log in to comment