Feature Request: Compatibility with Dice so Nice.

[Erogroth]

Would it be possible to get obsidian working with the new Dice so Nice module? I know its not a game breaking feature but it is something I am sure many people would want to have.

[Kim Mantas]

Yeah it’s possible, but probably super-low priority since 3D dice do nothing for me personally.

[Erogroth]

Ya I figured. What does obsidian do different than the default that the dice doesn’t pick it up? Is this something that is more easily fixed on the dice module end then on the obsidian end? I am tempted to take a crack at it for a first project.

[Kim Mantas]

Obsidian handles all dice rolling itself, it doesn’t use or override the normal methods on Actor5e and Item5e such as rollItem or rollAbility, etc. It does use the more low-level Die class though to actually do the rolling, so assuming the 3D dice interface with that in some way, I don’t think it will be too difficult to integrate. I think the only two places that actually do the rolling are Rolls.d20Roll and Rolls.rollDamage. I appreciate those methods might be a bit complicated, but as long as you hone in on the two places new Die is called, then that should really be the only places necessary to change.

[Erogroth]

Well I will take a look. Could be a fun project for me to get my feet wet. If I get it working I will send it to you to add if you want.

[Kim Mantas]

Sure, pull requests are always open.

[Kim Mantas]

This has now been added, thanks Ero.