1. Marc Sven Kleinböhl
  2. PureWork
  3. Pull requests

Pull requests

#1 Open

Some small changes

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

git checkout 5x1x
git remote add helpy/purework https://bitbucket.org/helpy/purework.git
git fetch helpy/purework
git merge --no-ff -m 'Merged in helpy/purework (pull request #1)' remotes/helpy/purework/5x1x
  1. helpy

During my first tests and adding EnableExplicit the compiler reported some errors.

Comments (4)

  1. Marc Sven Kleinböhl repo owner


    Thank you for your pull request.

    Currently EnableExpclicit is used already in the purework.pack.pbi file. So it wouldn't make sense to use it in the other files too. Unless you have a good argument to do it.

    Anyway, i will merge your 3 bugfixes.:-)

  2. helpy author

    If EnableExplicit is used in global scope it does not have any effect inside modules :-(

    If EnableExplicit should be active inside modules than you have to put it inside the module code.

  3. Marc Sven Kleinböhl repo owner

    Oh, this isn't what I expected about EnableExplicit in PureBasic. Maybe it is a PB bug. Because this keyword should be a compiler directive. Thank you for explaining.

    In this case, I will implement it into the modules.