View source
develop
  • Contributors
    1. Loading...
Author Commit Message Date Builds
Igor von Nyssen
Merged in bugfix/BasicQuery_in_7_3 (pull request #661) Bugfix/BasicQuery in 7 3 * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into…
Dale Ghent
Merged in planetarium-async (pull request #656) Generic TCP query/response class and reduction of duplicate code * Introduce basic raw TCP command/response class * Utilize new raw TCP command class for planetarium app queries
Stefan B
Add explicit supportedOS into manifest
Stefan B
exported and added editorconfig to solution
Igor von Nyssen
Merged in bugfix/upgrade_entity_framework (pull request #657) Bugfix/upgrade entity framework * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develo…
George Hilios
Merged in ghilios/focusvm_sequence_cancellable (pull request #631) Make it possible to cancel or timeout an AutoFocus during a sequence * Make AutoFocus during Sequencing cancellable without terminating the sequence * Rename based on PR feedback
Stefan B
Merged in feature/ascom_offset (pull request #654) Added offset capabilities to ascom driver * Added offset capabilities to ascom driver * small fixes
Igor von Nyssen
Merged in gruntwork/decouple_focuser_chooser (pull request #601) decouple focuser chooser * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * merged in upstream * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * merged in upstream * fixed merge issues and updated Wait to speed up unit tests * code maid …
Stefan B
Update ASCOM.Platform developer dependency to 6.5
Stefan B
fix typo
Dale Ghent
Merged in c2a-planetarium (pull request #618) Add support for the C2A planetarium program * Add support for the C2A planetarium program * Use ConnectAsync() instead of spawning a task
Igor von Nyssen
Merged in testbed/ioc_devices (pull request #598) Use IOC to de-couple FlatdeviceChooserVM from FlatdeviceVM * Merge branch 'develop' into testbed/ioc_devices * Merge remote-tracking branch 'upstream/develop' into develop * merged in upstream * fixed merge issues * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge branch 'develop' into testbed/ioc_devices * …
Igor von Nyssen
Merged in bugfix/compiler_warnings_5 (pull request #634) Bugfix/compiler warnings 5 * Merge remote-tracking branch 'upstream/develop' into develop * Merge branch 'develop' into bugfix/compiler_warnings_5 * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge branch 'develop' into bugfix/compiler_warnings_5 * if this is a task, we should pass the cancellation token as we…
George Hilios
Merged in ghilios/dome_timeout_fix (pull request #652) Update xaml binding for Dome Synchronization timeout * Update xaml binding for Dome Synchronization timeout
George Hilios
Merged in ghilios/dome_sync_timeout (pull request #650) Add configurable timeout for waiting on dome synchronization * Add configurable timeout for waiting on dome synchronization * Rename for PR feedback * Rename for PR feedback
George Hilios
Merged in ghilios/cancellable_seq_resume_guide (pull request #648) Make MeridianFlip cancellable by linking with the provided cancel token * Make MeridianFlip cancellable by linking with the provided cancel token
George Hilios
Merged in ghilios/dome_test_fix (pull request #649) Fix broken unit tests for Dome * Fix broken unit tests for Dome
Stefan B
merge
Stefan B
add missing AUT dependency
Igor von Nyssen
Merged in bugfix/compiler_warnings_7 (pull request #638) Bugfix/compiler warnings 7 * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' in…
Igor von Nyssen
Merged in bugfix/compiler_warnings_6 (pull request #637) Bugfix/compiler warnings 6 * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * added constructors * Merge remote-tracking branch 'upstream/develop' into develop * Merge branch 'develop' into …
Stefan B
Fix incorrect Gain binding in AnchorableSequenceView
Stefan B
fix ProgressState binding for TaskbarItemInfo
Stefan B
Added nightly build warning note to release notes.
Stefan B
merge
Stefan B
Refine mouse enter and mouse leave for mousecommand behavior to not require special commands
George Hilios
Merged in ghilios/dome_squashed (pull request #599) Complete dome integration - Manual Control, Telescope Following, and Sequence integration * Implement dome following and remaining dome integration * Wait on dome synchronization instead of just rotation to complete
Stefan B
Merged in feature/pixelpeep (pull request #641) Feature/pixelpeep * Proof of concept for pixel peeping * added todo * Index is correct. * Replace MouseFollow logic by behavior * Handle borders to not exceed image dimensions * close popup when ui control is left * Change mouse command to right click instead of middle click * release notes * merge * fix merged html file
Stefan B
1.10 -> dev
Stefan B
1.10 -> develop
Stefan B
Fix merge issue
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
1.10 -> dev
Stefan B
Merged in l10n_develop2 (pull request #629) New Crowdin updates * New translations Locale.resx (Russian) * New translations Locale.resx (Spanish) * New translations Locale.resx (Polish) * New translations Locale.resx (Dutch) * New translations Locale.resx (Japanese) * New translations Locale.resx (Italian) * New translations Locale.resx (Greek) * New translations Locale.resx (German) * New translations Locale.resx (Danish) * New translatio…
Stefan B
Merge branch 'release/1.10' into develop
George Hilios
Merged in ghilios/telescopevm_update (pull request #624) Add Telescope Side of Pier to anchorable view * Add Telescope Side of Pier to anchorable view * Use localized strings for East/West
Stefan B
Merge branch 'develop' of https://bitbucket.org/Isbeorn/nina into develop
Stefan B
1.10 -> dev
Stanley Dimant
Merged in feature/taskbarinfo (pull request #568) Sequence Progress in Taskbar Info * add release notes * merge * merge * fix after merge * remove static appvm * merge? * adjust release notes * Merged Isbeorn/nina:develop into rootdarkarchon/nina-darkarchon-dev:feature/taskbarinfo * adjust bindings * Merged Isbeorn/nina:develop into rootdarkarchon/nina-darkarchon-dev:feature/taskbarinfo
Stefan B
1.10 -> dev
Stefan B
1.10 -> develop
Stefan B
1.10 -> develop
Stefan B
Merged in bugfix/hyperbola_infinite_loop (pull request #633) Prevent infinite loop when inputting bad data into hyperbolic fitting * Prevent infinite loop when inputting bad data into hyperbolic fitting
Stefan B
fix auts to compile again
Stefan B
Add log traces to composition when error occurs on startup
Stefan B
merge 1.10 -> dev
Stefan B
merge 1.10 -> dev
Stefan B
Merged in feature/autofocusreportv2 (pull request #614) Adding mathematical expression of Fittings inside AF Report. * Adding mathematical expression of Fittings inside AF Report. Added Filter Name to AF Report * merge dev * Merge branch 'develop' into feature/autofocusreportv2
Igor von Nyssen
Merged in bugfix/compiler_warnings_4 (pull request #620) Bugfix/compiler warnings 4 * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' in…
Stefan B
Merged in l10n_develop2 (pull request #615) New Crowdin updates * New translations Locale.resx (Italian) * New translations Locale.resx (Greek) * New translations Locale.resx (German) * New translations Locale.resx (Danish) * New translations Locale.resx (Portuguese) * New translations Locale.resx (French) * New translations Locale.resx (Galician) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Japanese)…
Stefan B
Merge 1.10 -> develop
Stefan B
merge 1.10 -> develop
Stefan B
merge 1.10 -> develop
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
Merged in l10n_develop2 (pull request #612) New Crowdin updates * New translations Locale.resx (Polish) * New translations Locale.resx (Dutch) * New translations Locale.resx (Japanese) * New translations Locale.resx (Italian) * New translations Locale.resx (Greek) * New translations Locale.resx (German) * New translations Locale.resx (Danish) * New translations Locale.resx (Portuguese) * New translations Locale.resx (Portuguese) * New tran…
Stefan B
Switch lz4 dll ins setup for new dependency. Add ninject dll to setup.
Dale Ghent
Merged in lz4-upgrade (pull request #600) Migrate from lz4net to K4oS.Compressison.LZ4 * Migrate from lz4net to K4oS.Compressison.LZ4 * revert unrelated change to zlib logic
Igor von Nyssen
Merged in bugfix/compiler_warnings1 (pull request #585) Bugfix/compiler warnings1 * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * fix unused event warnings and nuget packages * Merge remote-tracking branch 'upstream/develop' into develop * Mer…
Igor von Nyssen
Merged in bugfix/compiler_warnings2 (pull request #586) Bugfix/compiler warnings2 * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * remove async from stuff that would execute synchronously anyways * Merge remote-tracking branch 'upstream/develop'…
Stefan B
adding efw dll to setup
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
Merged in feature/efw (pull request #571) Feature/efw * efw native * change dllname for dllimport in efw * efw index starts at 0 for searching * set position immediately * merge develop
Stanley Dimant
Merged in refactor/decoupling (pull request #604) Decoupling VMs * merge from develop * Merge remote-tracking branch 'upstream/develop' into main * decouple applicationvm from skyatlasvm and framingassistantvm using mediator * inject deepskyobjectsearchvm * extract sequencevm and replace with mediator from classses * fix sequencemediator assignment
Stefan B
Merged in l10n_develop2 (pull request #608) New Crowdin updates * New translations Locale.resx (Spanish) * New translations Locale.resx (Polish) * New translations Locale.resx (Dutch) * New translations Locale.resx (Japanese) * New translations Locale.resx (Italian) * New translations Locale.resx (Greek) * New translations Locale.resx (German) * New translations Locale.resx (Danish) * New translations Locale.resx (Portuguese) * New transla…
Stefan B
Add filter to AF report
Stefan B
merge 1.10 -> dev
Stefan B
merge 1.10 -> dev
Stefan B
Update libs
Stefan B
Merge branch 'develop' of https://bitbucket.org/Isbeorn/nina into develop
Stefan B
remove unnecessary package in ninatest
George Hilios
Merged in ghilios/focuser_temp_comp_fix (pull request #577) Disable and re-enable TempComp if it is enabled during focusing * Disable and re-enable TempComp if it is enabled during focusing * Fix unit tests
Stefan B
merge
Stanley Dimant
Merged in testbed/ioc (pull request #587) Refactoring (IoC Container + Decoupling) * fix some stuff * get rid of old baggage * fix cameracontrolview binding * fix bindings * remove .camerainfo. * clean up proxy * merge from dev * remove appvm * remove duplicate name after merge * fix binningmodes = null
Stefan B
merge 1.10 -> dev
Stefan B
Merged in l10n_develop2 (pull request #595) New Crowdin updates * New translations Locale.resx (Chinese Simplified)
Stefan B
Merged in feature/eagle1.3 (pull request #596) Feature/eagle1.3 * Added readout of eagle manager switch labels available in eagle manager 1.3 * Enable writing of Eagle Switch labels * Adjust switch ui in switch tab to be more in line with EAGLE manager * Merge branch 'develop' into feature/eagle1.3 * Add power ports first to eagle * Added eagle button layout to anchorable
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
Merged in l10n_develop2 (pull request #594) New Crowdin updates * New translations Locale.resx (Polish) * New translations Locale.resx (Dutch) * New translations Locale.resx (Japanese) * New translations Locale.resx (Italian) * New translations Locale.resx (Greek) * New translations Locale.resx (Portuguese) * New translations Locale.resx (Russian) * New translations Locale.resx (Greek) * New translations Locale.resx (Danish) * New translat…
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
1.10 -> dev
Stefan B
Merged in l10n_develop2 (pull request #589) New Crowdin updates * New translations Locale.resx (French) * New translations Locale.resx (Turkish) * New translations Locale.resx (Galician) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Spanish) * New translations Locale.resx (Japanese) * New translations Locale.resx (Portuguese)
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
Merged in l10n_develop2 (pull request #576) New Crowdin translations * New translations Locale.resx (Turkish) * New translations Locale.resx (Galician) * New translations Locale.resx (Turkish) * New translations Locale.resx (Galician) * New translations Locale.resx (Galician) * New translations Locale.resx (Galician) * New translations Locale.resx (Galician) * New translations Locale.resx (Galician) * New translations Locale.resx (Portugue…
Stefan B
1.10 -> dev
Stefan B
Merged in l10n_develop2 (pull request #575) New Crowdin translations * New translations Locale.resx (French) * New translations Locale.resx (Spanish) * New translations Locale.resx (Chinese Simplified)
Stefan B
Merged in l10n_develop2 (pull request #569) New Crowdin translations * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (English, United States) * New translations Locale.resx (English, United Kingdom) * New translations Locale.resx (Chinese Traditional, Hong Kong) * New translations Locale.resx (Greek) * New translations Locale.resx (Turkish) * New transl…
Stefan B
1.10 -> dev
Stefan B
merge
Stefan B
Merged in l10n_develop2 (pull request #566) New Crowdin translations * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (English, United States) * New translations Locale.resx (English, United Kingdom) * New translations Locale.resx (Chin…
Stanley Dimant
Merged in darkscheck (pull request #543) Darkscheck * presequencecheck for dark/bias in sequence * merge from develop * adjust strings * add release notes * merge from develop * merge
Stanley Dimant
Merged in feature/gainreset (pull request #564) Save and Reset Gain+Offset on Image capture * save and reset gain on capture * add gain to image metadata * display gain from camera equipment by default instead of empty value * fix nikon saving gain, add preselected and default gain instead of empty value, change gain to int where necessary * Merge remote-tracking branch 'upstream/develop' into feature/gainreset * Merge branch 'main' into …
George Hilios
Merged in ghilios/dome_support_wip (pull request #552) Initial Dome integration that allows manual slewing and viewing properties * Boilerplate for Dome integration that does nothing * Enable manual slewing, parking, and shutter control * Fix build break brought in by rebase * Move ASCOM references out of IDome
Steve Smith
Merged in feature/tidy_up_seq_eta (pull request #553) Change to LblCurrentSequenceEstimates label and changes to conditionally hide 'current target' estimates when only one target * Merged Isbeorn/nina/develop into develop * Refresh from main develop branch Merged Isbeorn/nina/develop into develop * Merged Isbeorn/nina/develop into develop * Merged Isbeorn/nina/develop into develop * Merged Isbeorn/nina/develop into develop * Merged Isbeorn/nin…
Stanley Dimant
Merged in feature/nativeatikfw (pull request #562) Native Atik EFW and internal FilterWheel support * add native atik EFW support * add atik internal filter wheels (first attempt) * change id for atikfilterwheel * add release notes * refactor atik filterwheel into base * fix styling * clean up usings * fix typo in release notes
Stefan B
Merge branch 'develop' of https://bitbucket.org/Isbeorn/nina into develop
Stefan B
remove duplicate filter timing test
George Hilios
Merged in ghilios/relative_focuser (pull request #530) Support relative focusers by emulating an absolute focuser * Implement relative focuser * Support relative focusers by emulating an absolute focuser * Add unit tests for relative focuser support * Fix Unit tests after rebase * Throw on Absolute/RelativeAscomFocuser Move. Require MoveAsync instead
Stefan B
Merged in l10n_develop2 (pull request #565) New Crowdin translations * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (English, United States) * New translations Locale.resx (English, United Kingdom) * New translations Locale.resx (Chin…
Stefan B
Merge branch 'develop' of https://bitbucket.org/Isbeorn/nina into develop
Stefan B
merge release to develop
Stefan B
Merged in l10n_develop2 (pull request #560) New Crowdin translations * New translations Locale.resx (Japanese) * New translations Locale.resx (Russian) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (Chinese Traditional, Hong Kong) * New translations Locale.resx (Greek) * New translations Locale.resx (Turkish) * New translations Locale.resx (Turkish) *…
Stefan B
merge fixes
Stefan B
merge
Stefan B
Merged in feature/afrefactor (pull request #527) Feature/afrefactor * remove minimum from autofocusvm. instead use minimum from trendline fitting * Remove backlash measurement ,as it is not precise enough. * Factory method for AF Report * remove obsolete usages * Added some very basic AUTs for the fittings * Merge branch 'develop' into feature/afrefactor * merge * Updated license header * merge * Merged develop into feature/afrefactor
Igor von Nyssen
Merged in feature/UPBV2_firmware_1.4 (pull request #545) Feature/UPBV2 firmware 1.4+ support * Merge remote-tracking branch 'upstream/develop' into develop * Merge remote-tracking branch 'upstream/develop' into develop * looking good with device on 1.3 - upgrading firmware now * upgraded firmware, needed to make the response cache aware of the response type, not just the command * Merge remote-tracking branch 'upstream/develop' into develop * Merg…
Stefan B
Merged in l10n_develop2 (pull request #556) New Crowdin translations * New translations Locale.resx (English, United Kingdom)
Stefan B
Merged in l10n_develop2 (pull request #551) New Crowdin translations * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (English, United States) * New translations Locale.resx (English, United Kingdom) * New translations Locale.resx (Chin…
Stefan B
Merged in l10n_develop2 (pull request #544) New Crowdin translations * New translations Locale.resx (Japanese) * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (English, United States) * New translations Locale.resx (English, United Kin…
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
merge
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
merge
Stefan B
Merged in l10n_develop2 (pull request #542) New Crowdin translations * New translations Locale.resx (Japanese) * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (English, United States) * New translations Locale.resx (English, United Kin…
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
Merge branch 'develop' of https://bitbucket.org/Isbeorn/nina into develop
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
Merged in l10n_develop2 (pull request #537) New Crowdin translations * New translations Locale.resx (Italian) * New translations Locale.resx (Japanese) * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) * New translations Locale.resx (Chinese Simplified) * New translations Locale.resx (Chinese Traditional) * New translations Locale.resx (English, United States) * New tran…
Stefan B
merge
Stefan B
Mozilla Public License Version 2.0
Stefan B
merge
Stefan B
Merged in l10n_develop2 (pull request #528) New Crowdin translations * New translations Locale.resx (French) * New translations Locale.resx (Spanish) * New translations Locale.resx (Danish) * New translations Locale.resx (German) * New translations Locale.resx (Italian) * New translations Locale.resx (Japanese) * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) *…
Igor von Nyssen
Merged in igorvonnyssen/nina/develop (pull request #531) fix assembly issues and ASCOM focuser tests * fix assembly issues and ASCOM focuser tests * revert formatting changes
Stefan B
Merge branch 'release/1.10' into develop
Stefan B
merge
Stefan B
Merged in l10n_develop2 (pull request #526) New Crowdin translations
Stefan B
Merged in l10n_develop2 (pull request #525) New Crowdin translations * New translations Locale.resx (French) * New translations Locale.resx (Spanish) * New translations Locale.resx (Danish) * New translations Locale.resx (German) * New translations Locale.resx (Italian) * New translations Locale.resx (Japanese) * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * New translations Locale.resx (Russian) *…
Stefan B
merge
Stefan B
Merged in l10n_develop2 (pull request #516) New Crowdin translations * New translations Locale.resx (French) * New translations Locale.resx (French) * New translations Locale.resx (Spanish) * New translations Locale.resx (Danish) * New translations Locale.resx (German) * New translations Locale.resx (Italian) * New translations Locale.resx (Japanese) * New translations Locale.resx (Dutch) * New translations Locale.resx (Polish) * …
Stefan B
Merge release/1.10 -> develop
Stefan B
Version 1.11.0.1001
Stefan B
.NET Framework 4.8 Update of third party libraries
Chris Turchin
Merged in turchinc/nina/feature/execute-cmd-after-seq-dev (pull request #513) Feature/execute cmd after seq dev * Implement: https://bitbucket.org/Isbeorn/nina/issues/502/enhancement-execute-external-process-in * Implement: https://bitbucket.org/Isbeorn/nina/issues/502/enhancement-execute-external-process-in * improve logging * Revert "Implement: https://bitbucket.org/Isbeorn/nina/issues/502/enhancement-execute-external-process-in" This reverts commit 97f373473548f…
Stanley Dimant
Merged in rootdarkarchon/nina-darkarchon-dev/atikdarkmode (pull request #517) Set Dark Mode on Atik cameras for DARK/BIAS/FLAT
Igor von Nyssen
Merged in igorvonnyssen/nina/feature/edit_wizard_trained_values (pull request #492) Feature/edit wizard trained values * got something working statically * views are working statically * WIP * seems to work * WIP * WIP * things seem to be working, needs polish and tests though * added test to get back to existing coverage * added tests to increase coverage * removed unused code