Merged in feature/memory_test (pull request #1207)
This PR is targeted to some of the potential memory problems that are apparent when using the advanced seqeuncer.
Main points identified:
Selfbinding datacontext needs to be removed:DataContext="{Binding}"
DataContext="{Binding}"
RelayCommand Implementation leaks memory
MVVMLight Library impements weak actions, weak functions and weak events for the Relaycommand. Use this one instead
Drag/Drop Events
Using WeakEvents instead
Some specific sources of bindings prevented GC collection
Added code behind instead of databinding to make sure these resources can be collected
Replace System.Windows.Interactivity with the replacement library
https://devblogs.microsoft.com/dotnet/open-sourcing-xaml-behaviors-for-wpf/
Manual tests, Memory snapshots
Issue #1023
Â
What is the purpose of this Pull Request?
This PR is targeted to some of the potential memory problems that are apparent when using the advanced seqeuncer.
Main points identified:
Selfbinding datacontext needs to be removed:
DataContext="{Binding}"RelayCommand Implementation leaks memory
MVVMLight Library impements weak actions, weak functions and weak events for the Relaycommand. Use this one instead
Drag/Drop Events
Using WeakEvents instead
Some specific sources of bindings prevented GC collection
Added code behind instead of databinding to make sure these resources can be collected
Replace System.Windows.Interactivity with the replacement library
https://devblogs.microsoft.com/dotnet/open-sourcing-xaml-behaviors-for-wpf/
How were the changes tested?
Manual tests, Memory snapshots
Did all Unit Tests pass?
Are there relevant Issues in the tracker that this PR will fix?
Issue #1023
Screenshots
Notes
Â