Merged in feature/betterframing (pull request #1233)
9d9c844·Author: Stefan B·Closed by: Stefan B·2022-01-19
Description
What is the purpose of this Pull Request?
Framing Assistant was not accounting for panel misalignment while being far off the celestial equator. When approaching the pole the panels with the same orientation would not align to a perfect rectangle anymore, but the framing assistant would not account for this.
This change will add calculations to account for this panel misalignment, show the misalignment and offer a toggle to compensate for it by adjusting rotations for each panel individually.
Additional Features:
A grid to show mosaic details
Bugfixes for dragging the rectangle around over larger distances resulting no more in accumulated calculation errors
Toggle to rotate the sky image instead of the rectangle
Adjust panel numbering to first start horizontally then vertically
How were the changes tested?
Lots of manual tests
Did all Unit Tests pass?
Yes
Are there relevant Issues in the tracker that this PR will fix?
What is the purpose of this Pull Request?
Framing Assistant was not accounting for panel misalignment while being far off the celestial equator. When approaching the pole the panels with the same orientation would not align to a perfect rectangle anymore, but the framing assistant would not account for this.
This change will add calculations to account for this panel misalignment, show the misalignment and offer a toggle to compensate for it by adjusting rotations for each panel individually.
Additional Features:
A grid to show mosaic details
Bugfixes for dragging the rectangle around over larger distances resulting no more in accumulated calculation errors
Toggle to rotate the sky image instead of the rectangle
Adjust panel numbering to first start horizontally then vertically
How were the changes tested?
Lots of manual tests
Did all Unit Tests pass?
Yes
Are there relevant Issues in the tracker that this PR will fix?
Issue #621
Issue #976Â
Screenshots
Â
Notes
Â