Gain and offset handling in NINA is a bit inconsistent and nontransparent for the user. This PR unifies the usage of gain on capture and display by the following means:
Should no gain be set the gain will default to the gain set in Equipment → Camera
All images taken will adjust the gain to the image requested by the SequenceItem and restore it after the image was taken or cancelled
Unlike before, gain will not be stored permanently in the Camera once an image with the specified gain was taken
This avoids issues like PlateSolving running with a different gain when the Sequence itself has no gain set, therefore PlateSolve overwriting the Sequence gain
Equivalent means have been taken for Offset
To assist the user several things have been implemented:
Used gain is now displayed in the image Statistics
Gain display in FlatWizard, Sequence, Imaging (Plate Solve, Snapshot, Exposure Calculator) now shows the gain from Equipment → Camera as default
The gain is displayed in brackets like “(200)”
Deleting the gain in free gain will replace the empty field with that value as well
Combobox gain also has an extra item in the same style
The gains used are updated once user changes gain in Camera → Equipment
As a minor bugfix this PR also includes saved Gain restore for Nikon cameras on camera connection.
How were the changes tested?
Against my ASI183, Nikon D5100
Are there relevant Issues in the tracker that this PR will fix?
What is the purpose of this Pull Request?
Gain and offset handling in NINA is a bit inconsistent and nontransparent for the user. This PR unifies the usage of gain on capture and display by the following means:
Should no gain be set the gain will default to the gain set in Equipment → Camera
All images taken will adjust the gain to the image requested by the SequenceItem and restore it after the image was taken or cancelled
Unlike before, gain will not be stored permanently in the Camera once an image with the specified gain was taken
This avoids issues like PlateSolving running with a different gain when the Sequence itself has no gain set, therefore PlateSolve overwriting the Sequence gain
Equivalent means have been taken for Offset
To assist the user several things have been implemented:
Used gain is now displayed in the image Statistics
Gain display in FlatWizard, Sequence, Imaging (Plate Solve, Snapshot, Exposure Calculator) now shows the gain from Equipment → Camera as default
The gain is displayed in brackets like “(200)”
Deleting the gain in free gain will replace the empty field with that value as well
Combobox gain also has an extra item in the same style
The gains used are updated once user changes gain in Camera → Equipment
As a minor bugfix this PR also includes saved Gain restore for Nikon cameras on camera connection.
How were the changes tested?
Against my ASI183, Nikon D5100
Are there relevant Issues in the tracker that this PR will fix?
Probably the same as the other PR
Screenshots
Camera Set gain to 400 in Combobox
Reflection in the UI
Gain set to 100 in the free gain box
Reflection in the UI
Statistics including Gain
Notes