ParticleEmitterNode creating unneeded "test stuff" on production

[NemesisMate]

I've seen that the ParticleEmitterNode has some test instantiations/initializations. Those shouldn't be happening if the already existing boolean testParticles and boolean testEmitter fields are false. When a particle is being spawn all these tests parameters are being instantiated and initialized without really being used:

• emitterShapeTestGeometry
• emitterTestNode
• particleTestGeometry
• particleTestNode
• testMat

In my opinion this is a total waste of resources.

[Aliaksandr Brui]

Can you test the last develop version of the library? if it works good, I will make a release.

[NemesisMate]

I'm trying it with gradle:

compile 'com.github.JavaSaBr:tonegodemitter:develop-SNAPSHOT'

but somehow it doesn't get the latest commits. Do you know why?

[Aliaksandr Brui]

@NemesisMate you need to execute

gradle --refresh-dependencies 

[NemesisMate]

I've already did that, multiple times. I've tried too with:

configurations.all {
    resolutionStrategy.cacheChangingModulesFor 0, 'seconds'
}

[Aliaksandr Brui]

@NemesisMate ok, try to use 2.4.0 version :)

[NemesisMate]

Ok, tried and working. However, wouldn't it be better to create a "test control" that can be attached to the emitter when testing is desired?, this way the test-code would be completely separated from the emitter code (which wouldn't have any test-code reference at all, being much cleaner)

[Aliaksandr Brui]

the library requires a lot of refactoring else ;)

[Aliaksandr Brui]

I think this ticket is done.