Absorb UI could be more intuitive/future proof

[Wes Chao]

The initial implementation treats both fields separately: the monster may absorb all of an element, and it may absorb any damage regardless of type over a certain threshold. Putting both of these on the same line implies that they are related when they are not.

The new implementation treats both fields as related: the monster may absorb damage of the given type (or all) over a certain threshold. This is more intuitive, but does not support the potential use case of a monster that, say, absorbs all fire damage AND any other damage over 200k. It also requires an extra two clicks to input a threshold (to select "All"), though this could be solved by defaulting the type box to All.

I suggest splitting the absorb section into two rows, controlled by the same toggle, like so:

Absorb element [ type-select ] Absorb damage over [ text field ]

[Jean-Paul Cato]

I think part of the reason it's implemented as is the lack of double absorb on any mobs to date. Fairly trivial change, but doesn't feel like a priority at the moment. Although if the absorb mechanism gets updated, it should probably also cover multi-element absorbs too...

Change the default Absorb value to be 'All'.

[Wes Chao]

Defaulting it to all is good enough for me.