Check for websocket request before checking for HTTP/1.1

Luke Olbrish avatarLuke Olbrish created an issue

Requests that come into WebSocketHandler that are not websocket requests should not error out if they are not HTTP/1.1 since they can simply be handled by super(WebSocketHandler, self).run_application(). The simplest fix seems to be checking HTTP_UPGRADE before HTTP/1.1.

I am using the GeventWebSocketWorker for a general WSGI app, so only some routes are actually websockets. Perhaps that isn't the intention of this library though.


Comments (2)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.