GitHub Octicons in fontawesomefx

[Peter Rogge]

Hi, I want to implement the icons from 'GitHub Octicons' in fontawesomefx and then share with you the implementation.

In my fork I have (most) copy & past the implementation from MaterialIcon excepted the values form the single icons. But when i run 'GlyphsBrowserApp' then I see (after click on the new button 'GitHub Octicons') that most of the icons have a rectangle. Some have mathematic signs. So I think, that the loading from the new font 'octicons.ttf' don't work. But I can't find out what's wrong.

Can someone help me with tips or can check out my fork(master) and have a look on it? https://bitbucket.org/Naoghuman/fontawesomefx

Greetings Peter

[Jens Deters]

Nice work! You should remove the tailing "OCT_"s in the enum class Octicon. Ah and the fix for your issue: the name of the font family is "Octicon" instead of "GitHub Octicon" ;-) ....

[Peter Rogge]

Lol thx Jens. I will do it.

[Peter Rogge]

Hi Jens, thx for the immediatly integration. I mark this issue as resolved from my side.

[Peter Rogge]

Integration from GitHub Octicons is done. Good fast work from Jens :) .