- changed status to open
Make Icon extend Text instead of Label
Issue #9
closed
Is there a reason why Icon
extends Label
instead of Text
? This article suggests that Labels
have a much higher memory footprint than Texts
.
Comments (6)
-
repo owner -
repo owner Looks good so far. The only issue is the size: switching internally from Label to Text leads into adjusting the current icons size.
-
reporter Cool thanks for giving it a try. The change in size is something I noticed as well. I had to adapt the CSS in order to compensate for that. Let me know if I can be of any assistance.
-
repo owner - changed status to closed
implemented in 8.1
-
reporter Sweet! Nice work, also on the refactoring.
-
repo owner Thanks! Please give it a try and feed me back!
- Log in to comment
Interesting point. Will do some tests to check!