Refactor config loading
in preparation for webUI some refactoring for OptionsJSON.
Comments (7)
-
reporter -
reporter Some explanations.
Most importantly config load does not system.exit(0) anymore. This should be handled by the caller, i.e. NuBot. https://bitbucket.org/JordanLeePeershares/nubottrading/src/5c1be2723ef05c321871dd0439c46e5c10a84b0c/NuBot/src/com/nubits/nubot/launch/NuBot.java?at=feature/211#cl-100
-
- changed milestone to 0.2.1 - Liquidity distribution model
-
I added some Unit-Tests to load a configuration file. there are a few test cases to add. But basically the Jsonconfig returns a NuBotConfig object. I think we can use that when starting NuBot.
-
some work towards refactoring settings.properties. It's used for several purposes at once, and I'd like to break that down a bit. One is the use of relative paths. If we store the relative path variables as static strings this should work at all times. I think it's better to avoid loadResources.
-
one change I made: system.exit(0) occurs not in utilities, but in NuBot. if criticial errors occur it's better to have that in the control flow of the bot. i.e. parsing files is not critical itself, but it throws an error, which NuBot then exits on. Benjamin Cordes 09:36
- OptionsJSON is now NuBotOptions. options package has changed: introduction of OptionParse for static arguments more modular functions for parsing JSON into NuBotOptions new class: StandardOptions
-
reporter - changed status to resolved
-
- changed milestone to 0.3.1 - Liquidity distribution model
-
- changed milestone to 0.3.3 - Liquidity distribution model
-
- changed milestone to 0.3.2 - Liquidity distribution model (t2)
- Log in to comment
see issue
#198. duplicate.