Pull request in dev process

Issue #232 resolved
Benjamin Cordes created an issue

As this works very well with Bitbucket's Pull request feature, I suggest for QA purposes the following guidelines:

critical code changes are created through separate Pull Requests via Bitbucket, not local merges. all team members (currently 3) are added as reviewers.

Merge is done by person other than the person who submitted the PR (the last to approve).

A PR can easily submitted online by using Bitbucket's PR feature. Go to: PR and click new Pull request. Select the branch and target develop.

TODO: if approved, add this suggestion to contribute.md

Comments (8)

  1. Desrever Nu

    Approved. lacks definition of "critical", that we can leave up to our discretion at this point and define it systematically in the future

  2. Log in to comment