take a final decision about settings.properties

[Desrever Nu]

Now that we moved resources we need to take a final decision about settings.properties

The original purpose of this file was to collect in one place all parameters that developers can adjust quickly without changing the code. Apparently we don't like that approach anymore.

Now it only contains only one variable, defeating the purpose of having such file.

I propose to get rid of the properties file and distribute all the variables that were there on separate files depending on their purposes :

All passwords in Passwords.java, all folder and file names in Paths.java, all timing intervals in Intervals.java .

maybe also group the files in a package.

and remember to

Get SYSTEMATICALLY rid of all occurrences of :

String logsFolder = Global.settings.getProperty

[Benjamin Cordes]

Yes, I agree the current structure is not entirely consistent. The logsFolders should not be needed. Open question is about passwords.

With regards to the layout I'm following the standard layout which is detailed here: http://gradle.org/docs/current/userguide/java_plugin.html (see 23.4 - project layout). That's where the source folders and resource folder comes from. There are some issues I think however with loading things via classpath this way.

[Benjamin Cordes]

old settings was

app_name=NuBot
version=develop
res_path=res/
log_path=logs/
keystore_path=res/ssl/nubot_keystore.jks
keystore_pass=...
frozen_folder=res/frozen/
reset_every_minutes=3
refresh_time_seconds=61
submit_liquidity_seconds=130