Layout and resources

Issue #358 resolved
Desrever Nu created an issue

frozen folder location is wrong

Currently the "frozen" folder is placed within the session logs. This is not going to work.

The "frozen" file gets written AND read from a folder that must not change location. The user can also manually edit the frozen json files and then launch the bot.

I don't know how can the bot start now without having a frozen file to read from. Will test later

Comments (12)

  1. Benjamin Cordes

    one static variable in logsFolder ok?

    public final static String frozenfolder = Global.logsFolder + "/" + "frozen";
    
  2. Desrever Nu reporter
    • changed status to open

    Having it in the root of the project feels wrong. Being a resource required at runtime has to be stored under the resources/ folder.

    This must be reflected in the build gradle task. Please see also #394

  3. Benjamin Cordes

    "Being a resource required at runtime has to be stored under the resources/ folder." src/main/resources is the folder which is used for packaging the jar. please read up on how this works, and make suggestions based on those standards (linked in the other issue). the folder in the dist folder can be named whatever. Feel free to adapt the filepaths etc, but the name "resources" is reserved for this kind of packaging A folder resources is not related to src/main/resources. If we package up things in the resource folder things have to be loaded via classpath.

  4. Benjamin Cordes

    Open is the question about scripts.

    With current layout

    • dist/res => non-changeable static files
    • dist/config => configurable files
    • dist/scripts (?)
  5. Benjamin Cordes
    • Make sure the above decisions are reflected in Settings.java
    • Make sure the above decisions are reflected in build.gradle
    • done: Remove duplicate currencies.csv and (remove test/resources/settings.properties )
    • done: Remove all files from src/main/resources (?)
  6. Log in to comment