- marked as critical
Layout and resources
frozen folder location is wrong
Currently the "frozen" folder is placed within the session logs. This is not going to work.
The "frozen" file gets written AND read from a folder that must not change location. The user can also manually edit the frozen json files and then launch the bot.
I don't know how can the bot start now without having a frozen file to read from. Will test later
Comments (12)
-
-
-
assigned issue to
-
assigned issue to
-
one static variable in logsFolder ok?
public final static String frozenfolder = Global.logsFolder + "/" + "frozen";
-
- changed status to resolved
defined in settings.java
-
reporter - changed status to open
Having it in the root of the project feels wrong. Being a resource required at runtime has to be stored under the resources/ folder.
This must be reflected in the build gradle task. Please see also
#394 -
"Being a resource required at runtime has to be stored under the resources/ folder." src/main/resources is the folder which is used for packaging the jar. please read up on how this works, and make suggestions based on those standards (linked in the other issue). the folder in the dist folder can be named whatever. Feel free to adapt the filepaths etc, but the name "resources" is reserved for this kind of packaging A folder resources is not related to src/main/resources. If we package up things in the resource folder things have to be loaded via classpath.
-
- changed title to Layout and resources
- edited description
- marked as blocker
-
reporter Issue
#395was marked as a duplicate of this issue. -
the doc regarding resources and layout https://docs.google.com/document/d/1Ex7Xb_Tud63HywnzwL5DRmgaj581_UAwK8nk4kNxVdc/edit
-
Open is the question about scripts.
With current layout
- dist/res => non-changeable static files
- dist/config => configurable files
- dist/scripts (?)
-
- Make sure the above decisions are reflected in Settings.java
- Make sure the above decisions are reflected in build.gradle
- done: Remove duplicate currencies.csv and (remove test/resources/settings.properties )
- done: Remove all files from src/main/resources (?)
-
- changed status to resolved
- Log in to comment