bitspark API wrappers
They use patio in theory
Comments (8)
-
reporter -
BitSpark wrappers now exist in branch feature/BitSpark. They are a copy of the existing Peatio Wrappers used on the internal exchange with a few edits to point them to bitspark instead. i have tested the base functionality using TestWrappers.java and they work as expected. Deeper and independent testing will be required though.
-
reporter Oh, I thought we could reuse the PeatioWrappers and just change the api entry point when constructing the object .
If you think that bitspark requires its own modification than you took the right approach, otherwise we would see several switches in peatioWrapper
-
I thought that it would future proof the wrapper if bitspark ever make modification outside of peatio
-
- changed status to resolved
I have tested against bitSpark and am happy with the functionality of this wrapper. Merging into develop ready for full tests
-
reporter - changed status to open
need to test it the wrapper integration with nubot
-
reporter Before closing this issue we should make sure it is integrated into nubot.
Currently, for example, the bot won't start for bitspark.
Need to edit the Exchange.java file adding it to supported exchange and also edit the README.md with the admitted valued updated.
-
reporter - changed status to resolved
- Log in to comment
https://bitspark.io/documents/api_v2