Commits

Anonymous committed 1d172fb

* Convert the value of the mixpanel.enabled parameter to a boolean -- without that, the dummy mixpanel utility will never be used because 'False' evaluates to True.

Comments (0)

Files changed (2)

pyramid_mixpanel/__init__.py

 import logging
 
 import requests
+from pyramid.settings import asbool
 from zope.interface import implementer
 from zope.interface import Attribute, Interface
 
 
 def includeme(config):
     log.debug('Including pyramid_mixpanel')
-    if config.registry.settings.get("mixpanel.enabled", True):
+    if asbool(config.registry.settings.get("mixpanel.enabled", True)):
         log.debug('Tracking enabled.')
         utility = MixpanelUtility(config.registry.settings)
     else:

pyramid_mixpanel/tests/unittests/test_pyramid_mixpanel.py

     def test_includeme(self, utility):
         from pyramid_mixpanel import includeme
         config = mock.Mock()
+        config.registry.settings = {"mixpanel.token": "foo"}
 
         includeme(config)
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.