display AsP cost for all Enchantments (Traditionsartefakte)
Issue #141
resolved
currently the AsP cost data is contained in the json files but is not properly displayed for the enchantments, neither in the list nor in the detail view
Comments (7)
-
repo owner -
repo owner -
assigned issue to
- marked as enhancement
Nando can make the changes to the JSON files and add the custom format for the info text?
-
assigned issue to
-
reporter The following tasks need to be done:
-
Rework all enchantment jsons
- make sure casting cost is formated correctly as number or an object with abbreviation, name, …
- declare volume expanding as binding cost
- add volume to enchantmentgroups (max volume)
-
adjustments in texts.json
- enchantmentInfo needs to support binding and casting cost
- enchantmentCastingCost needs to be added
-
make sure the values are loaded and displayed correctly for the list view
- make sure to send proper information when loading the “enchantmentInfo”
- show max volume for enchantment objects (binding spell?)
- volume expansion does not cost pAsP for each level!
- available volume and used volume calculation to show error if more enchantments are used that can fit into the artifact
-
-
reporter -
assigned issue to
-
assigned issue to
-
reporter -
reporter - changed version to 13.12
-
repo owner - changed status to resolved
This should be fixe with b4e597e
The casting cost was not loaded correctly or rather not loaded as the correct data type which caused the number in the JSON files to be ignored. Also the info text had no section for the casting cost. I added it but it only shows up if there is casting cost > 0.
- Log in to comment
I just pushed the following change that addresses part of the problem: 0f9f53a
There is a format text in the text.json file, that is used to create the info text in the rules browser on the right side of the TDA window. If you want to change the text in the browser you can adjust the text in texts.json.
The text is used for alle rule elements of the same type. But sometimes the rule elements of the same type have different attributes based on their group, so you would need a different format text for every group. This was already possible for some groups, like chants but I added this now too to enchantments and also made it available to other group, even if it is currently not needed.
What you have to do is add a infotext property to the group with the modified format text. If the group has a format text it will be used instead of the default text. I added it as a example to enchantment group waffenzauber from magic 3. It replaces the format string from the enchantmentInfo property in texts.json.
Now someone needs to check all the different enchantmentgroups and see which one needs to show Ae costs.
In case a group needs to show something else or additonal to Ae cost I would need to make a change to the code to make this additional data available to the format string as a new placeholder.
commit 0f9f53a