Linux changes+general improvements

#3 Open
Repository
Forty-Bot
Branch
default
Repository
OlgahWolgah
Branch
default

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update 
hg pull -r default https://bitbucket.org/Forty-Bot/spotiload
Author
  1. Sean Anderson
Reviewers
Description

Hi, I had a heck of a time getting this to compile properly on linux; here's some changes to make it work better.

  • Update to ptypes 2.1.1. This consisted entirely of changing all instances of ptypes:: to pt:: to reflect changes in the namespace upstream.
  • Created a proper makefile. This one does incremental compilation, so you don't need to recompile everything after making one change, and you can do parallel compilation
  • No longer compile with the shipped libraries. Your users (including myself) may have LAME, libspotify, or ptypes already installed from their dirsto's repos. It is generally agreed to compile against already installed libraries instead of building your own, unless the library has to be compiled statically (which you weren't doing anyway). This reduces the size of the resulting system (no duplicate libraries) and ensures libraries are always up-to-date. Additionally, I had to make some modifications to ptypes to compile correctly (the test cases don't compile because of an ambigious case in the code), so users with a ptypes package in their repos will appreciate this doubly.
  • Added explicit casts to the test cases in utf8.c. gcc was throwing a fit about this.

I accordance with the removed dependancy on included libraries, I suggest you trim down the source tree (i.e. by removing src/external). Sorry about having this all in 2 commits. I didn't think I would need to make so many changes >.> Also didn't realize the LAME files would get modified through building them.

Comments (2)

  1. Brandon J McKay

    Some basic examples of how to run this would be really helpful. I'm not a C programmer of any kind, but would love to use this thing!

    Also, I don't see an issues tab... so just putting this here.