1. OpenUru_org
  2. CWE-ou
  3. Pull requests

Pull requests

#26 Merged at 97147c7
Repository
Lyrositor
Branch
scroll-position
Repository
OpenUru_org
Branch
default

Add functions to fix KI Chat scrolling issue.

Author
  1. Lyrositor
Reviewers
Description

These two Python/Plasma functions are used in the moul-scripts fix for the scrolling KI Chat issue.

It must be pulled in before https://bitbucket.org/OpenUru_org/moulscript-ou/pull-request/19

Comments (2)

  1. Christian Walther

    Looks good. Minor nits that are not reason enough to decline:

    • The docstrings for isAtEnd in pyGUIControlMultiLineEditGlue.cpp and Plasma.py don’t match.
    • It seems overkill that getScrollPosition() should return a Python long, when the internal field is an Int32, which fits in a Python int. But then setScrollPosition wants a long too, so maybe it’s consistent.

    Holding off on merging until we have decided on how to proceed with Minkata testing.