Save not possible when changing a related file opened in an aura bundle

Issue #1084 resolved
Petr Švestka created an issue

When I open a component in a bundle, then switch to, e.g., its JS controller and change parts of the code, I am unable to save the changes to the org. CTRL+S does nothing. I need to force-save it.

When I open the JS controller directly and modify it, then I can save as usual.

It's a minor thing, but with severe consequences where changes may be easily skipped and not saved to the org.

Comments (13)

  1. Scott Wells repo owner

    Yes, this should be fixed in today's build. Sorry for the slight issue. Interestingly it's an issue that's always existed, but the tabbed editors exposed it because of how they work. Let me know if you continue to see the same behavior after updating to today's build (which will be released within the next few hours).

  2. Scott Wells repo owner

    This should be fixed in 2.0.3.3 which I just released. Let me know if you continue to see the same behavior after updating.

  3. Petr Švestka reporter
    • changed status to open

    Hi Scott, I updated to 2.0.3.3 but the issue is still there. PFA the log.

    Kind regards, Petr

  4. Scott Wells repo owner

    Thanks, Petr. I'm not seeing anything obvious in the log. Let me try to reproduce it myself. I'll follow up with you shortly to let you know whether I'm able to see the same behavior.

  5. Scott Wells repo owner

    Petr, I'm unable to reproduce this behavior. I realize I'm about to parrot your original description, but let me explain what I'm doing that's working and perhaps you can tell me what I'm doing differently from you:

    1. Open form.cmp in the editor.
    2. Use Alt+Shift+Right to switch to formController.js, the component's controller JS file, in the same tabbed editor view.
    3. Make a change to formController.js and save it using Ctrl+S. I can see the deployment occurring in the status bar.
    4. Retrieve the project metadata for merge and compare the server's formController.js to the local formController.js to verify that the change was in fact committed to the server.

    UPDATE: I just disabled Override Save All action in Illuminated Cloud>Configure Application>Validation and Deployment and I think I was able to reproduce this behavior successfully. However, with that option enabled (and I do recommend that everyone enable that option), I'm unable to reproduce the behavior. Let me know if that matches your findings. If so, I think I'm going to disable the tabbed editors when that option is disabled because unfortunately I don't think that I'm going to be able to fix this issue given how the default *Save All action works. Let's confirm that you see the same behavior before I do that, though.

  6. Scott Wells repo owner

    Ah...you know what...I can fix this. I'll take care of it and post a new build here for you to verify. Assuming it's all good I'll reissue the latest build with this fix.

  7. Petr Švestka reporter

    Scott, enabling the "Override Save All action" and "Deploy all modified files" helps. With these on, I can deploy modified files within the bundle. I didn't know about this option, sorry!

    Is there a way / need to solve it differently?

    Thanks, Petr

  8. Scott Wells repo owner

    Yeah, turns out it was pretty subtle. Basically when not using the overridden action, a check to see if the saved file is "visible" was failing when the file was from a secondary tab from another file's tabbed editor view. I've just fixed that and am about to issue an update. I decided to go ahead and bump the version number in case anyone else hits this issue who has already updated. I'll let you know when 2.0.3.4 is posted.

  9. Scott Wells repo owner

    Okay, let's try this again. Should be truly fixed in 2.0.3.4 which I just uploaded. Let me know if it doesn't work properly now with Override Save All action enabled or disabled.

  10. Petr Švestka reporter

    Even in 2.0.3.4 the "Override Save All action" needs to be enabled. Otherwise, it won't save/deploy.

  11. Scott Wells repo owner

    Really? That's a bummer. I'm unable to reproduce that locally. I just followed the steps outlined above with that option disabled and it deployed the file in the saved editor just fine. Are you possibly doing something different than what I described above? If so, do you mind providing your precise steps to reproduce it?

  12. Scott Wells repo owner

    Additional fixes delivered in 2.0.3.5. Now if multiple files are changed in a tabbed editor and Ctrl+S/Cmd+S is used (and Override Save All action is enabled), all modified files from the tabbed editor are deployed.

  13. Log in to comment