Cannot create scratch orgs in IC 2.5.7

[Jeff May]

After installing 2.5.7, I cannot create scratch orgs.

The Create Scratch org window appears, but just closes on 'OK'. No prompt for the scratch org metadata file name and no scratch org is created.

Workaround: Downgrade to 2.5.6.

[Scott Wells]

Thanks, Jeff. I'm trying to reproduce this and am not seeing the same behavior. Here's the scratch org creation dialog for me with two dev hubs (usernames redacted but otherwise an exact screenshot):

I think perhaps to understand what might be going on, I might need you to briefly reinstall the new build, enable debug logging for Salesforce DX, reproduce the issue, and provide the resulting log (redacting info as makes sense) for review. I realize that's a major inconvenience, but in the absence of being able to reproduce the same behavior I think it's the best way to figure out what's going on.

[Jeff May]

Yep, that's the dialog. When I click OK after filling in Org Name and Alias, the window closes and I just get the Connections window again.

For everything you do for us all the time, just asking me to install and test is a no-brainer. (If you wanted me to use Windows instead of Linux, in some foreign language, that would be a different story :) )

I will do the install tonight and add logs here.

[Scott Wells]

Thanks, Jeff. What I'll be looking for in the logs is the result of force:org:list which is used to populate the dev hub drop-down and whatever is happening when you click OK in that dialog...which I'm fairly certain just a downstream issue from the problem that's preventing the dev hub drop-down from showing properly. Thanks much again!

[Jeff May]

log file attached with DX settings enabled

[Scott Wells]

Thanks, Jeff! I already see a suspicious stack trace:

2019-04-17 12:30:07,257 [1707764]  ERROR - llij.ide.plugins.PluginManager - Argument for @NotNull parameter 'module' of com/illuminatedcloud/intellij/sfdx/SfdxUtil.getProjectConfigDir must not be null 
java.lang.IllegalArgumentException: Argument for @NotNull parameter 'module' of com/illuminatedcloud/intellij/sfdx/SfdxUtil.getProjectConfigDir must not be null
    at com.illuminatedcloud.intellij.sfdx.SfdxUtil.$$$reportNull$$$0(SfdxUtil.java)
    at com.illuminatedcloud.intellij.sfdx.SfdxUtil.getProjectConfigDir(SfdxUtil.java)
    at com.illuminatedcloud.intellij.settings.application.IlluminatedCloudApplicationConnectionsTab.addScratchOrg(IlluminatedCloudApplicationConnectionsTab.java:462)
    at com.illuminatedcloud.intellij.settings.application.IlluminatedCloudApplicationConnectionsTab$3.actionPerformed(IlluminatedCloudApplicationConnectionsTab.java:240)

Let me investigate why that may be occurring and what needs to happen to address it.

[Scott Wells]

Jeff, can you install this build and see if it resolves the issue? It looks like it was just an incorrect @NotNull annotation disallowing execution from a non-scratch org context.

[Scott Wells]

New build that includes a prospective fix for this issue and fixes for two others reported today. If all checks out, I'll release this tomorrow morning as a hotfix for 2.0.5.7.

[Jeff May]

Hey Scott - that fixed things for me. Back in the 'creating scratch orgs' game. You can mark this issue as resolved as of that build.

[Scott Wells]

Thanks for verifying, Jeff. I'll post the build tomorrow. You won't see the update because you're on the exact build that will be released...unless I have something else come in, in which case I'll let you know that you need to update to it explicitly.

Sorry again for the temporary inconvenience. Thanks again for reporting and verifying.

[Jeff May]

No apologies needed - you've built an excellent but complex tool for us out here in the world and you have better than perfect customer responsiveness.

[Scott Wells]

Fix delivered in 2.0.5.8.