Show meta.xml files stop working after last release

[Sebastian Munoz]

After upgrading to the latest version (2.2.4.6), meta.xml files are always visible

‌

Steps to reproduce:

• Project > src

  • Expand classes (for example)

    • meta.xml are visible even when show meta.xml is deactivated

‌

[Scott Wells]

Unfortunately I’m not seeing that behavior. Can you please provide your idea.log so I can see if there’s some error that might be causing this? Also, can you please provide your project’s .iml file so I can check the configured source roots as that filtering only occurs under source roots.

[Scott Wells]

The most recent build did include new logic in the same area around .forceignore file status highlighting, so I'm suspecting the log will show something in that area.

[Sebastian Munoz]

Yes, its weird, left you the files, let me know if I can help in any other way

[Scott Wells]

Thanks. Unfortunately there’s not anything telling in that log, though I did see one other minor unrelated thing that I’ve fixed for the next build. Could you please toggle that option and apply the changes, then toggle it back and apply again, then provide the resulting idea.log for review? I’m hoping that will show something. If not, I’ll add debug logging in this area for this week’s build and we can use that to diagnose whatever is happening.

[Scott Wells]

Here's another route we can go with this. This is a build of 2.2.4.6 with extensive debug logging added to the relevant logic. You can install it by downloading (but not extracting) the attached archive and using Settings / Preferences > Plugins > Install plugin from disk (under the gear drop-down menu).

Then add the following to Help > Diagnostic Tools > Debug Log Settings:

#com.illuminatedcloud.intellij.structureview.IlluminatedCloudProjectTreeStructureProvider

and then, with folders containing meta.xml files that should be hidden expanded, toggle the Show meta.xml files option off and on. Finally attach the resulting idea.log file for review as it should show how the Project view is being filtered based on that setting.

[Sebastian Munoz]

Hey Scott, follow your instructions and here is the log, not sure if related, but look at lines 173 and 296, both logs were generated when switch show meta.xml.

[Scott Wells]

Those Argument for @NotNull parameter messages are for the other, unrelated issue I mentioned that I found and fixed based on your previous log. Those are in a completely distinct action and shouldn’t affect the way the Project view is rendered.

I’m not seeing any activity from IlluminatedCloudProjectTreeStructureProvider that is for meta.xml files. Did you expand project tree nodes that contain meta.xml files that are not being hidden properly? If so, what are the project-relative paths to those files so I can correlate them to the source root configuration in your .iml file?

[Sebastian Munoz]

Hey Scott, I've repeated the steps you described, let me know if you see logs now.

You want me to run a fresh install? if so, can you help me to backup my current connections? I have a lot and I don't want to loose it.

[Scott Wells]

Hmmmm…that doesn’t include the expected/required diagnostic information either. In the next few hours I’ll be releasing this week’s build which includes, among quite a few other things, a fix for that Argument for @NotNull parameter issue in your log and one other defensive change in this area. Let’s see if it still happens with that build and, if so, we’ll continue to collect diagnostics until we corner it. Let’s hold off on a reinstall as I wouldn’t expect that to change anything.

[Sebastian Munoz]

Perfect! thanks

[Scott Wells]

2.2.4.7 has been released. Please update and let me know if the problem is still present. If so, I may post a new build with diagnostic logging (as it wasn’t included in this build) to see if we can capture this in action.

[Sebastian Munoz]

Hey Scott, same issue, you want me to sent you the log? and project iml?

[Scott Wells]

Go ahead and send your latest log. It won’t have the same debug logging but I can scan for an new errors. Also, can you specify the project-relative paths of the files that aren’t having their meta.xml files properly hidden so I can correlate them to your project’s configured source roots?

[Sebastian Munoz]

Hey Scott, I found where is the error, this only happens when you are in package view, look at the screenshots.

Not sure if the plugin can be downgraded, but if you have the previous version, I can show you how it was working before.

let me know if you can reproduce now

[Scott Wells]

Ah, now it makes sense! Yes, I did fix a long-standing issue where nodes in the Project view (and elsewhere) were being treated as if they in a Java package hierarchy, so you’d see path.to.metadatatype.MetadataName instead of /path/to/metadatatype/MetadataName in certain contexts. It looks like that fix ended up causing the specialized project tree structure provider that filters out meta.xml files to miss things in Java-specific contexts like the Packages. I just committed a fix for that and now it should work properly in even those contexts:

‌

Thanks for digging in and figuring out the actual root cause! The fix will be included in next week’s build.

[Sebastian Munoz]

YEAH! Thanks Scott

[Scott Wells]

Delivered in 2.2.4.8.