Upsert using sObjectField displays error in editor

Issue #638 resolved
Eric Alexander created an issue

When using upsert with an external Id field the editor displays an error as attached "';' Expected, got '.'"

upsert acc Account.Name //I know not a real external Id but this is where it occurs

Screen Shot 2017-06-26 at 11.01.11 PM.png

Comments (14)

  1. Scott Wells repo owner's the space-delimited parameter list. Right now my grammar expects a single expression argument. Should be easy enough to address for all of the DML operators by allowing one or more space-delimited expressions to be specified. Thanks for reporting!

  2. Scott Wells repo owner

    My original assessment was wrong. The issue was that my parser was only allowing a simple identifier for the optional external ID in an upsert statement. I've changed that to allow a full reference expression. The fix will be in the next build.

  3. Brandon Parker

    Hey Scott,

    I'm running v1.8.0.0 and seeing this issue still occurring.

    Screen Shot 2017-09-14 at 8.28.00 AM.png

    Anyone else seeing this in v1.8.0.0? error.png

  4. Scott Wells repo owner
    • changed status to open

    I'll take a look, Brandon. I thought it had been fixed but sounds like either it was inadvertently regressed or never fully fixed.

  5. Scott Wells repo owner

    Brandon, I'm unable to reproduce this in the version that I'll be releasing tomorrow. Here's a screenshot of the same thing that you've displayed above with no errors:


    Please let me know after updating to tomorrow whether this is still an issue for you, and if so, please send me a sample file that reproduces the issue if possible. Thanks!

  6. Brandon Parker

    Scott, I'm showing that IC is running I believe I've been auto-prompted to update the plugin before but that's currently not happening. How do I manually update the plugin to the latest version?


  7. Scott Wells repo owner

    Brandon, I haven't quite released it yet. I'd planned to do so yesterday morning but ended up in a long series of meetings. By the time they were over it was later in the day than I'm comfortable releasing (I prefer to have a good block of hours in case there are any immediate issues). I'm going to post the update in the next hour or two. I'll resolve this issue (and many others) as part of the release process, so that will be your cue to update.

  8. Brandon Parker

    Thanks Scott! Very much appreciate your responsiveness on this. Hopefully see you at DF this year?

  9. Log in to comment