Shell full may be invalid without PRV

Issue #5 resolved
Scott Runnels
repo owner created an issue

It appears that AFFTAC's model for shell full assumes the presence of a PRV. When a user runs AFFTAC without a PRV and the tank becomes shell full, AFFTAC may therefore be reporting an invalid value for pressure inside the tank.

Comments (1)

  1. Scott Runnels reporter

    This issue was investigated by running the legacy and new (in the next AFFTAC release) dynamic shell full model on Example 1.1 at a small timestep (.001), and with the PRV removed. They both gave very similar answers. That, along with recent developments in that part of the source code as well as verification testing indicate that the model is functioning as expected.

  2. Log in to comment