Robert Brewer avatar Robert Brewer committed 7732397

A more inclusive, os-level check for staticfilter uplevel attacks.

Comments (0)

Files changed (1)


             if not, path):
+        root = config.get('static_filter.root', '').rstrip(r"\/")
         filename = config.get('static_filter.file')
-        if not filename:
+        if filename:
+            staticDir = None
+        else:
             staticDir = config.get('static_filter.dir')
             if not staticDir:
                 msg = ("StaticFilter requires either static_filter.file "
             extraPath = extraPath.lstrip(r"\/")
             extraPath = urllib.unquote(extraPath)
             # If extraPath is "", filename will end in a slash
-            if '..' in extraPath:
-                # Disallow '..' (security flaw)
-                raise cherrypy.HTTPError(403) # Forbidden
             filename = os.path.join(staticDir, extraPath)
         # If filename is relative, make absolute using "root".
         # Note that, if "root" isn't defined, we still may send
         # a relative path to serveFile.
         if not os.path.isabs(filename):
-            root = config.get('static_filter.root', '').rstrip(r"\/")
             if not root:
                 msg = ("StaticFilter requires an absolute final path. "
                        "Make static_filter.dir, .file, or .root absolute.")
                 raise cherrypy.WrongConfigValue(msg)
             filename = os.path.join(root, filename)
+        # If we used static_filter.dir, then there's a chance that the
+        # extraPath pulled from the URL might have ".." or similar uplevel
+        # attacks in it. Check that the final file is a child of staticDir.
+        # Note that we do not check static_filter.file--that can point
+        # anywhere (since it does not use the request URL).
+        if staticDir:
+            if not os.path.isabs(staticDir):
+                staticDir = os.path.join(root, staticDir)
+            if not os.path.normpath(filename).startswith(os.path.normpath(staticDir)):
+                raise cherrypy.HTTPError(403) # Forbidden
             request.execute_main = False
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.