Implement FS Switchers

[Leonardo Valeri Manera]

TODO:

• Mk2: DONE
• S2: DONE
• S2W: DONE
• HL: DONE
• MK1: DONE
• A1C: DONE
• Panels: DONE
• Landing Gear: DONE
• RCS Blocks: DONE

[Leonardo Valeri Manera]

• Mk2 SAS done.
• S2 SAS done
• HL Extensions done.
• A1S Light done.
• HL Main missing Cargo Tail. I see 2 texture references in the model, what textures do I need here?

[Christian Gerefalk]

HL Universal Body 0.5m, 2m, 6m: all versions got round collision mesh making flat versions have a large gap when you attach stuff to the sides, no version contains fuel.

Universal tail, cargo bays, cargo tail doesn't have a round version, I assume that's a lot of work to add, and cargo tail and cargo bays make sense to leave out, but universal tail at least should have a round version to go with the round universal parts.

Round to flat HL adapter would also be nice.

[Artyom Zuev]

0.5m round to flat adapter is already there in the universal 0.5m HL part. It's a very short transition and including it into the tail part makes no sense. 0.5m and 2m HL do contain LF/LFO/RCS subtypes. Collision should be inherited from a flat part by default, might be a mistake in the part setup.

[Christian Gerefalk]

Fuel subtypes don't work, they're all empty (S2 univeral works, has fuel/lfo/rcs but HL are empty), sorry didn't spot the 0.5m adapter amongst those versions, makes sense to use that.

[Artyom Zuev]

Maybe Tav haven't got around to adding resource data for those subtypes yet.

[Christian Gerefalk]

Had a quick look in the .cfg of the S2 and HL parts, looks identical except for the values obviously, and 2x the variants for round and flat, and obviously +1 on the 0.5 for the adapter version:

http://i.imgur.com/K66agxK.png

But yeah not sure what the actual problem is.

[Leonardo Valeri Manera]

I need to go through and check they all work properly, yeah. I'll get that tonight.

Re: collisions, there's a new FSmeshSwitch value I need to add, affectColliders=true.

[Artyom Zuev]

Oh, so it looks for colliders and enables them individually? That's not particularly neat, tons of universal parts, especially some like HX hangars, are using multiple unique colliders parented to every subtype gameobject, and are expected to be untouched, becoming enabled when their parented gameobject becomes enabled. There is always a collider outside of toggled gameobjects, but it only covers the shape that every subtype covers.

[Christian Gerefalk]

Btw the S2->2.5m adapter isn't in the 0.5 universal, just a thought.

[Leonardo Valeri Manera]

We might need to tweak the parenting of some colliders, but it should not be doing anything to colliders not parented to an object its enabling/disabling.

It has to go in and disable them if that flag is on though, by default KSP will enable every single collider in the .mu when it spawns the part unless its attached to an animation that controls its state and its start state is disabled.

[Leonardo Valeri Manera]

Artyom, of the HX stuff, which parts (if any) need collider switching apart from hangars?

[Leonardo Valeri Manera]

Just waiting on word from snjo regarding animated parts and this can be closed.

[Artyom Zuev]

Issues with animated parts resolved with Firespitter.dll update.

[Leonardo Valeri Manera]

per-tank costs and mass are in, there are certainly bugs in the numbers, so lets collect them here.

[Leonardo Valeri Manera]

I think we're done here.