Shrine of the champion gives 5 extra XP by error

[joseasoler]

Should be checked in MNAI first.

---

Yes, MNAI adds an additional +5 XP for buildings with the FreePromotionPick flag. This is done in CvCity::getProductionExperience (in CvCity.cpp). The free promotion seems to get added in CvCity::applyBuildEffects.

In other words, in order to change this behaviour back to what it was in vanilla Ffh2, you need to edit the DLL.

The change was made in this commit (https://bitbucket.org/Tholal/more-naval-ai/commits/f56ef0ea52d540fc7b6e89fe687661bf5838a476), the description of which seems to indicate that it was intended to only affect AI decisions. However, getProductionExperience is used in addProductionExperience, which is in turn used in applyBuildEffects.

[joseasoler]

Already present in MNAI repo: https://bitbucket.org/Tholal/more-naval-ai/issues/96/giving-extra-experience-to-units-when#comment-None